Re: [f2fs-dev] [PATCH Vx 1/1] f2fs: Avoid deadlock between writeback and checkpoint

2021-12-17 Thread Chao Yu
On 2021/12/18 0:59, Jaegeuk Kim wrote: On 12/17, Chao Yu wrote: On 2021/11/20 9:50, Chao Yu wrote: On 2021/11/18 14:46, Chao Yu wrote: On 2021/11/18 0:56, Jaegeuk Kim wrote: On 11/09, niuzhigu...@gmail.com wrote: From: Zhiguo Niu There could be a scenario as following: The inodeA and

Re: [f2fs-dev] [PATCH Vx 1/1] f2fs: Avoid deadlock between writeback and checkpoint

2021-12-17 Thread Jaegeuk Kim
On 12/17, Chao Yu wrote: > On 2021/11/20 9:50, Chao Yu wrote: > > On 2021/11/18 14:46, Chao Yu wrote: > > > On 2021/11/18 0:56, Jaegeuk Kim wrote: > > > > On 11/09, niuzhigu...@gmail.com wrote: > > > > > From: Zhiguo Niu > > > > > > > > > > There could be a scenario as following: > > > > > The

Re: [f2fs-dev] [PATCH -next] f2fs: Simplify bool conversion

2021-12-17 Thread Jaegeuk Kim
On 12/17, Chao Yu wrote: > On 2021/12/15 10:38, Yang Li wrote: > > Fix the following coccicheck warning: > > ./fs/f2fs/sysfs.c:491:41-46: WARNING: conversion to bool not needed here > > > > Reported-by: Abaci Robot > > Signed-off-by: Yang Li > > Thanks for fixing this issue, do you mind

Re: [f2fs-dev] 回复:[PATCH -next] f2fs: Simplify bool conversion

2021-12-17 Thread Jaegeuk Kim
On 12/17, Yang.Lee wrote: > "Why not this? > sbi->gc_urgent_high_limited = t;" > > Since 't' is an unsigned long type and 'gc_urgent_high_limited' is a bool > type, the assignment operation will cause a new warning. Huh, that doesn't allow auto casting as well. > > >

Re: [f2fs-dev] [PATCH Vx 1/1] f2fs: Avoid deadlock between writeback and checkpoint

2021-12-17 Thread Jaegeuk Kim
On 12/17, Zhiguo Niu wrote: > Hi Jaegeuk, > > As f2fs_write_node_pages codes: > > 2060 > > blk_start_plug > ( >

Re: [f2fs-dev] [PATCH Vx 1/1] f2fs: Avoid deadlock between writeback and checkpoint

2021-12-17 Thread Chao Yu
On 2021/11/20 9:50, Chao Yu wrote: On 2021/11/18 14:46, Chao Yu wrote: On 2021/11/18 0:56, Jaegeuk Kim wrote: On 11/09, niuzhigu...@gmail.com wrote: From: Zhiguo Niu There could be a scenario as following: The inodeA and inodeB are in b_io queue of writeback inodeA : f2fs's node inode