Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations

2021-12-29 Thread Chao Yu
On 2021/12/3 5:28, Jaegeuk Kim wrote: On 12/02, Jaegeuk Kim wrote: On 12/02, Eric Biggers wrote: On Thu, Dec 02, 2021 at 11:00:47AM -0800, Jaegeuk Kim wrote: On 12/02, Jaegeuk Kim wrote: On 12/02, Eric Biggers wrote: On Thu, Dec 02, 2021 at 10:04:11PM +0800, Chao Yu wrote: On 2021/12/2 12:1

Re: [f2fs-dev] [PATCH 2/2] f2fs: do not bother checkpoint by f2fs_get_node_info

2021-12-29 Thread Chao Yu
On 2021/12/15 2:24, Jaegeuk Kim wrote: This patch tries to mitigate lock contention between f2fs_write_checkpoint and f2fs_get_node_info along with nat_tree_lock. The idea is, if checkpoint is currently running, other threads that try to grab nat_tree_lock would be better to wait for checkpoint.

Re: [f2fs-dev] [PATCH 1/2] f2fs: avoid down_write on nat_tree_lock during checkpoint

2021-12-29 Thread Chao Yu
On 2021/12/15 2:24, Jaegeuk Kim wrote: Let's cache nat entry if there's no lock contention only. Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourc

Re: [f2fs-dev] [PATCH v3] f2fs: remove redunant invalidate compress pages

2021-12-29 Thread Chao Yu
On 2021/12/29 17:47, Fengnan Chang wrote: Compress page will invalidate in truncate block process too, so remove redunant invalidate compress pages in f2fs_evict_inode. Signed-off-by: Fengnan Chang Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-dev

Re: [f2fs-dev] [PATCH] fsck.f2fs: Add progression feedback

2021-12-29 Thread Antoine Viallon via Linux-f2fs-devel
Some variable naming mistaskes were made in the last patch, here is an updated version. --- fsck/fsck.c | 9 + fsck/fsck.h | 1 + 2 files changed, 10 insertions(+) diff --git a/fsck/fsck.c b/fsck/fsck.c index ecd87af..921db0f 100644 --- a/fsck/fsck.c +++ b/fsck/fsck.c @@ -546,6 +546,15 @

[f2fs-dev] [PATCH] fsck.f2fs: Add progression feedback

2021-12-29 Thread Antoine Viallon via Linux-f2fs-devel
On large SSDs filled with lots of data, fsck.f2fs can be very long to finish. For instance, on my 1TB SSD filled at 99%, it takes literally 5 minutes to complete. Currently, the only way to have some feedback is to enable debug output, but it is very verbose and doesn't tell the actual progress.

[f2fs-dev] [PATCH] fsck.f2fs: Add progression feedback

2021-12-29 Thread Antoine Viallon via Linux-f2fs-devel
On large SSDs filled with lots of data, fsck.f2fs can be very long to finish. For instance, on my 1TB SSD filled at 99%, it takes literally 5 minutes to complete. Currently, the only way to have some feedback is to enable debug output, but it is very verbose and doesn't tell the actual progress.

[f2fs-dev] [PATCH v3] f2fs: remove redunant invalidate compress pages

2021-12-29 Thread Fengnan Chang
Compress page will invalidate in truncate block process too, so remove redunant invalidate compress pages in f2fs_evict_inode. Signed-off-by: Fengnan Chang --- fs/f2fs/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index 2ab3b42473