Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations

2022-01-05 Thread Jaegeuk Kim
On 01/05, Chao Yu wrote: > On 2022/1/5 5:24, Jaegeuk Kim wrote: > > From: Eric Biggers > > > > Implement 'struct iomap_ops' for f2fs, in preparation for making f2fs > > use iomap for direct I/O. > > > > Note that this may be used for other things besides direct I/O in the > > future; however, fo

Re: [f2fs-dev] [PATCH 3/6] f2fs: do not expose unwritten blocks to user by DIO

2022-01-05 Thread Jaegeuk Kim
On 01/05, Chao Yu wrote: > On 2022/1/5 5:24, Jaegeuk Kim wrote: > > DIO preallocates physical blocks before writing data, but if an error > > occurrs > > or power-cut happens, we can see block contents from the disk. This patch > > tries > > to fix it by 1) turning to buffered writes for DIO into

Re: [f2fs-dev] [PATCH] f2fs: quota: fix potential deadlock

2022-01-05 Thread Chao Yu
On 2022/1/5 23:01, Greg KH wrote: On Tue, Jan 04, 2022 at 11:48:25PM +0800, Chao Yu wrote: On 2022/1/4 23:17, Greg KH wrote: On Tue, Jan 04, 2022 at 11:05:36PM +0800, Chao Yu wrote: On 2022/1/4 21:18, Greg KH wrote: On Tue, Jan 04, 2022 at 09:05:13PM +0800, Chao Yu wrote: commit a5c0042200b2

Re: [f2fs-dev] [PATCH] f2fs: quota: fix potential deadlock

2022-01-05 Thread Greg KH
On Tue, Jan 04, 2022 at 11:48:25PM +0800, Chao Yu wrote: > On 2022/1/4 23:17, Greg KH wrote: > > On Tue, Jan 04, 2022 at 11:05:36PM +0800, Chao Yu wrote: > > > On 2022/1/4 21:18, Greg KH wrote: > > > > On Tue, Jan 04, 2022 at 09:05:13PM +0800, Chao Yu wrote: > > > > > commit a5c0042200b28fff3bde6fa

Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations

2022-01-05 Thread Chao Yu
On 2022/1/5 5:24, Jaegeuk Kim wrote: From: Eric Biggers Implement 'struct iomap_ops' for f2fs, in preparation for making f2fs use iomap for direct I/O. Note that this may be used for other things besides direct I/O in the future; however, for now I've only tested it for direct I/O. Signed-off

Re: [f2fs-dev] [PATCH 3/6] f2fs: do not expose unwritten blocks to user by DIO

2022-01-05 Thread Chao Yu
On 2022/1/5 5:24, Jaegeuk Kim wrote: DIO preallocates physical blocks before writing data, but if an error occurrs or power-cut happens, we can see block contents from the disk. This patch tries to fix it by 1) turning to buffered writes for DIO into holes, 2) truncating unwritten blocks from err