[f2fs-dev] [RFC PATCH] f2fs: fix compress file start atomic write may cause data corruption

2022-03-04 Thread Fengnan Chang
When compressed file has blocks, start atomic write will be failed, but still set FI_ATOMIC_FILE flag, if write partial cluster and commit atomic write will cause data corruption. Fixes: 4c8ff7095bef (f2fs: support data compression) Fixes: 7eab7a696827 (f2fs: compress: remove unneeded read when rew

Re: [f2fs-dev] [PATCH 06/11] ceph: remove reliance on bdi congestion

2022-03-04 Thread Jeff Layton
On Fri, 2022-03-04 at 13:47 +1100, NeilBrown wrote: > On Thu, 24 Feb 2022, Jeff Layton wrote: > > On Thu, 2022-02-24 at 16:41 +1100, NeilBrown wrote: > > > On Thu, 24 Feb 2022, Jeff Layton wrote: > > > > On Tue, 2022-02-22 at 14:17 +1100, NeilBrown wrote: > > > > > The bdi congestion tracking in no

Re: [f2fs-dev] [PATCH 2/2] f2fs: introduce F2FS_UNFAIR_RWSEM to support unfair rwsem

2022-03-04 Thread Chao Yu
On 2022/3/4 10:19, Jaegeuk Kim wrote: Unfair rwsem should be used when blk-cg is on. Otherwise, there is regression. FYI, we noticed a -26.7% regression of aim7.jobs-per-min due to commit: commit: e4544b63a7ee49e7fbebf35ece0a6acd3b9617ae ("f2fs: move f2fs to use reader-unfair rwsems") https://

Re: [f2fs-dev] [PATCH 1/2] f2fs: avoid an infinite loop in f2fs_sync_dirty_inodes

2022-03-04 Thread Chao Yu
On 2022/3/4 10:19, Jaegeuk Kim wrote: If one read IO is always failing, we can fall into an infinite loop in f2fs_sync_dirty_inodes. This happens during xfstests/generic/475. [ 142.803335] Buffer I/O error on dev dm-1, logical block 8388592, async page read ... [ 382.887210] submit_bio_noacc