Re: [f2fs-dev] [PATCH v4 1/8] fs: move sgid strip operation from inode_init_owner into inode_sgid_strip

2022-04-20 Thread xuyang2018...@fujitsu.com
on 2022/4/21 5:52, Dave Chinner wrote: > On Wed, Apr 20, 2022 at 01:27:39AM +, xuyang2018...@fujitsu.com wrote: >> on 2022/4/19 22:05, Christian Brauner wrote: >>> On Tue, Apr 19, 2022 at 07:47:07PM +0800, Yang Xu wrote: This has no functional change. Just create and export inode_sgid_stri

Re: [f2fs-dev] [PATCH v4 1/8] fs: move sgid strip operation from inode_init_owner into inode_sgid_strip

2022-04-20 Thread Dave Chinner
On Wed, Apr 20, 2022 at 01:27:39AM +, xuyang2018...@fujitsu.com wrote: > on 2022/4/19 22:05, Christian Brauner wrote: > > On Tue, Apr 19, 2022 at 07:47:07PM +0800, Yang Xu wrote: > >> This has no functional change. Just create and export inode_sgid_strip api > >> for > >> the subsequent patch.

Re: [f2fs-dev] Baseline for f2fs

2022-04-20 Thread Luis Chamberlain
On Wed, Apr 20, 2022 at 11:12:33AM -0700, Jaegeuk Kim wrote: > On 04/19, Luis Chamberlain wrote: > > On Tue, Apr 19, 2022 at 4:26 PM Luis Chamberlain wrote: > > > Oh... so this is not upstream... I see.. ok hrm.. > > > > Any plans to try to upstream your delta? > > Not for now. :) Why not ? :)

Re: [f2fs-dev] [PATCH] f2fs: use flush command instead of FUA for zoned device

2022-04-20 Thread Jaegeuk Kim
On 04/19, Christoph Hellwig wrote: > On Tue, Apr 19, 2022 at 02:57:03PM -0700, Jaegeuk Kim wrote: > > The block layer for zoned disk can reorder the FUA'ed IOs. Let's use flush > > command to keep the write order. > > The block layer can reorder all commands. Given that FUA only affects > the com

Re: [f2fs-dev] Baseline for f2fs

2022-04-20 Thread Jaegeuk Kim
On 04/19, Luis Chamberlain wrote: > On Tue, Apr 19, 2022 at 4:26 PM Luis Chamberlain wrote: > > Oh... so this is not upstream... I see.. ok hrm.. > > Any plans to try to upstream your delta? Not for now. :) > > Luis ___ Linux-f2fs-devel mailing

Re: [f2fs-dev] [PATCH v2] libf2fs: don't allow mkfs / fsck on non power-of-2 zoned devices

2022-04-20 Thread Chao Yu
On 2022/4/13 20:29, Pankaj Raghav wrote: From: Luis Chamberlain f2fs currently only work with zoned storage devices with a zone size which is a power of 2 (PO2). So check if a non-power of 2 zoned device is found, and if so disallow its use. This prevents users from incorrectly using these devi

Re: [f2fs-dev] [PATCH v2] dump.f2fs: add -I nid to dump inode by scan full disk

2022-04-20 Thread Chao Yu
On 2022/4/20 15:27, Yufen Yu via Linux-f2fs-devel wrote: On 2022/4/19 10:10, Chao Yu wrote: On 2022/4/18 10:43, Yufen Yu via Linux-f2fs-devel wrote: Usage: dump.f2fs -I [inode nid] /dev/sda This feature can be useful for some bugs caused by system crash. We not only need dump current val

Re: [f2fs-dev] [PATCH v2] libf2fs: don't allow mkfs / fsck on non power-of-2 zoned devices

2022-04-20 Thread Pankaj Raghav
On 2022-04-20 01:07, Jaegeuk Kim wrote: >> TL;DR until we change some calculations in f2fs for zoned device to be >> generic, we need to bail out during mkfs time for non power of 2 zone >> size devices. > > Ah, I see. Yeah, that in f2fs is actually PO2. Let me merge this patch to > force it befor

Re: [f2fs-dev] [PATCH v2] libf2fs: don't allow mkfs / fsck on non power-of-2 zoned devices

2022-04-20 Thread Pankaj Raghav
On 2022-04-20 01:07, Jaegeuk Kim wrote:>> TL;DR until we change some calculations in f2fs for zoned device to be >> generic, we need to bail out during mkfs time for non power of 2 zone >> size devices. > > Ah, I see. Yeah, that in f2fs is actually PO2. Let me merge this patch to > force it before

Re: [f2fs-dev] [PATCH v2] dump.f2fs: add -I nid to dump inode by scan full disk

2022-04-20 Thread Yufen Yu via Linux-f2fs-devel
On 2022/4/19 10:10, Chao Yu wrote: On 2022/4/18 10:43, Yufen Yu via Linux-f2fs-devel wrote: Usage: dump.f2fs -I [inode nid] /dev/sda This feature can be useful for some bugs caused by system crash. We not only need dump current valid node page, but alse the history data in disk, which can

[f2fs-dev] [PATCH] f2fs: Remove useless NULL assign value for acl and default_acl

2022-04-20 Thread Yang Xu
Like other filesystem use ${fs}_init_acl and posix_acl_create function, we don't need to assign NULL for acl and default_acl pointer because f2fs_acl_create will do this job. So remove it. Signed-off-by: Yang Xu --- fs/f2fs/acl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git