[f2fs-dev] [Bug 215895] kernel BUG at fs/inode.c:611!

2022-04-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215895 --- Comment #2 from bughunter (yanm...@tju.edu.cn) --- This bug disappears after adding the patch! Thank you for helping me solve the problem :) -- You may reply to this email to add a comment. You are receiving this mail because: You are watch

[f2fs-dev] [Bug 215914] kernel hangs after mounting the image

2022-04-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215914 --- Comment #1 from bughunter (yanm...@tju.edu.cn) --- This bug has been fixed :) Thank you for your prompt reply! -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

[f2fs-dev] [Bug 215916] kernel BUG at fs/f2fs/segment.c:2560!

2022-04-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215916 --- Comment #4 from bughunter (yanm...@tju.edu.cn) --- After I compile the kernel again, this has been fixed. Maybe I've done something wrong before. Thank you! -- You may reply to this email to add a comment. You are receiving this mail becaus

[f2fs-dev] [PATCH] f2fs: fix deadloop in foreground GC

2022-04-29 Thread Chao Yu
As Yanming reported in bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215914 The root cause is: in a very small sized image, it's very easy to exceed threshold of foreground GC, if we calculate free space and dirty data based on section granularity, in corner case, has_not_enough_free_secs

[f2fs-dev] [PATCH v3 7/7] f2fs: Reuse generic_ci_match for ci comparisons

2022-04-29 Thread Gabriel Krisman Bertazi
Now that ci_match is part of libfs, make f2fs reuse it instead of having a different implementation. Signed-off-by: Gabriel Krisman Bertazi --- fs/f2fs/dir.c | 58 --- 1 file changed, 4 insertions(+), 54 deletions(-) diff --git a/fs/f2fs/dir.c b/f

[f2fs-dev] [PATCH v3 0/7] Clean up the case-insenstive lookup path

2022-04-29 Thread Gabriel Krisman Bertazi
This is the v3 of this series. It fixes a build error when building filesystems as a module on the previous series. * v2 This is the v2 of this series. it applies Eric's comments and extend the series to complete the merge of generic_ci_match for ext4 and f2fs. * Original cover letter The cas

[f2fs-dev] [PATCH v3 4/7] ext4: Simplify hash check on ext4_match

2022-04-29 Thread Gabriel Krisman Bertazi
The existence of fname->cf_name.name requires s_encoding & IS_CASEFOLDED, therefore this can be simplified. Signed-off-by: Gabriel Krisman Bertazi --- fs/ext4/namei.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 5

[f2fs-dev] [PATCH v3 1/7] ext4: Match the f2fs ci_compare implementation

2022-04-29 Thread Gabriel Krisman Bertazi
ext4_ci_compare originally follows utf8_*_strcmp, which means return zero on match. This means that every usage of that in ext4 negates the return. Turn it into a predicate function, let it follow the kernel convention and return true on match, which means it's now the same as its f2fs counterpar

[f2fs-dev] [PATCH v3 5/7] ext4: Log error when lookup of encoded dentry fails

2022-04-29 Thread Gabriel Krisman Bertazi
If the volume is in strict mode, ext4_ci_compare can report a broken encoding name. This will not trigger on a bad lookup, which is caught earlier, only if the actual disk name is bad. Signed-off-by: Gabriel Krisman Bertazi --- Changes since v1: - reword error message "file in directory" ->

[f2fs-dev] [PATCH v3 3/7] ext4: Implement ci comparison using unicode_name

2022-04-29 Thread Gabriel Krisman Bertazi
By using a new type here, we can hide most of the caching casefold logic from ext4. The condition in ext4_match is now quite redundant, but this is addressed in the next patch. This doesn't use ext4_filename to keep it generic, since the function will be moved to libfs to be shared with f2fs. Si

[f2fs-dev] [PATCH v3 6/7] ext4: Move ext4_match_ci into libfs

2022-04-29 Thread Gabriel Krisman Bertazi
Matching case-insensitive names is a generic operation and can be shared with f2fs. Move it next to the rest of the shared casefold fs code. Signed-off-by: Gabriel Krisman Bertazi --- fs/ext4/namei.c| 62 +- fs/libfs.c | 61 +++

[f2fs-dev] [PATCH v3 2/7] ext4: Simplify the handling of cached insensitive names

2022-04-29 Thread Gabriel Krisman Bertazi
Keeping it as qstr avoids the unnecessary conversion in ext4_match Signed-off-by: Gabriel Krisman Bertazi -- Changes since v1: - Simplify hunk (eric) --- fs/ext4/ext4.h | 2 +- fs/ext4/namei.c | 22 +++--- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/fs/e

Re: [f2fs-dev] [PATCH 06/16] nvmet: use blk_queue_zone_no()

2022-04-29 Thread Adam Manzanares
On Wed, Apr 27, 2022 at 06:02:45PM +0200, Pankaj Raghav wrote: > From: Luis Chamberlain > > Instead of open coding the number of zones given a sector, use the helper > blk_queue_zone_no(). This let's us make modifications to the math if > needed in one place and adds now support for npo2 zone dev

Re: [f2fs-dev] [PATCH v2 7/7] f2fs: Reuse generic_ci_match for ci comparisons

2022-04-29 Thread Gabriel Krisman Bertazi
t tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: > https://github.com/intel-lab-lkp/linux/commits/Gabriel-Krisman-Bertazi/Clean-up-the-case-insenstive-lookup-path

Re: [f2fs-dev] [PATCH 01/16] block: make blkdev_nr_zones and blk_queue_zone_no generic for npo2 zsze

2022-04-29 Thread Adam Manzanares
On Wed, Apr 27, 2022 at 06:02:40PM +0200, Pankaj Raghav wrote: > Adapt blkdev_nr_zones and blk_queue_zone_no function so that it can > also work for non-power-of-2 zone sizes. > > As the existing deployments of zoned devices had power-of-2 > assumption, power-of-2 optimized calculation is kept for

Re: [f2fs-dev] [PATCH 05/16] nvme: zns: Allow ZNS drives that have non-power_of_2 zone size

2022-04-29 Thread Adam Manzanares
On Wed, Apr 27, 2022 at 06:02:44PM +0200, Pankaj Raghav wrote: > Remove the condition which disallows non-power_of_2 zone size ZNS drive > to be updated and use generic method to calculate number of zones > instead of relying on log and shift based calculation on zone size. > > The power_of_2 calc

Re: [f2fs-dev] [PATCH 13/16] null_blk: allow non power of 2 zoned devices

2022-04-29 Thread Adam Manzanares
On Wed, Apr 27, 2022 at 06:02:52PM +0200, Pankaj Raghav wrote: > Convert the power of 2 based calculation with zone size to be generic in > null_zone_no with optimization for power of 2 based zone sizes. > > The nr_zones calculation in null_init_zoned_dev has been replaced with a > division withou

[f2fs-dev] [Bug 215916] kernel BUG at fs/f2fs/segment.c:2560!

2022-04-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215916 --- Comment #3 from Chao Yu (c...@kernel.org) --- Could you please check your testcase? The testcase won't panic system and there is no failure log printed and then I try to mount it again, it fails mount() and prints newly added log in my pa

[f2fs-dev] Consulting and project financing.

2022-04-29 Thread mohammed saeeda
Salam alaikum, I am the investment officer of UAE based investment company who are ready to fund projects outside UAE, in the form of debt finance. We grant loan to both Corporate and private entities at a low interest rate of 2% ROI per annum. The terms are very flexible and interesting.Kindl

[f2fs-dev] [Bug 215916] kernel BUG at fs/f2fs/segment.c:2560!

2022-04-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215916 --- Comment #2 from bughunter (yanm...@tju.edu.cn) --- I've tried this patch, but it seems that this bug still exists :( -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the

[f2fs-dev] [Bug 215916] kernel BUG at fs/f2fs/segment.c:2560!

2022-04-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215916 Chao Yu (c...@kernel.org) changed: What|Removed |Added Status|NEW |ASSIGNED CC|

[f2fs-dev] [PATCH] f2fs: fix to do sanity check on total_data_blocks

2022-04-29 Thread Chao Yu
As Yanming reported in bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215916 The kernel message is shown below: kernel BUG at fs/f2fs/segment.c:2560! Call Trace: allocate_segment_by_default+0x228/0x440 f2fs_allocate_data_block+0x13d1/0x31f0 do_write_page+0x18d/0x710 f2fs_outplace_writ

Re: [f2fs-dev] [PATCH v2 7/7] f2fs: Reuse generic_ci_match for ci comparisons

2022-04-29 Thread kernel test robot
to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Gabriel-Krisman-Bertazi/Clean-up-the-case-insenstive-lookup-path/20220429-061233 base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git

[f2fs-dev] [PATCH 0/3] *** support compressed file write amplifiction accounting ***

2022-04-29 Thread Fengnan Chang via Linux-f2fs-devel
Optimise f2fs_write_cache_pages, and support compressed file write amplifiction accounting. Fengnan Chang (3): f2fs: intorduce f2fs_all_cluster_page_uptodate f2fs: use onstack pages instead of pvec f2fs: support compressed file write amplifiction accounting fs/f2fs/compress.c | 27

[f2fs-dev] [PATCH 3/3] f2fs: support compressed file write amplifiction accounting

2022-04-29 Thread Fengnan Chang via Linux-f2fs-devel
Try to support compressed file write amplifiction accounting. Signed-off-by: Fengnan Chang --- fs/f2fs/data.c | 14 ++ fs/f2fs/debug.c | 5 +++-- fs/f2fs/f2fs.h | 17 + 3 files changed, 30 insertions(+), 6 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c

[f2fs-dev] [PATCH 1/3] f2fs: intorduce f2fs_all_cluster_page_uptodate

2022-04-29 Thread Fengnan Chang via Linux-f2fs-devel
Intorduce f2fs_all_cluster_page_uptodate, try to reduce call f2fs_prepare_compress_overwrite. Signed-off-by: Fengnan Chang --- fs/f2fs/compress.c | 23 ++- fs/f2fs/data.c | 5 + fs/f2fs/f2fs.h | 2 ++ 3 files changed, 29 insertions(+), 1 deletion(-) diff --git