On Wed, May 18, 2022 at 11:23 PM Chao Yu wrote:
>
> On 2022/5/18 10:33, Chao Liu wrote:
> > In f2fs_read_inline_data(), it is confused with checking of
> > inline_data flag, as we checked it before calling. So this
> > patch add some comments for f2fs_has_inline_data().
> >
> > Signed-off-by: Chao
On Wed, May 18, 2022 at 09:40:43PM -0400, Gabriel Krisman Bertazi wrote:
> Instead of a bunch of ifdefs, make the unicode built checks part of the
> code flow where possible, as requested by Torvalds.
>
> Signed-off-by: Gabriel Krisman Bertazi
>
> ---
> Changes since v5:
> - Drop err variable
On Wed, May 18, 2022 at 09:40:41PM -0400, Gabriel Krisman Bertazi wrote:
> Now that ci_match is part of libfs, make f2fs reuse it instead of having
> a different implementation.
>
> Signed-off-by: Gabriel Krisman Bertazi
>
> ---
> Changes since v3:
> - Drop cast (eric)
> - fix unused variabl
On Wed, May 18, 2022 at 09:40:40PM -0400, Gabriel Krisman Bertazi wrote:
> Instead of reimplementing ext4_match_ci, use the new libfs helper.
>
> It should be fine to drop the fname->cf_name in the encrypted directory
> case for the hash verification optimization because the only two ways
> for fn
On Wed, May 18, 2022 at 09:40:39PM -0400, Gabriel Krisman Bertazi wrote:
> diff --git a/fs/libfs.c b/fs/libfs.c
> index 974125270a42..c8f40ee35743 100644
> --- a/fs/libfs.c
> +++ b/fs/libfs.c
> @@ -1465,6 +1465,74 @@ static const struct dentry_operations
> generic_ci_dentry_ops = {
> .d_hash
On Fri, May 13, 2022 at 04:16:02PM -0700, Eric Biggers wrote:
> From: Eric Biggers
>
> Make the test_dummy_encryption mount option require that the encrypt
> feature flag be already enabled on the filesystem, rather than
> automatically enabling it. Practically, this means that "-O encrypt"
> wi
On Fri, May 13, 2022 at 04:16:01PM -0700, Eric Biggers wrote:
> From: Eric Biggers
>
> If processing the on-disk mount options fails after any memory was
> allocated in the ext4_fs_context, e.g. s_qf_names, then this memory is
> leaked. Fix this by calling ext4_fc_free() instead of kfree() direc
Instead of a bunch of ifdefs, make the unicode built checks part of the
code flow where possible, as requested by Torvalds.
Reviewed-by: Eric Biggers
Signed-off-by: Gabriel Krisman Bertazi
---
Changes since v4:
- Drop stub removal for !CONFIG_UNICODE case (eric)
---
fs/f2fs/namei.c | 11
Instead of a bunch of ifdefs, make the unicode built checks part of the
code flow where possible, as requested by Torvalds.
Signed-off-by: Gabriel Krisman Bertazi
---
Changes since v5:
- Drop err variable (eric)
Changes since v4:
- Create stub for !CONFIG_UNICODE case (eric)
---
fs/ext4/ext
Now that ci_match is part of libfs, make f2fs reuse it instead of having
a different implementation.
Signed-off-by: Gabriel Krisman Bertazi
---
Changes since v3:
- Drop cast (eric)
- fix unused variable iff !CONFIG_UNICODE (lkp)
---
fs/f2fs/dir.c | 58 ---
If the volume is in strict mode, ext4_ci_compare can report a broken
encoding name. This will not trigger on a bad lookup, which is caught
earlier, only if the actual disk name is bad.
Reviewed-by: Eric Biggers
Signed-off-by: Gabriel Krisman Bertazi
---
changes since v4:
- Reword error mess
Instead of reimplementing ext4_match_ci, use the new libfs helper.
It should be fine to drop the fname->cf_name in the encrypted directory
case for the hash verification optimization because the only two ways
for fname->cf_name to be NULL on a case-insensitive lookup is
(1) if name under lookup
Keeping it as qstr avoids the unnecessary conversion in f2fs_match
Reviewed-by: Eric Biggers
Signed-off-by: Gabriel Krisman Bertazi
---
Changes since v4:
- Fix inconsistent return on error (eric)
---
fs/f2fs/dir.c | 51 ++
fs/f2fs/f2fs.h |
Hi Eric, Ted,
Sorry for the second submission of this series on the same day. Just a
batch of simple fixes, so I hope it is getting close to merging.
This is v6 of this series (thank you for the feedback!) . This picks up
a few r-b tags and apply the comments from Eric. No big changes, all
doc
Keeping it as qstr avoids the unnecessary conversion in ext4_match
Reviewed-by: Eric Biggers
Signed-off-by: Gabriel Krisman Bertazi
---
Changes since v1:
- Simplify hunk (eric)
---
fs/ext4/ext4.h | 2 +-
fs/ext4/namei.c | 23 +++
2 files changed, 12 insertions(+), 13 de
generic_ci_match can be used by case-insensitive filesystems to compare
strings under lookup with dirents in a case-insensitive way. This
function is currently reimplemented by each filesystem supporting
casefolding, so this reduces code duplication in filesystem-specific
code.
Signed-off-by: Gab
From: Eric Biggers
Currently, if an f2fs filesystem is mounted with the mode=lfs and
io_bits mount options, DIO reads are allowed but DIO writes are not.
Allowing DIO reads but not DIO writes is an unusual restriction, which
is likely to be surprising to applications, namely any application that
From: Eric Biggers
Traditionally, the conditions for when DIO (direct I/O) is supported
were fairly simple: filesystems either supported DIO aligned to the
block device's logical block size, or didn't support DIO at all.
However, due to filesystem features that have been added over time (e.g,
da
From: Eric Biggers
To prepare for STATX_IOALIGN support, make two changes to
fscrypt_dio_supported().
First, remove the filesystem-block-alignment check and make the
filesystems handle it instead. It previously made sense to have it in
fs/crypto/; however, to support STATX_IOALIGN the alignment
From: Eric Biggers
Add support for STATX_IOALIGN to ext4, so that I/O alignment information
is exposed to userspace in a consistent and easy-to-use way.
Signed-off-by: Eric Biggers
---
fs/ext4/ext4.h | 1 +
fs/ext4/file.c | 15 ---
fs/ext4/inode.c | 31 ++
From: Eric Biggers
f2fs only allows direct I/O that is aligned to the filesystem block
size. Given that fact, simplify f2fs_force_buffered_io() by removing
the redundant call to block_unaligned_IO().
This makes it easier to reuse this code for STATX_IOALIGN.
Signed-off-by: Eric Biggers
---
f
From: Eric Biggers
f2fs_force_buffered_io() is only used in file.c, so move it into there.
No behavior change. This makes it easier to review later patches.
Signed-off-by: Eric Biggers
---
fs/f2fs/f2fs.h | 45 -
fs/f2fs/file.c | 45 +
This patchset makes the statx() system call return I/O alignment
information, roughly following the design that was suggested at
https://lore.kernel.org/linux-fsdevel/20220120071215.123274-1-ebigg...@kernel.org/T/#u
This feature solves two problems: (a) it allows userspace to determine
when a file
From: Eric Biggers
Add support for STATX_IOALIGN to f2fs, so that I/O alignment information
is exposed to userspace in a consistent and easy-to-use way.
Signed-off-by: Eric Biggers
---
fs/f2fs/file.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/fs/f2fs/f
Eric Biggers writes:
> On Wed, May 18, 2022 at 01:23:16PM -0400, Gabriel Krisman Bertazi wrote:
>> Instead of reimplementing ext4_match_ci, use the new libfs helper.
>>
>> Signed-off-by: Gabriel Krisman Bertazi
>> ---
> [...]
>> int ext4_fname_setup_ci_filename(struct inode *dir, const struct
Please hold any test, since this patch has a bug.
On 05/18, Jaegeuk Kim wrote:
> Let's decompress data under the same context to avoid workqueue delay.
>
> Signed-off-by: Jaegeuk Kim
> ---
> fs/f2fs/data.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/data
On Wed, May 18, 2022 at 01:23:20PM -0400, Gabriel Krisman Bertazi wrote:
> Instead of a bunch of ifdefs, make the unicode built checks part of the
> code flow where possible, as requested by Torvalds.
>
> Signed-off-by: Gabriel Krisman Bertazi
>
> ---
> Changes since v4:
> - Drop stub removal
On Wed, May 18, 2022 at 01:23:19PM -0400, Gabriel Krisman Bertazi wrote:
> Instead of a bunch of ifdefs, make the unicode built checks part of the
> code flow where possible, as requested by Torvalds.
>
> Signed-off-by: Gabriel Krisman Bertazi
>
> ---
> Changes since v4:
> - Create stub for !C
On Wed, May 18, 2022 at 01:23:18PM -0400, Gabriel Krisman Bertazi wrote:
> If the volume is in strict mode, ext4_ci_compare can report a broken
> encoding name. This will not trigger on a bad lookup, which is caught
> earlier, only if the actual disk name is bad.
>
> Signed-off-by: Gabriel Krisma
On Wed, May 18, 2022 at 01:23:17PM -0400, Gabriel Krisman Bertazi wrote:
> @@ -277,8 +225,10 @@ static inline int f2fs_match_name(const struct inode
> *dir,
>
> #if IS_ENABLED(CONFIG_UNICODE)
> if (fname->cf_name.name)
> - return f2fs_match_ci_name(dir, &fname->cf_name,
> -
On Wed, May 18, 2022 at 01:23:16PM -0400, Gabriel Krisman Bertazi wrote:
> Instead of reimplementing ext4_match_ci, use the new libfs helper.
>
> Signed-off-by: Gabriel Krisman Bertazi
> ---
[...]
> int ext4_fname_setup_ci_filename(struct inode *dir, const struct qstr *iname,
>
On Wed, May 18, 2022 at 01:23:15PM -0400, Gabriel Krisman Bertazi wrote:
> generic_ci_match can be used by case-insensitive filesystems to compare
> strings under lookup with dirents in a case-insensitive way. This
> function is currently reimplemented by each filesystem supporting
> casefolding,
On Wed, May 18, 2022 at 01:23:14PM -0400, Gabriel Krisman Bertazi wrote:
> Keeping it as qstr avoids the unnecessary conversion in f2fs_match
>
> Signed-off-by: Gabriel Krisman Bertazi
>
Reviewed-by: Eric Biggers
- Eric
___
Linux-f2fs-devel mailin
On Wed, May 18, 2022 at 01:23:13PM -0400, Gabriel Krisman Bertazi wrote:
> Keeping it as qstr avoids the unnecessary conversion in ext4_match
>
> Signed-off-by: Gabriel Krisman Bertazi
>
> --
> Changes since v1:
> - Simplify hunk (eric)
> ---
The changelog needs to be deleted (or moved below
Let's decompress data under the same context to avoid workqueue delay.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/data.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 54a7a8ad994d..37aa7ac5d463 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/d
Instead of a bunch of ifdefs, make the unicode built checks part of the
code flow where possible, as requested by Torvalds.
Signed-off-by: Gabriel Krisman Bertazi
---
Changes since v4:
- Create stub for !CONFIG_UNICODE case (eric)
---
fs/ext4/ext4.h | 37 -
Instead of a bunch of ifdefs, make the unicode built checks part of the
code flow where possible, as requested by Torvalds.
Signed-off-by: Gabriel Krisman Bertazi
---
Changes since v4:
- Drop stub removal for !CONFIG_UNICODE case (eric)
---
fs/f2fs/namei.c | 11 +--
fs/f2fs/super.c |
If the volume is in strict mode, ext4_ci_compare can report a broken
encoding name. This will not trigger on a bad lookup, which is caught
earlier, only if the actual disk name is bad.
Signed-off-by: Gabriel Krisman Bertazi
---
changes since v4:
- Reword error message (Eric)
Changes since v
Keeping it as qstr avoids the unnecessary conversion in f2fs_match
Signed-off-by: Gabriel Krisman Bertazi
---
Changes since v4:
- Fix inconsistent return on error (eric)
---
fs/f2fs/dir.c | 51 ++
fs/f2fs/f2fs.h | 15 +-
fs/f2fs
Now that ci_match is part of libfs, make f2fs reuse it instead of having
a different implementation.
Signed-off-by: Gabriel Krisman Bertazi
---
Changes since v3:
- fix unused variable iff !CONFIG_UNICODE (lkp)
---
fs/f2fs/dir.c | 58 ---
1 file
Keeping it as qstr avoids the unnecessary conversion in ext4_match
Signed-off-by: Gabriel Krisman Bertazi
--
Changes since v1:
- Simplify hunk (eric)
---
fs/ext4/ext4.h | 2 +-
fs/ext4/namei.c | 23 +++
2 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/fs/
Instead of reimplementing ext4_match_ci, use the new libfs helper.
Signed-off-by: Gabriel Krisman Bertazi
---
fs/ext4/namei.c | 81 +++--
1 file changed, 17 insertions(+), 64 deletions(-)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 206fcf8fdc
generic_ci_match can be used by case-insensitive filesystems to compare
strings under lookup with dirents in a case-insensitive way. This
function is currently reimplemented by each filesystem supporting
casefolding, so this reduces code duplication in filesystem-specific
code.
Signed-off-by: Gab
Hi Eric, Ted,
This reworks the entire series to apply Eric's comments. Thank you for
the feedback, Eric!
The biggest change is the removal of unicode_name and the split of the
libfs patch. It made the series much better to follow. I also dropped
the hash patch, but there is still a minor clean
On 2022/5/18 10:33, Chao Liu wrote:
In f2fs_read_inline_data(), it is confused with checking of
inline_data flag, as we checked it before calling. So this
patch add some comments for f2fs_has_inline_data().
Signed-off-by: Chao Liu
It looks email address is missing, but it shows after I can app
On 2022/5/18 2:18, Jaegeuk Kim wrote:
On 05/17, Chao Yu wrote:
Yanming reported a kernel bug in Bugzilla kernel [1], which can be
reproduced. The bug message is:
The kernel message is shown below:
kernel BUG at fs/inode.c:611!
Call Trace:
evict+0x282/0x4e0
__dentry_kill+0x2b2/0x4d0
dput+
Yanming reported a kernel bug in Bugzilla kernel [1], which can be
reproduced. The bug message is:
The kernel message is shown below:
kernel BUG at fs/inode.c:611!
Call Trace:
evict+0x282/0x4e0
__dentry_kill+0x2b2/0x4d0
dput+0x2dd/0x720
do_renameat2+0x596/0x970
__x64_sys_rename+0x78/0x90
do
47 matches
Mail list logo
