Re: [f2fs-dev] [PATCH] f2fs: fix hungtask when decompressed fail

2022-06-07 Thread Chao Yu
On 2022/6/8 2:45, Jaegeuk Kim wrote: On 05/11, Fengnan Chang wrote: When decompressed failed, f2fs_prepare_compress_overwrite will enter endless loop, may casue hungtask. [ 14.088665] F2FS-fs (nvme0n1): lz4 decompress failed, ret:-4155 [ 14.089851] F2FS-fs (nvme0n1): lz4 decompress failed,

Re: [f2fs-dev] [PATCH 15/20] balloon: Convert to migrate_folio

2022-06-07 Thread Matthew Wilcox
On Tue, Jun 07, 2022 at 03:24:15PM +0100, Matthew Wilcox wrote: > On Tue, Jun 07, 2022 at 09:36:21AM +0200, David Hildenbrand wrote: > > On 06.06.22 22:40, Matthew Wilcox (Oracle) wrote: > > > const struct address_space_operations balloon_aops = { > > > - .migratepage = balloon_page_migrate, > >

Re: [f2fs-dev] [PATCH 07/20] nfs: Convert to migrate_folio

2022-06-07 Thread Anna Schumaker
On Mon, Jun 6, 2022 at 7:37 PM Matthew Wilcox (Oracle) wrote: > > Use a folio throughout this function. migrate_page() will be converted > later. > > Signed-off-by: Matthew Wilcox (Oracle) Looks fairly straightforward. Acked-by: Anna Schumaker > --- > fs/nfs/file.c | 4 +--- >

Re: [f2fs-dev] [PATCH] f2fs: fix hungtask when decompressed fail

2022-06-07 Thread Jaegeuk Kim
On 05/11, Fengnan Chang wrote: > When decompressed failed, f2fs_prepare_compress_overwrite will enter > endless loop, may casue hungtask. > > [ 14.088665] F2FS-fs (nvme0n1): lz4 decompress failed, ret:-4155 > [ 14.089851] F2FS-fs (nvme0n1): lz4 decompress failed, ret:-4155 > > Signed-off-by:

Re: [f2fs-dev] [PATCH 04/20] mm/migrate: Convert buffer_migrate_page() to buffer_migrate_folio()

2022-06-07 Thread Matthew Wilcox
On Tue, Jun 07, 2022 at 11:37:45AM +0800, kernel test robot wrote: > All warnings (new ones prefixed by >>): > > >> mm/migrate.c:775: warning: expecting prototype for > >> buffer_migrate_folio_noref(). Prototype was for > >> buffer_migrate_folio_norefs() instead No good deed (turning

Re: [f2fs-dev] [PATCH 14/20] hugetlb: Convert to migrate_folio

2022-06-07 Thread Matthew Wilcox
On Tue, Jun 07, 2022 at 02:13:26PM +0800, kernel test robot wrote: >fs/hugetlbfs/inode.c: In function 'hugetlbfs_migrate_folio': > >> fs/hugetlbfs/inode.c:990:17: error: implicit declaration of function > >> 'folio_migrate_copy' [-Werror=implicit-function-declaration] > 990 |

Re: [f2fs-dev] [PATCH 07/10] nilfs2: Convert nilfs_copy_back_pages() to use filemap_get_folios()

2022-06-07 Thread Ryusuke Konishi
On Mon, Jun 6, 2022 at 1:00 PM Matthew Wilcox (Oracle) wrote: > > Use folios throughout. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > fs/nilfs2/page.c | 60 > 1 file changed, 30 insertions(+), 30 deletions(-) Throughout, looks good to me.

Re: [f2fs-dev] [PATCH 15/20] balloon: Convert to migrate_folio

2022-06-07 Thread Matthew Wilcox
On Tue, Jun 07, 2022 at 09:36:21AM +0200, David Hildenbrand wrote: > On 06.06.22 22:40, Matthew Wilcox (Oracle) wrote: > > const struct address_space_operations balloon_aops = { > > - .migratepage = balloon_page_migrate, > > + .migrate_folio = balloon_migrate_folio, > > .isolate_page =

Re: [f2fs-dev] [PATCH 05/20] mm/migrate: Convert expected_page_refs() to folio_expected_refs()

2022-06-07 Thread Matthew Wilcox
On Tue, Jun 07, 2022 at 09:41:57AM -0400, Brian Foster wrote: > On Mon, Jun 06, 2022 at 09:40:35PM +0100, Matthew Wilcox (Oracle) wrote: > > -static int expected_page_refs(struct address_space *mapping, struct page > > *page) > > +static int folio_expected_refs(struct address_space *mapping, > >

Re: [f2fs-dev] [PATCH 05/20] mm/migrate: Convert expected_page_refs() to folio_expected_refs()

2022-06-07 Thread Brian Foster
On Mon, Jun 06, 2022 at 09:40:35PM +0100, Matthew Wilcox (Oracle) wrote: > Now that both callers have a folio, convert this function to > take a folio & rename it. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/migrate.c | 19 --- > 1 file changed, 12 insertions(+), 7

Re: [f2fs-dev] [PATCH 00/10] Convert to filemap_get_folios()

2022-06-07 Thread Christian Brauner
On Sun, Jun 05, 2022 at 08:38:44PM +0100, Matthew Wilcox wrote: > This patch series removes find_get_pages_range(), pagevec_lookup() > and pagevec_lookup_range(), converting all callers to use the new > filemap_get_folios(). I've only run xfstests over ext4 ... some other > testing might be

Re: [f2fs-dev] [PATCH 04/20] mm/migrate: Convert buffer_migrate_page() to buffer_migrate_folio()

2022-06-07 Thread kernel test robot
Hi "Matthew, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.19-rc1 next-20220607] [cannot apply to jaegeuk-f2fs/dev-test trondmy-nfs/linux-next kdave/for-next xfs-linux/for-next] [If your patch is applied to the

[f2fs-dev] [jaegeuk-f2fs:dev-test 2/2] fs/f2fs/file.c:3908:15: error: use of undeclared identifier 'sbi'

2022-06-07 Thread kernel test robot
/archive/20220607/202206071533.vc9l1css-...@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project b92436efcb7813fc481b30f2593a4907568d917a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O

Re: [f2fs-dev] [PATCH 15/20] balloon: Convert to migrate_folio

2022-06-07 Thread David Hildenbrand
On 06.06.22 22:40, Matthew Wilcox (Oracle) wrote: > This is little more than changing the types over; there's no real work > being done in this function. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/balloon_compaction.c | 15 +++ > 1 file changed, 7 insertions(+), 8

Re: [f2fs-dev] [PATCH 14/20] hugetlb: Convert to migrate_folio

2022-06-07 Thread kernel test robot
Hi "Matthew, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.19-rc1 next-20220607] [cannot apply to jaegeuk-f2fs/dev-test trondmy-nfs/linux-next kdave/for-next xfs-linux/for-next] [If your patch is applied to the wrong git