Re: [f2fs-dev] [PATCH v3 1/8] statx: add direct I/O alignment information

2022-06-23 Thread Eric Biggers
On Thu, Jun 23, 2022 at 10:23:20AM -0700, Eric Biggers wrote: > On Thu, Jun 23, 2022 at 08:58:12AM -0700, Darrick J. Wong wrote: > > > diff --git a/include/linux/stat.h b/include/linux/stat.h > > > index 7df06931f25d8..ff277ced50e9f 100644 > > > --- a/include/linux/stat.h > > > +++ b/include/linux/

Re: [f2fs-dev] [PATCH v2 1/5] Fix the struct f2fs_dentry_block definition

2022-06-23 Thread Peter Collingbourne via Linux-f2fs-devel
On Thu, Jun 23, 2022 at 11:12 AM Bart Van Assche wrote: > > Fix the struct f2fs_dentry_block definition on systems for which > PAGE_SIZE != 4096. This patch does not change the struct f2fs_dentry_block > definition if PAGE_SIZE == 4096. > > Cc: Peter Collingbourne > Reported-by: Peter Collingbour

[f2fs-dev] [PATCH v2 3/5] Improve compile-time type checking for f2fs_report_zone()

2022-06-23 Thread Bart Van Assche
Change the type of the third argument of f2fs_report_zone() from void * into struct blk_zone * to enable type checking. Signed-off-by: Bart Van Assche --- include/f2fs_fs.h | 4 +++- lib/libf2fs_zoned.c | 24 +++- 2 files changed, 18 insertions(+), 10 deletions(-) diff --

[f2fs-dev] [PATCH v2 1/5] Fix the struct f2fs_dentry_block definition

2022-06-23 Thread Bart Van Assche
Fix the struct f2fs_dentry_block definition on systems for which PAGE_SIZE != 4096. This patch does not change the struct f2fs_dentry_block definition if PAGE_SIZE == 4096. Cc: Peter Collingbourne Reported-by: Peter Collingbourne Signed-off-by: Bart Van Assche --- include/f2fs_fs.h | 4 ++-- 1

[f2fs-dev] [PATCH v2 4/5] Use F2FS_BLKSIZE for dev_read_block() buffers

2022-06-23 Thread Bart Van Assche
Use F2FS_BLKSIZE instead of PAGE_SIZE for dev_read_block() buffers since dev_read_block() reads F2FS_BLKSIZE bytes. Signed-off-by: Bart Van Assche --- fsck/mount.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fsck/mount.c b/fsck/mount.c index 108e1238493d..cc871fea5d

[f2fs-dev] [PATCH v2 0/5] PAGE_SIZE and zoned storage related improvements

2022-06-23 Thread Bart Van Assche
Hi Jaegeuk, This patch series fixes one issue reported by Peter Collingbourne and a few issues I discovered by reading the zoned block device source code. Please consider these patches for inclusion in the official f2fs-tools repository. Thanks, Bart. Bart Van Assche (5): Fix the struct f2fs_

[f2fs-dev] [PATCH v2 2/5] Fix f2fs_report_zone()

2022-06-23 Thread Bart Van Assche
The definition of struct blk_zone_report is as follows: struct blk_zone_report { __u64 sector; __u32 nr_zones; __u32 flags; struct blk_zone zones[0]; }; Since f2fs_report_zone() allocates

[f2fs-dev] [PATCH v2 5/5] Use F2FS_BLKSIZE as the size of struct f2fs_summary_block

2022-06-23 Thread Bart Van Assche
Since the size of struct f2fs_summary_block equals F2FS_BLKSIZE, use F2FS_BLKSIZE instead of PAGE_CACHE_SIZE as the size of struct f2fs_summary_block. Signed-off-by: Bart Van Assche --- fsck/mount.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fsck/mount.c b/fsck/m

Re: [f2fs-dev] [PATCH v3 1/8] statx: add direct I/O alignment information

2022-06-23 Thread Eric Biggers
On Thu, Jun 23, 2022 at 08:58:12AM -0700, Darrick J. Wong wrote: > > diff --git a/include/linux/stat.h b/include/linux/stat.h > > index 7df06931f25d8..ff277ced50e9f 100644 > > --- a/include/linux/stat.h > > +++ b/include/linux/stat.h > > @@ -50,6 +50,8 @@ struct kstat { > > struct timespec64 bt

Re: [f2fs-dev] [man-pages RFC PATCH] statx.2, open.2: document STATX_DIOALIGN

2022-06-23 Thread Eric Biggers
On Thu, Jun 23, 2022 at 10:27:19AM -0600, Andreas Dilger wrote: > On Jun 23, 2022, at 10:02 AM, Darrick J. Wong wrote: > > > > On Thu, Jun 16, 2022 at 01:21:41PM -0700, Eric Biggers wrote: > >> From: Eric Biggers > >> > >> @@ -244,8 +249,11 @@ STATX_SIZEWant stx_size > >> STATX_BLOCKS

Re: [f2fs-dev] [PATCH 6/7] ext4: Enable negative dentries on case-insensitive lookup

2022-06-23 Thread Gabriel Krisman Bertazi
t tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: > https://github.com/intel-lab-lkp/linux/commits/Gabriel-Krisman-Bertazi/Support-negative-dentries-on-case-insens

Re: [f2fs-dev] [man-pages RFC PATCH] statx.2, open.2: document STATX_DIOALIGN

2022-06-23 Thread Darrick J. Wong
On Thu, Jun 16, 2022 at 01:21:41PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Document the proposed STATX_DIOALIGN support for statx() > (https://lore.kernel.org/linux-fsdevel/20220616201506.124209-1-ebigg...@kernel.org). > > Signed-off-by: Eric Biggers > --- > man2/open.2 | 43 +

Re: [f2fs-dev] [PATCH v3 1/8] statx: add direct I/O alignment information

2022-06-23 Thread Darrick J. Wong
On Thu, Jun 16, 2022 at 01:14:59PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Traditionally, the conditions for when DIO (direct I/O) is supported > were fairly simple. For both block devices and regular files, DIO had > to be aligned to the logical block size of the block device. > >

Re: [f2fs-dev] [PATCH 7/7] f2fs: Enable negative dentries on case-insensitive lookup

2022-06-23 Thread kernel test robot
Hi Gabriel, I love your patch! Yet something to improve: [auto build test ERROR on tytso-ext4/dev] [also build test ERROR on jaegeuk-f2fs/dev-test linus/master v5.19-rc3 next-20220623] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [f2fs-dev] [PATCH 6/7] ext4: Enable negative dentries on case-insensitive lookup

2022-06-23 Thread kernel test robot
to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Gabriel-Krisman-Bertazi/Support-negative-dentries-on-case-insensitive-directories/20220623-034942 base: https://git.kernel.org/pub/scm/linux/kernel/git/