Re: [f2fs-dev] [PATCH RFC 5/7] fs/xfs: support `DISABLE_FS_CSUM_VERIFICATION` config option

2022-10-14 Thread Darrick J. Wong
On Fri, Oct 14, 2022 at 08:48:35AM +, Hrutvik Kanabar wrote: > From: Hrutvik Kanabar > > When `DISABLE_FS_CSUM_VERIFICATION` is enabled, return truthy value for > `xfs_verify_cksum`, which is the key function implementing checksum > verification for XFS. > > Signed-off-by: Hrutvik Kanabar

Re: [f2fs-dev] [PATCH 05/23] afs: Convert afs_writepages_region() to use filemap_get_folios_tag()

2022-10-14 Thread David Howells
Vishal Moola (Oracle) wrote: > Convert to use folios throughout. This function is in preparation to > remove find_get_pages_range_tag(). > > Also modified this function to write the whole batch one at a time, > rather than calling for a new set every single write. > > Signed-off-by: Vishal Mool

Re: [f2fs-dev] [PATCH RFC 3/7] fs/btrfs: support `DISABLE_FS_CSUM_VERIFICATION` config option

2022-10-14 Thread Qu Wenruo via Linux-f2fs-devel
On 2022/10/14 16:48, Hrutvik Kanabar wrote: From: Hrutvik Kanabar When `DISABLE_FS_CSUM_VERIFICATION` is enabled, bypass checksum verification. Signed-off-by: Hrutvik Kanabar I always want more fuzz for btrfs, so overall this is pretty good. But there are some comments related to free s

Re: [f2fs-dev] [PATCH RFC 0/7] fs: Debug config option to disable filesystem checksum verification for fuzzing

2022-10-14 Thread David Sterba
On Fri, Oct 14, 2022 at 08:48:30AM +, Hrutvik Kanabar wrote: > From: Hrutvik Kanabar > > Fuzzing is a proven technique to discover exploitable bugs in the Linux > kernel. But fuzzing filesystems is tricky: highly structured disk images > use redundant checksums to verify data integrity. There

[f2fs-dev] [PATCH RFC 4/7] fs/exfat: support `DISABLE_FS_CSUM_VERIFICATION` config option

2022-10-14 Thread Hrutvik Kanabar
From: Hrutvik Kanabar When `DISABLE_FS_CSUM_VERIFICATION` is enabled, bypass checksum verification. Signed-off-by: Hrutvik Kanabar --- fs/exfat/nls.c | 3 ++- fs/exfat/super.c | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/exfat/nls.c b/fs/exfat/nls.c index 705710f

[f2fs-dev] [PATCH RFC 5/7] fs/xfs: support `DISABLE_FS_CSUM_VERIFICATION` config option

2022-10-14 Thread Hrutvik Kanabar
From: Hrutvik Kanabar When `DISABLE_FS_CSUM_VERIFICATION` is enabled, return truthy value for `xfs_verify_cksum`, which is the key function implementing checksum verification for XFS. Signed-off-by: Hrutvik Kanabar --- fs/xfs/libxfs/xfs_cksum.h | 5 - 1 file changed, 4 insertions(+), 1 del

[f2fs-dev] [PATCH RFC 3/7] fs/btrfs: support `DISABLE_FS_CSUM_VERIFICATION` config option

2022-10-14 Thread Hrutvik Kanabar
From: Hrutvik Kanabar When `DISABLE_FS_CSUM_VERIFICATION` is enabled, bypass checksum verification. Signed-off-by: Hrutvik Kanabar --- fs/btrfs/check-integrity.c | 3 ++- fs/btrfs/disk-io.c | 6 -- fs/btrfs/free-space-cache.c | 3 ++- fs/btrfs/inode.c| 3 ++- fs/btrfs

[f2fs-dev] [PATCH RFC 2/7] fs/ext4: support `DISABLE_FS_CSUM_VERIFICATION` config option

2022-10-14 Thread Hrutvik Kanabar
From: Hrutvik Kanabar When `DISABLE_FS_CSUM_VERIFICATION` is enabled, bypass checks in key checksum verification functions. Signed-off-by: Hrutvik Kanabar --- fs/ext4/bitmap.c | 6 -- fs/ext4/extents.c | 3 ++- fs/ext4/inode.c | 3 ++- fs/ext4/ioctl.c | 3 ++- fs/ext4/mmp.c | 3 ++

[f2fs-dev] [PATCH RFC 7/7] fs/f2fs: support `DISABLE_FS_CSUM_VERIFICATION` config option

2022-10-14 Thread Hrutvik Kanabar
From: Hrutvik Kanabar When `DISABLE_FS_CSUM_VERIFICATION` is enabled, bypass checksum verification. Signed-off-by: Hrutvik Kanabar --- fs/f2fs/checkpoint.c | 3 ++- fs/f2fs/compress.c | 3 ++- fs/f2fs/f2fs.h | 2 ++ fs/f2fs/inode.c | 3 +++ 4 files changed, 9 insertions(+), 2 dele

[f2fs-dev] [PATCH RFC 6/7] fs/ntfs: support `DISABLE_FS_CSUM_VERIFICATION` config option

2022-10-14 Thread Hrutvik Kanabar
From: Hrutvik Kanabar When `DISABLE_FS_CSUM_VERIFICATION` is enabled, bypass checksum verification in `is_boot_sector_ntfs`. Signed-off-by: Hrutvik Kanabar --- fs/ntfs/super.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c index 001f4e05

[f2fs-dev] [PATCH RFC 1/7] fs: create `DISABLE_FS_CSUM_VERIFICATION` config option

2022-10-14 Thread Hrutvik Kanabar
From: Hrutvik Kanabar When implemented and enabled, this should circumvent all redundant checksum verification in filesystem code. However, setting of checksums is not affected. The aim is to aid fuzzing efforts which randomly mutate disk images and so invalidate checksums. Checksum verificatio

[f2fs-dev] [PATCH RFC 0/7] fs: Debug config option to disable filesystem checksum verification for fuzzing

2022-10-14 Thread Hrutvik Kanabar
From: Hrutvik Kanabar Fuzzing is a proven technique to discover exploitable bugs in the Linux kernel. But fuzzing filesystems is tricky: highly structured disk images use redundant checksums to verify data integrity. Therefore, randomly-mutated images are quickly rejected as corrupt, testing only

Re: [f2fs-dev] [PATCH v2] f2fs: fix hungtask when decompressed fail

2022-10-14 Thread fengnan chang
ping, it seems this had been forgotten. > 2022年6月8日 21:48,Fengnan Chang 写道: > > When decompressed failed, f2fs_prepare_compress_overwrite will enter > endless loop, may casue hungtask. > > [ 14.088665] F2FS-fs (nvme0n1): lz4 decompress failed, ret:-4155 > [ 14.089851] F2FS-fs (nvme0n1): lz