On 2022/10/26 1:46, Jaegeuk Kim wrote:
On 10/25, Chao Yu wrote:
On 2022/10/25 7:36, Jaegeuk Kim wrote:
The below commit disallows to set compression on empty created file which
has a inline_data. Let's fix it.
Fixes: 7165841d578e ("f2fs: fix to check inline_data during compressed inode
conver
On 10/25, Chao Yu wrote:
> On 2022/10/25 7:36, Jaegeuk Kim wrote:
> > The below commit disallows to set compression on empty created file which
> > has a inline_data. Let's fix it.
> >
> > Fixes: 7165841d578e ("f2fs: fix to check inline_data during compressed
> > inode conversion")
> > Signed-off
On Tue, Oct 25, 2022 at 03:15:49PM +0800, Yang Yingliang wrote:
> Inject fault while loading module, kset_register() may fail.
> If it fails, the kset.kobj.name allocated by kobject_set_name()
> which must be called before a call to kset_register() may be
> leaked, since refcount of kobj was set in
On 2022-10-25 03:15, Yang Yingliang wrote:
> Inject fault while loading module, kset_register() may fail.
> If it fails, the kset.kobj.name allocated by kobject_set_name()
> which must be called before a call to kset_register() may be
> leaked, since refcount of kobj was set in kset_init().
Techni
This patch adds a new proc entry to show discard_plist
information in more detail, which is very helpful to
know the discard pend list count clearly.
Such as:
Discard pend list(Show diacrd_cmd count on each entry, .:not exist):
0 390 156 85 67 46 37 26 14
On 2022/10/25 16:05, Yangtao Li wrote:
Just cleanup for readable, no functional changes.
Suggested-by: Chao Yu
Signed-off-by: Yangtao Li
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https
On 2022/10/25 17:40, zhangdongdong wrote:
From: Dongdong Zhang
In the DPOLICY_BG mode, there is a conflict between
the two conditions "i + 1 < dpolicy->granularity" and
"i < DEFAULT_DISCARD_GRANULARITY". If i = 15, the first
condition is false, it will enter the second condition
and dispatch al
From: Dongdong Zhang
In the DPOLICY_BG mode, there is a conflict between
the two conditions "i + 1 < dpolicy->granularity" and
"i < DEFAULT_DISCARD_GRANULARITY". If i = 15, the first
condition is false, it will enter the second condition
and dispatch all small granularity discards in function
__
The current max_ordered_discard is a fixed value, change it to be
configurable through the sys node.
Signed-off-by: Yangtao Li
Reviewed-by: Chao Yu
---
Documentation/ABI/testing/sysfs-fs-f2fs | 6 ++
fs/f2fs/f2fs.h | 3 +++
fs/f2fs/segment.c
Just cleanup for readable, no functional changes.
Suggested-by: Chao Yu
Signed-off-by: Yangtao Li
---
v3:
-avoid UAF
fs/f2fs/segment.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index acf3d3fa4363..84a17607dfee 100644
--- a/
On 2022/10/25 15:56, Yangtao Li wrote:
Remove the local 'err' variable for readable,
no functional changes.
Signed-off-by: Yangtao Li
---
fs/f2fs/segment.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index acf3d3fa4363.
Remove the local 'err' variable for readable,
no functional changes.
Signed-off-by: Yangtao Li
---
fs/f2fs/segment.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index acf3d3fa4363..ed247195a20c 100644
--- a/fs/f2fs/segment.
On 2022/10/25 15:36, zhangqilong wrote:
On 2022/10/25 15:01, zhangqilong wrote:
On 2022/10/25 14:27, zhangqilong wrote:
On 2022/10/20 15:27, zhangqilong via Linux-f2fs-devel wrote:
On 2022/10/18 10:45, Zhang Qilong wrote:
In the following case:
process 1 process 2
On 2022/10/25 15:35, Yangtao Li wrote:
The current max_ordered_discard is a fixed value,
change it to be configurable through the sys node.
Signed-off-by: Yangtao Li
---
v2:
- s/order/ordered
Documentation/ABI/testing/sysfs-fs-f2fs | 6 ++
fs/f2fs/f2fs.h | 3 ++
> On 2022/10/25 15:01, zhangqilong wrote:
> >> On 2022/10/25 14:27, zhangqilong wrote:
> On 2022/10/20 15:27, zhangqilong via Linux-f2fs-devel wrote:
> >> On 2022/10/18 10:45, Zhang Qilong wrote:
> >>> In the following case:
> >>> process 1 process 2
> >>>
The current max_ordered_discard is a fixed value,
change it to be configurable through the sys node.
Signed-off-by: Yangtao Li
---
v2:
- s/order/ordered
Documentation/ABI/testing/sysfs-fs-f2fs | 6 ++
fs/f2fs/f2fs.h | 3 +++
fs/f2fs/segment.c
On 2022/10/25 14:50, Yangtao Li wrote:
Under the current logic, when gc_urgent_high_remaining is set to 1,
the mode will be switched to normal at the beginning, instead of
running in gc_urgent mode.
Let's switch the gc mode back to normal when the gc ends.
Fixes: 265576181b4a ("f2fs: remove gc_
On 2022/10/25 15:08, Yangtao Li wrote:
Hi Chao,
In my point of view, it should not return 0. Because calling kthread_run()
to create a kernel thread may fails, and err is assigned a value.
I commented on last 'return err' rather than the one in error path...
Maybe:
---
fs/f2fs/segment.c | 8
On 2022/10/25 15:01, zhangqilong wrote:
On 2022/10/25 14:27, zhangqilong wrote:
On 2022/10/20 15:27, zhangqilong via Linux-f2fs-devel wrote:
On 2022/10/18 10:45, Zhang Qilong wrote:
In the following case:
process 1 process 2
->open A
->mmap
->read # the
Inject fault while loading module, kset_register() may fail.
If it fails, the kset.kobj.name allocated by kobject_set_name()
which must be called before a call to kset_register() may be
leaked, since refcount of kobj was set in kset_init().
To mitigate this, we free the name in kset_register() whe
Hi Chao,
In my point of view, it should not return 0. Because calling kthread_run()
to create a kernel thread may fails, and err is assigned a value.
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.source
On 2022/10/21 18:28, Yangtao Li wrote:
The current max_order_discard is a fixed value,
max_ordered_discard?
change it to be configurable through the sys node.
Signed-off-by: Yangtao Li
---
Documentation/ABI/testing/sysfs-fs-f2fs | 6 ++
fs/f2fs/f2fs.h | 3 +
> On 2022/10/25 14:27, zhangqilong wrote:
> >> On 2022/10/20 15:27, zhangqilong via Linux-f2fs-devel wrote:
> On 2022/10/18 10:45, Zhang Qilong wrote:
> > In the following case:
> > process 1 process 2
> > ->open A
> > ->mmap
> > ->read
On 2022/10/24 21:59, Yangtao Li wrote:
Replace
if (A) {
..
return err;
}
return err;
with
if (A) {
..
}
return err;
Signed-off-by: Yangtao Li
---
fs/f2fs/segment.c | 1 -
1 file changed, 1
24 matches
Mail list logo
