Re: [f2fs-dev] a fix and a bunch of cleanups

2023-01-10 Thread Christoph Hellwig
On Tue, Jan 03, 2023 at 09:21:37AM -0800, Jaegeuk Kim wrote: > Hi Christoph, > > I applied the patch set with minor modification to address merge conflict. > Could you please take a look? >From a quick look this looks good. I have a nother big batch of patches that I'll rebase, and as part of th

Re: [f2fs-dev] [PATCH] f2fs: don't set FI_COMPRESS_RELEASED if file is not compressed

2023-01-10 Thread zhou dan
On Android S, after the app is installed, it will judge whether the file is allowed to be compressed and release it. In the case of compress_mode=user, the file is not compressed at this point, causing EVNAL to be returned on subsequent executions to release. In the method 'isCompressionAllowed', t

Re: [f2fs-dev] [PATCH v2] f2fs: retry to update the inode page given EIO

2023-01-10 Thread Jaegeuk Kim
In f2fs_update_inode_page, f2fs_get_node_page handles EIO along with f2fs_handle_page_eio that stops checkpoint, if the disk couldn't be recovered. As a result, we don't need to stop checkpoint right away given single EIO. Cc: sta...@vger.kernel.org Signed-off-by: Randall Huang Signed-off-by: Jae

Re: [f2fs-dev] [PATCH 2/5] fs: affs: initialize fsdata in affs_truncate()

2023-01-10 Thread Eric Biggers
On Tue, Jan 10, 2023 at 01:27:03PM +0100, Alexander Potapenko wrote: > On Tue, Nov 22, 2022 at 3:56 PM David Sterba wrote: > > > > On Mon, Nov 21, 2022 at 12:21:31PM +0100, Alexander Potapenko wrote: > > > When aops->write_begin() does not initialize fsdata, KMSAN may report > > > an error passing

Re: [f2fs-dev] [PATCH 2/5] fs: affs: initialize fsdata in affs_truncate()

2023-01-10 Thread David Sterba
On Tue, Jan 10, 2023 at 01:27:03PM +0100, Alexander Potapenko wrote: > On Tue, Nov 22, 2022 at 3:56 PM David Sterba wrote: > > > > On Mon, Nov 21, 2022 at 12:21:31PM +0100, Alexander Potapenko wrote: > > > When aops->write_begin() does not initialize fsdata, KMSAN may report > > > an error passing

Re: [f2fs-dev] [PATCH 2/5] fs: affs: initialize fsdata in affs_truncate()

2023-01-10 Thread Alexander Potapenko via Linux-f2fs-devel
On Tue, Nov 22, 2022 at 3:56 PM David Sterba wrote: > > On Mon, Nov 21, 2022 at 12:21:31PM +0100, Alexander Potapenko wrote: > > When aops->write_begin() does not initialize fsdata, KMSAN may report > > an error passing the latter to aops->write_end(). > > > > Fix this by unconditionally initializ