Hi Yangtao,
I love your patch! Perhaps something to improve:
[auto build test WARNING on jaegeuk-f2fs/dev-test]
[also build test WARNING on jaegeuk-f2fs/dev linus/master v6.3-rc3
next-20230320]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we
When f2fs tries to checkpoint during foreground gc in LFS mode, system
crash occurs due to lack of free space if the amount of dirty node and
dentry pages generated by data migration exceeds free space.
The reproduction sequence is as follows.
- 20GiB capacity block device (null_blk)
- format
On 3/21/23 03:46, Yangtao Li wrote:
> There are plenty of using kobject_del() and kobject_put() together
> in the kernel tree. This patch wraps these two calls in a single helper.
>
> Signed-off-by: Yangtao Li
> ---
> v2:
> -add kobject_del_and_put() users
> resend patchset to gregkh, Rafael and
Use kobject_del_and_put() to simplify code.
Cc: Greg Kroah-Hartman
Cc: "Rafael J. Wysocki"
Cc: Damien Le Moal
Signed-off-by: Yangtao Li
---
fs/f2fs/sysfs.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
index
There are plenty of using kobject_del() and kobject_put() together
in the kernel tree. This patch wraps these two calls in a single helper.
Signed-off-by: Yangtao Li
---
v2:
-add kobject_del_and_put() users
resend patchset to gregkh, Rafael and Damien
include/linux/kobject.h | 1 +
In this patch, it adds to account discard latency.
Signed-off-by: Yangtao Li
---
v2:
-rename get_bio_iostat_private to iostat_get_bio_private
fs/f2fs/data.c | 2 +-
fs/f2fs/f2fs.h | 1 +
fs/f2fs/iostat.c| 83 +
As Christoph Hellwig point out:
Please avoid the else by doing the goto in the branch.
Signed-off-by: Yangtao Li
---
fs/f2fs/data.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index bf51e6e4eb64..fa931fb768e7 100644
---
BUG_ON() will be triggered when writing files concurrently,
because the same page is writtenback multiple times.
1597 void folio_end_writeback(struct folio *folio)
1598 {
..
1618 if (!__folio_end_writeback(folio))
1619 BUG();
..
1625 }
kernel
On Thu, Mar 16, 2023 at 05:36:32PM +0800, Yangtao Li wrote:
> + if (PageWriteback(cc->rpages[i])) {
> + if (wbc->sync_mode != WB_SYNC_NONE)
> + f2fs_wait_on_page_writeback(cc->rpages[i],
> +
On Mon, Feb 20, 2023 at 01:20:04PM +0100, Hans Holmberg wrote:
> A) Supporting proper direct writes for zoned block devices would
> be the best, but it is currently not supported (probably for
> a good but non-obvious reason). Would it be feasible to
> implement proper direct IO?
I don't think
On 3/20/23 16:11, Yangtao Li wrote:
> Hi filesystem maintainers,
>
>> Hard to comment on patches with this. It is only 10 patches. So send
>> everything please.
>
> If you are interested in the entire patchset besides Damien,
> please let me know. I'll resend the email later to cc more people.
Hi filesystem maintainers,
> Hard to comment on patches with this. It is only 10 patches. So send
> everything please.
If you are interested in the entire patchset besides Damien,
please let me know. I'll resend the email later to cc more people.
Thx,
Yangtao
12 matches
Mail list logo
