[f2fs-dev] [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree

2023-04-17 Thread Qi Han via Linux-f2fs-devel
This comment make no sense and is in the wrong place, so let's remove it. Signed-off-by: Qi Han --- fs/f2fs/extent_cache.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c index 28b12553f2b3..1f6d7de35794 100644 --- a/fs/f2fs/extent_cache.c +++ b

Re: [f2fs-dev] [PATCH] f2fs: remove some dead code

2023-04-17 Thread Dan Carpenter
On Mon, Apr 17, 2023 at 10:51:46PM +0200, Christophe JAILLET wrote: > > - ret2 = filemap_check_errors(NODE_MAPPING(sbi)); > - if (!ret) > - ret = ret2; > + ret = filemap_check_errors(NODE_MAPPING(sbi)); > > return ret; Let's get rid of "ret" as well: retu

Re: [f2fs-dev] [PATCH v2] docs: f2fs: specify extent cache for read explicitly

2023-04-17 Thread Bagas Sanjaya
On 4/17/23 11:41, Yangtao Li wrote: > Let's descrbie it's read extent cache. "Clarify the fact that extent_cache and noextent_cache toggle read extent cache on or off." > -extent_cache Enable an extent cache based on rb-tree, it can cache > - as many as extent which

Re: [f2fs-dev] (2) [PATCH] f2fs_io: support checkpoint command

2023-04-17 Thread Yonggil Song
On 04/17, Yonggil Song wrote: >> >Fixed a xfstests failure. >> > >> >From 400c722c2117660b83190c88e5442d63fbbffe6e Mon Sep 17 00:00:00 2001 >> >From: Jaegeuk Kim >> >Date: Mon, 10 Apr 2023 14:48:50 -0700 >> >Subject: [PATCH] f2fs: refactor f2fs_gc to call checkpoint in urgent >> >condition >> > >

[f2fs-dev] [PATCH] f2fs: remove power-of-two limitation fo zoned device

2023-04-17 Thread Jaegeuk Kim
In f2fs, there's no reason to force po2. Signed-off-by: Jaegeuk Kim --- fs/f2fs/f2fs.h| 3 +-- fs/f2fs/gc.c | 2 +- fs/f2fs/segment.c | 2 +- fs/f2fs/super.c | 7 +-- 4 files changed, 4 insertions(+), 10 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 6cae94d51821

[f2fs-dev] Patchwork summary for: f2fs

2023-04-17 Thread patchwork-bot+f2fs
Hello: The following patches were marked "accepted", because they were applied to jaegeuk/f2fs.git (dev): Patch: [f2fs-dev] f2fs: remove bulk remove_proc_entry() and unnecessary kobject_del() Submitter: Yangtao Li Committer: Jaegeuk Kim Patchwork: https://patchwork.kernel.org/project/f2f

Re: [f2fs-dev] [PATCH] f2fs: remove bulk remove_proc_entry() and unnecessary kobject_del()

2023-04-17 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Fri, 7 Apr 2023 03:16:29 +0800 you wrote: > Convert to use remove_proc_subtree() and kill kobject_del() directly. > kobject_put() actually covers kobject removal automatically, which is > single stage removal. > > Signe

Re: [f2fs-dev] [PATCH] f2fs_io: support checkpoint command

2023-04-17 Thread Jaegeuk Kim
On 04/17, Yonggil Song wrote: > >Fixed a xfstests failure. > > > >From 400c722c2117660b83190c88e5442d63fbbffe6e Mon Sep 17 00:00:00 2001 > >From: Jaegeuk Kim > >Date: Mon, 10 Apr 2023 14:48:50 -0700 > >Subject: [PATCH] f2fs: refactor f2fs_gc to call checkpoint in urgent > >condition > > > >The ma

[f2fs-dev] [PATCH] f2fs: remove some dead code

2023-04-17 Thread Christophe JAILLET
'ret' is known to be 0 at the point. So these lines of code should just be removed. Signed-off-by: Christophe JAILLET --- The dead code became after commit 8358014d6be8 ("f2fs: avoid to check PG_error flag") --- fs/f2fs/node.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-)