Re: [f2fs-dev] [DISCUSSION] f2fs for desktop

2023-05-18 Thread Juhyung Park
Hi Chao, Thanks for the patch. I'll try it out on both my laptop and workstation soon. One question though: would it make sense to see if it works fine on Android too? (With userspace's explicit GC trigger disabled.) Maybe it could be an indication on whether it works properly or not? Thanks,

Re: [f2fs-dev] [PATCH 1/1] f2fs: pass I_NEW flag to trace event

2023-05-18 Thread Wu Bo
On 2023/5/18 08:32, Jaegeuk Kim wrote: On 05/17, Wu Bo wrote: On 2023/5/17 16:36, Chao Yu wrote: On 2023/5/17 11:59, Wu Bo wrote: On 2023/5/17 10:44, Chao Yu wrote: On 2023/5/16 20:07, Wu Bo wrote: Modify the order between 'trace_f2fs_iget' & 'unlock_new_inode', so the I_NEW can pass to the

Re: [f2fs-dev] [PATCH v5] fsck.f2fs: Detect and fix looped node chain efficiently

2023-05-18 Thread Chao Yu
On 2023/5/18 20:26, Chunhai Guo wrote: find_fsync_inode() detect the looped node chain by comparing the loop counter with free blocks. While it may take tens of seconds to quit when the free blocks are large enough. We can use Floyd's cycle detection algorithm to make the detection more

[f2fs-dev] [PATCH v5] fsck.f2fs: Detect and fix looped node chain efficiently

2023-05-18 Thread Chunhai Guo via Linux-f2fs-devel
find_fsync_inode() detect the looped node chain by comparing the loop counter with free blocks. While it may take tens of seconds to quit when the free blocks are large enough. We can use Floyd's cycle detection algorithm to make the detection more efficient, and fix the issue by filling a NULL

[f2fs-dev] [PATCH] f2fs: fix to use le32_to_cpu() in RAW_IS_INODE()

2023-05-18 Thread Chao Yu
__le32 type variable should be converted w/ le32_to_cpu() before access. Signed-off-by: Chao Yu --- fs/f2fs/f2fs.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 7f6c51a6b930..a4bff3b5b887 100644 --- a/fs/f2fs/f2fs.h +++

[f2fs-dev] [PATCH] fsck.f2fs: fix to use le32_to_cpu() in IS_INODE()

2023-05-18 Thread Chao Yu
And use IS_INODE() to clean up codes. Signed-off-by: Chao Yu --- fsck/fsck.c | 7 +++ fsck/mount.c | 4 ++-- fsck/node.h | 3 ++- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/fsck/fsck.c b/fsck/fsck.c index d03f1da..ac4cd98 100644 --- a/fsck/fsck.c +++ b/fsck/fsck.c @@

Re: [f2fs-dev] [PATCH v4] fsck.f2fs: Detect and fix looped node chain efficiently

2023-05-18 Thread Chao Yu
On 2023/5/18 17:10, Chao Yu wrote: On 2023/5/18 12:11, Chunhai Guo wrote: find_fsync_inode() detect the looped node chain by comparing the loop counter with free blocks. While it may take tens of seconds to quit when the free blocks are large enough. We can use Floyd's cycle detection algorithm

Re: [f2fs-dev] [PATCH v4] fsck.f2fs: Detect and fix looped node chain efficiently

2023-05-18 Thread Chao Yu
On 2023/5/18 12:11, Chunhai Guo wrote: find_fsync_inode() detect the looped node chain by comparing the loop counter with free blocks. While it may take tens of seconds to quit when the free blocks are large enough. We can use Floyd's cycle detection algorithm to make the detection more

[f2fs-dev] [PATCH v2] f2fs: support background_gc=adjust mount option

2023-05-18 Thread Chao Yu
As JuHyung reported in [1]: "In most consumer-grade blackbox SSDs, device-side GCs are handled automatically for various workloads. f2fs, however, leaves that responsibility to the userspace with conservative tuning on the kernel-side by default. Android handles this by init.rc tunings and a

Re: [f2fs-dev] [DISCUSSION] f2fs for desktop

2023-05-18 Thread Chao Yu
On 2023/4/21 1:26, Juhyung Park wrote: Hi Chao, On Fri, Apr 21, 2023 at 1:19 AM Chao Yu wrote: Hi JuHyung, Sorry for delay reply. On 2023/4/11 1:03, Juhyung Park wrote: Hi Chao, On Tue, Apr 11, 2023 at 12:44 AM Chao Yu wrote: Hi Juhyung, On 2023/4/4 15:36, Juhyung Park wrote: Hi

[f2fs-dev] [PATCH] f2fs: support background_gc=adjust mount option

2023-05-18 Thread Chao Yu
As JuHyung reported in [1]: "In most consumer-grade blackbox SSDs, device-side GCs are handled automatically for various workloads. f2fs, however, leaves that responsibility to the userspace with conservative tuning on the kernel-side by default. Android handles this by init.rc tunings and a