Re: [f2fs-dev] Kernel warnings 6.3.1

2023-05-24 Thread Richard Tresidder via Linux-f2fs-devel
On 18/05/2023 9:08 am, Jaegeuk Kim wrote: Hi, Could you please consider v6.3.3 which has some fixes? Thanks, Hi Kim Sorry about the slow reply. Had to get a UART issue out of the way before I could test this at 6.3.3 Indeed things seem to be ok again. So can close this issue. Cheers

Re: [f2fs-dev] [PATCH v8] fsck.f2fs: Detect and fix looped node chain efficiently

2023-05-24 Thread Chao Yu
On 2023/5/24 10:42, Chunhai Guo wrote: find_fsync_inode() detect the looped node chain by comparing the loop counter with free blocks. While it may take tens of seconds to quit when the free blocks are large enough. We can use Floyd's cycle detection algorithm to make the detection more efficient

Re: [f2fs-dev] [PATCH 3/4] mkfs.f2fs: cleanup w/ alloc_next_free_block()

2023-05-24 Thread Chao Yu
On 2023/5/24 9:40, Jaegeuk Kim wrote: On 05/18, Chao Yu wrote: On 2023/5/18 9:36, Jaegeuk Kim wrote: On 05/17, Chao Yu wrote: Introduce alloc_next_free_block() to wrap below openned codes: blkaddr = get_sb(main_blkaddr) + c.cur_seg[curseg_type] * c.blks_per_seg

Re: [f2fs-dev] [PATCH v6] f2fs: add async reset zone command support

2023-05-24 Thread Chao Yu
On 2023/5/10 2:53, Jaegeuk Kim wrote: On 05/08, Daejun Park wrote: v5 -> v6 Added trace_f2fs_iostat support for zone reset command. v4 -> v5 Added f2fs iostat for zone reset command. v3 -> v4 Fixed build error caused by unused function. v2 -> v3 Modified arguments to be correct for ftrace par

Re: [f2fs-dev] [PATCH 14/17] block: open code __generic_file_write_iter for blkdev writes

2023-05-24 Thread Luis Chamberlain
On Mon, Apr 24, 2023 at 07:49:23AM +0200, Christoph Hellwig wrote: > Open code __generic_file_write_iter to remove the indirect call into > ->direct_IO and to prepare using the iomap based write code. > > Signed-off-by: Christoph Hellwig > --- > block/fops.c | 46

Re: [f2fs-dev] [PATCH 01/11] backing_dev: remove current->backing_dev_info

2023-05-24 Thread Darrick J. Wong
On Wed, May 24, 2023 at 08:38:00AM +0200, Christoph Hellwig wrote: > The last user of current->backing_dev_info disappeared in commit > b9b1335e6403 ("remove bdi_congested() and wb_congested() and related > functions"). Remove the field and all assignments to it. > > Signed-off-by: Christoph Hell

Re: [f2fs-dev] [PATCH 16/17] block: use iomap for writes to block devices

2023-05-24 Thread Matthew Wilcox
On Wed, May 24, 2023 at 08:27:13AM +1000, Dave Chinner wrote: > On Fri, May 19, 2023 at 04:22:01PM +0200, Hannes Reinecke wrote: > > I'm hitting this during booting: > > [5.016324] > > [5.030256] iomap_iter+0x11a/0x350 > > [5.030264] iomap_readahead+0x1eb/0x2c0 > > [5.030272] r

[f2fs-dev] [PATCH] f2fs: allows setting compress option to files which marked with FI_MMAP_FILE

2023-05-24 Thread Qi Han via Linux-f2fs-devel
Allow to compress mmap files in commit e3c548323d32 ("f2fs: let's allow compression for mmap files"). However, we cannot set the compress option to the mmap file. To keep the same concept in both compress_modes, f2fs_ioc_set_compress_option should also allow it. Let's remove checking mmap files in

[f2fs-dev] [PATCH 1/1] f2fs: fix args passed to trace_f2fs_lookup_end

2023-05-24 Thread Wu Bo via Linux-f2fs-devel
The NULL return of 'd_splice_alias' dosen't mean error. Signed-off-by: Wu Bo --- fs/f2fs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index 77a71276ecb1..e5a3e39ce90c 100644 --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -577,7 +57

[f2fs-dev] [PATCH] f2fs: Detect and fix looped node chain efficiently

2023-05-24 Thread Chunhai Guo via Linux-f2fs-devel
find_fsync_dnodes() detect the looped node chain by comparing the loop counter with free blocks. While it may take tens of seconds to quit when the free blocks are large enough. We can use Floyd's cycle detection algorithm to make the detection more efficient, and fix the issue by filling a NULL ad

Re: [f2fs-dev] [PATCH 11/11] fuse: drop redundant arguments to fuse_perform_write

2023-05-24 Thread Miklos Szeredi via Linux-f2fs-devel
On Wed, 24 May 2023 at 08:38, Christoph Hellwig wrote: > > pos is always equal to iocb->ki_pos, and mapping is always equal to > iocb->ki_filp->f_mapping. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Damien Le Moal Acked-by: Miklos Szeredi _

Re: [f2fs-dev] [PATCH 10/11] fuse: update ki_pos in fuse_perform_write

2023-05-24 Thread Miklos Szeredi via Linux-f2fs-devel
On Wed, 24 May 2023 at 08:38, Christoph Hellwig wrote: > > Both callers of fuse_perform_write need to updated ki_pos, move it into > common code. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Damien Le Moal > --- > fs/fuse/file.c | 25 +++-- > 1 file changed, 11 insert

Re: [f2fs-dev] [PATCH 09/11] fs: factor out a direct_write_fallback helper

2023-05-24 Thread Miklos Szeredi via Linux-f2fs-devel
On Wed, 24 May 2023 at 08:38, Christoph Hellwig wrote: > > Add a helper dealing with handling the syncing of a buffered write fallback > for direct I/O. > > Signed-off-by: Christoph Hellwig > --- > fs/libfs.c | 36 + > include/linux/fs.h | 2 ++ > mm/filemap.c