[f2fs-dev] [PATCH] f2fs: call fsnotify_sb_error() when f2fs have errors

2023-06-19 Thread Yangtao Li via Linux-f2fs-devel
When an EFSCORRUPTED error occurs in f2fs, report the error to userspace monitoring tools. Signed-off-by: Yangtao Li --- fs/f2fs/super.c | 5 + 1 file changed, 5 insertions(+) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 375a178540d6..69c747c4d4f4 100644 --- a/fs/f2fs/super.c +++ b/

Re: [f2fs-dev] [PATCH] f2fs: compress: don't force buffered io when in COMPR_MODE_USER mode

2023-06-19 Thread Yangtao Li via Linux-f2fs-devel
On 2023/6/19 12:04, Chao Yu wrote: On 2023/6/19 11:11, Yangtao Li wrote: On 2023/6/19 8:54, Chao Yu wrote: On 2023/6/13 12:14, Yangtao Li wrote: On 2023/6/12 22:38, Chao Yu wrote: On 2023/6/9 21:15, Yangtao Li wrote: It is observed that when in user compression mode (compress_extension=*)

Re: [f2fs-dev] [PATCH v6] f2fs: support FAULT_LOCK type fault injection

2023-06-19 Thread Chao Yu
On 2023/4/20 14:22, Yangtao Li wrote: Similar to FAULT_LOCK_OP, this patch supports to inject fault into variant of _trylock(), including: - inode_trylock - down_read_trylock - down_write_trylock - mutex_trylock - sb_start_write_trylock - trylock_page Usage: a) echo 524288 >

Re: [f2fs-dev] [PATCH] f2fs: compress: don't force buffered io when in COMPR_MODE_USER mode

2023-06-19 Thread Chao Yu
On 2023/6/19 17:31, Yangtao Li wrote: On 2023/6/19 12:04, Chao Yu wrote: On 2023/6/19 11:11, Yangtao Li wrote: On 2023/6/19 8:54, Chao Yu wrote: On 2023/6/13 12:14, Yangtao Li wrote: On 2023/6/12 22:38, Chao Yu wrote: On 2023/6/9 21:15, Yangtao Li wrote: It is observed that when in user

Re: [f2fs-dev] [PATCH v2] f2fs: fix to avoid mmap vs set_compress_option case

2023-06-19 Thread Chao Yu
On 2023/6/16 14:03, Eric Biggers wrote: Hi Chao, Eric, Thanks for the report, let me check this. Thanks, On Mon, May 29, 2023 at 06:47:09PM +0800, Chao Yu wrote: Compression option in inode should not be changed after they have been used, however, it may happen in below race case: Thread

[f2fs-dev] [PATCH] f2fs: update mtime and ctime in move file range method

2023-06-19 Thread Yunlei He via Linux-f2fs-devel
Mtime and ctime stay old value without update after move file range ioctl, This patch add time update. Signed-off-by: Yunlei He --- fs/f2fs/file.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 34a6177c64a4..81e4b85fe805 100644 --- a/fs/f2fs/file

[f2fs-dev] [PATCH] f2fs: count mmap write io more accurately

2023-06-19 Thread Yunlei He via Linux-f2fs-devel
This patch count mmap write io more accurately. Signed-off-by: Yunlei He --- fs/f2fs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 41e7c2b80f31..147ab24ae579 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -152,11 +152,11 @@

[f2fs-dev] [PATCH] f2fs: remove unneeded page uptodate check/set

2023-06-19 Thread Yunlei He via Linux-f2fs-devel
This patch remove unneeded page uptodate check/set in f2fs_vm_page_mkwrite, which already done in set_page_dirty. Signed-off-by: Yunlei He --- fs/f2fs/file.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 147ab24ae579..b3e96bceaef2 100644 --- a/fs/f2fs

[f2fs-dev] [PATCH v2] f2fs: count mmap write io more accurately

2023-06-19 Thread Yunlei He via Linux-f2fs-devel
This patch count mmap write io more accurately. Signed-off-by: Yunlei He --- fs/f2fs/file.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index f05209a62370..cb42d8464ad9 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -150,11

[f2fs-dev] f2fs async buffered write patch

2023-06-19 Thread Jens Axboe
Hi, I came across this patch in a news posting: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=d618126911829523e35a61f4a5a4ad159b1b2c8d which has me a bit worried. As far as I can tell, all that patch does is set FMODE_BUF_WASYNC, and then just hope that the lo

Re: [f2fs-dev] [PATCH] f2fs: not allowed to set file both cold and hot

2023-06-19 Thread Chao Yu
On 2023/6/13 16:52, Yunlei He wrote: File set both cold and hot advise bit is confusion, so return EINVAL to avoid this case. Signed-off-by: Yunlei He --- fs/f2fs/xattr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c index 213805d3592c..917f3ac9f1a1

Re: [f2fs-dev] [PATCH] f2fs: not allowed to set file both cold and hot

2023-06-19 Thread Yunlei he
On 2023/6/20 8:33, Chao Yu wrote: On 2023/6/13 16:52, Yunlei He wrote: File set both cold and hot advise bit is confusion, so return EINVAL to avoid this case. Signed-off-by: Yunlei He ---   fs/f2fs/xattr.c | 3 +++   1 file changed, 3 insertions(+) diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xatt

Re: [f2fs-dev] f2fs async buffered write patch

2023-06-19 Thread Jaegeuk Kim
On 06/19, Jens Axboe wrote: > Hi, > > I came across this patch in a news posting: > > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=d618126911829523e35a61f4a5a4ad159b1b2c8d > > which has me a bit worried. As far as I can tell, all that patch does is > set FMOD

Re: [f2fs-dev] [PATCH] f2fs: no need test opt for f2fs_issue_flush

2023-06-19 Thread Jaegeuk Kim
On 06/19, Chao Yu wrote: > On 2023/4/26 0:58, Yangtao Li wrote: > > This information can now be obtained from the mount, and there isi > > no need to print it out every time the trace event is triggered. > > It makes sense. > > Jaegeuk, is it intentional to print mount option in f2fs_issue_flush