Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-07-12 Thread Chao Yu
On 2023/7/12 23:55, Jaegeuk Kim wrote: On 07/12, Chao Yu wrote: On 2023/7/12 0:37, Jaegeuk Kim wrote: On 07/06, Chao Yu wrote: On 2023/7/6 1:30, Jaegeuk Kim wrote: On 07/04, Chao Yu wrote: On 2023/7/4 18:53, Jaegeuk Kim wrote: On 07/03, Chao Yu wrote: On 2023/6/15 0:10, Jaegeuk Kim wrote:

Re: [f2fs-dev] [PATCH 01/32] block: Provide blkdev_get_handle_* functions

2023-07-12 Thread Haris Iqbal via Linux-f2fs-devel
On Thu, Jul 6, 2023 at 5:38 PM Christoph Hellwig wrote: > > On Tue, Jul 04, 2023 at 02:21:28PM +0200, Jan Kara wrote: > > Create struct bdev_handle that contains all parameters that need to be > > passed to blkdev_put() and provide blkdev_get_handle_* functions that > > return this structure inste

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-07-12 Thread Jaegeuk Kim
On 07/12, Chao Yu wrote: > On 2023/7/12 0:37, Jaegeuk Kim wrote: > > On 07/06, Chao Yu wrote: > > > On 2023/7/6 1:30, Jaegeuk Kim wrote: > > > > On 07/04, Chao Yu wrote: > > > > > On 2023/7/4 18:53, Jaegeuk Kim wrote: > > > > > > On 07/03, Chao Yu wrote: > > > > > > > On 2023/6/15 0:10, Jaegeuk Kim

[f2fs-dev] [PATCH] f2fs: should use inode when updating file offset

2023-07-12 Thread Jaegeuk Kim
In indirect or double indirect node blocks, we should use parent inode information to check the offset. This fixes the below complaint with a reproducer. $ mount -t f2fs -o discard,compress_extension=* /dev/$DEV $TESTDIR $ f2fs_io write 1 3944 4 zero buffered $TESTDIR/a $ umount /dev/$DEV $ fsck.

[f2fs-dev] [PATCH 2/2] f2fs: compress: don't {, de}compress non-full cluster

2023-07-12 Thread Chao Yu
f2fs won't compress non-full cluster in tail of file, let's skip dirtying and rewrite such cluster during f2fs_ioc_{,de}compress_file. Signed-off-by: Chao Yu --- fs/f2fs/file.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file

[f2fs-dev] [PATCH 1/2] f2fs: allow f2fs_ioc_{, de}compress_file to be interrupted

2023-07-12 Thread Chao Yu
This patch allows f2fs_ioc_{,de}compress_file() to be interrupted, so that, userspace won't be blocked when manual {,de}compression on large file is interrupted by signal. Signed-off-by: Chao Yu --- fs/f2fs/file.c | 12 1 file changed, 12 insertions(+) diff --git a/fs/f2fs/file.c b

[f2fs-dev] [PATCH] f2fs-tools: support print_xattr_entry with fscrypt context v2

2023-07-12 Thread Weichao Guo via Linux-f2fs-devel
Signed-off-by: Weichao Guo Signed-off-by: Sheng Yong --- fsck/mount.c | 44 +++--- fsck/xattr.h | 54 +++- 2 files changed, 74 insertions(+), 24 deletions(-) diff --git a/fsck/mount.c b/fsck/mount.c index 397feb