Re: [f2fs-dev] [PATCH v4 3/7] libfs: Validate negative dentries in case-insensitive directories

2023-07-28 Thread Eric Biggers
On Thu, Jul 27, 2023 at 01:28:39PM -0400, Gabriel Krisman Bertazi wrote: > dentry->d_name is only checked by the case-insensitive d_revalidate hook > in the LOOKUP_CREATE/LOOKUP_RENAME_TARGET case since, for these cases, > d_revalidate is always called with the parent inode read-locked, and > there

Re: [f2fs-dev] [PATCH v4 2/7] fs: Add DCACHE_CASEFOLDED_NAME flag

2023-07-28 Thread Eric Biggers
On Thu, Jul 27, 2023 at 01:28:38PM -0400, Gabriel Krisman Bertazi wrote: > From: Gabriel Krisman Bertazi > > This flag marks a negative or positive dentry as being created after a > case-insensitive lookup operation. It is useful to differentiate > dentries this way to detect whether the negativ

Re: [f2fs-dev] [PATCH v4 3/7] libfs: Validate negative dentries in case-insensitive directories

2023-07-28 Thread Eric Biggers
On Thu, Jul 27, 2023 at 01:28:39PM -0400, Gabriel Krisman Bertazi wrote: > - In __lookup_slow, either the parent inode is read locked by the > caller (lookup_slow), or it is called with no flags (lookup_one*). > The read lock suffices to prevent ->d_name modifications, with the > exce

Re: [f2fs-dev] [PATCH v4 3/7] libfs: Validate negative dentries in case-insensitive directories

2023-07-28 Thread Eric Biggers
On Fri, Jul 28, 2023 at 11:09:46AM -0400, Gabriel Krisman Bertazi wrote: > Christian Brauner writes: > > > On Thu, Jul 27, 2023 at 01:28:39PM -0400, Gabriel Krisman Bertazi wrote: > > > > > Wouldn't it make sense to get rid of all this indentation? > > I'm ok with making this change. I'll wait

Re: [f2fs-dev] [PATCH v4 1/7] fs: Expose name under lookup to d_revalidate hook

2023-07-28 Thread Christian Brauner
On Thu, Jul 27, 2023 at 01:28:37PM -0400, Gabriel Krisman Bertazi wrote: > From: Gabriel Krisman Bertazi > > Negative dentries support on case-insensitive ext4/f2fs will require > access to the name under lookup to ensure it matches the dentry. This > adds an optional new flavor of cached dentry

Re: [f2fs-dev] [PATCH v4 3/7] libfs: Validate negative dentries in case-insensitive directories

2023-07-28 Thread Christian Brauner
On Thu, Jul 27, 2023 at 01:28:39PM -0400, Gabriel Krisman Bertazi wrote: > From: Gabriel Krisman Bertazi > > Introduce a dentry revalidation helper to be used by case-insensitive > filesystems to check if it is safe to reuse a negative dentry. > > A negative dentry is safe to be reused on a case

Re: [f2fs-dev] [PATCH v3 05/49] mm: shrinker: add infrastructure for dynamically allocating shrinker

2023-07-28 Thread Simon Horman
On Thu, Jul 27, 2023 at 04:04:18PM +0800, Qi Zheng wrote: > Currently, the shrinker instances can be divided into the following three > types: > > a) global shrinker instance statically defined in the kernel, such as >workingset_shadow_shrinker. > > b) global shrinker instance statically defi

Re: [f2fs-dev] [PATCH v4 0/7] Support negative dentries on case-insensitive ext4 and f2fs

2023-07-28 Thread Christian Brauner
On Thu, Jul 27, 2023 at 01:28:36PM -0400, Gabriel Krisman Bertazi wrote: > Hi, > > This is the v4 of the negative dentry support on case-insensitive > directories. It doesn't have any functional changes from v1. It applies > Eric's comments to bring the flags check closet together, improve the I

Re: [f2fs-dev] (subset) [PATCH v6 0/7] fs: implement multigrain timestamps

2023-07-28 Thread Christian Brauner
On Tue, 25 Jul 2023 10:58:13 -0400, Jeff Layton wrote: > The VFS always uses coarse-grained timestamps when updating the > ctime and mtime after a change. This has the benefit of allowing > filesystems to optimize away a lot metadata updates, down to around 1 > per jiffy, even when a file is under

Re: [f2fs-dev] [PATCH v3 04/49] mm: shrinker: remove redundant shrinker_rwsem in debugfs operations

2023-07-28 Thread Simon Horman
On Thu, Jul 27, 2023 at 04:04:17PM +0800, Qi Zheng wrote: > The debugfs_remove_recursive() will wait for debugfs_file_put() to return, > so the shrinker will not be freed when doing debugfs operations (such as > shrinker_debugfs_count_show() and shrinker_debugfs_scan_write()), so there > is no need

Re: [f2fs-dev] [PATCH v3 04/49] mm: shrinker: remove redundant shrinker_rwsem in debugfs operations

2023-07-28 Thread Qi Zheng via Linux-f2fs-devel
Hi Simon, On 2023/7/28 16:13, Simon Horman wrote: On Thu, Jul 27, 2023 at 04:04:17PM +0800, Qi Zheng wrote: The debugfs_remove_recursive() will wait for debugfs_file_put() to return, so the shrinker will not be freed when doing debugfs operations (such as shrinker_debugfs_count_show() and shrin

Re: [f2fs-dev] [PATCH v4 0/7] Support negative dentries on case-insensitive ext4 and f2fs

2023-07-28 Thread Christian Brauner
> since it has vfs, ext4, and f2fs changes (and the bulk of the changes > are in the vfs), perhaps it should go through the vfs tree? I've just waited for Eric to finish his review. I'll take a look later and will get it into -next for long soaking. __