[f2fs-dev] [PATCH 3/3] f2fs-tools: Fix dqb_curspace to reflect blocksize

2023-11-17 Thread Daniel Rosenberg via Linux-f2fs-devel
The initial sizes for dqblk.dqb_curspace should reflect the block size, as that's the minimal filesize. Signed-off-by: Daniel Rosenberg --- mkfs/f2fs_format.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c index f2840c8..b46bc15 10

[f2fs-dev] [PATCH 0/3] F2FS Tools 16K Bug Fixes

2023-11-17 Thread Daniel Rosenberg via Linux-f2fs-devel
I missed a couple things in my previous patch set. This fixes Quotas, the -c cache option, and a debug print. The issues can be seen by running: truncate test.dat --size 256M make_f2fs -g android -O project_quota,extra_attr -w 16384 -b 16384 test.dat 16384 fsck.f2fs -f -c 1 --debug-cache test

[f2fs-dev] [PATCH 1/3] f2fs-tools: Fix debug size print

2023-11-17 Thread Daniel Rosenberg via Linux-f2fs-devel
The conversion from block size to MB in this debug statement assumes a block size of 4K. This switches it to properly use the filesystem's block size. Signed-off-by: Daniel Rosenberg --- fsck/fsck.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fsck/fsck.c b/fsck/fsck.c i

[f2fs-dev] [PATCH 2/3] f2fs-tools: Wait for Block Size to initialize Cache

2023-11-17 Thread Daniel Rosenberg via Linux-f2fs-devel
The cache is initialized during the first read, however, it requires the block size to establish its buffer. This disables the cache until the block size is known. Signed-off-by: Daniel Rosenberg --- fsck/mount.c | 5 + 1 file changed, 5 insertions(+) diff --git a/fsck/mount.c b/fsck/mount.

[f2fs-dev] [PATCH] f2fs-tools: adjust nat and block release logic

2023-11-17 Thread Daeho Jeong
From: Daeho Jeong Fixes: 0f503e443ccb ("f2fs-tools: do not reuse corrupted quota inodes") Signed-off-by: Daeho Jeong --- fsck/fsck.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fsck/fsck.c b/fsck/fsck.c index 55eddca..2bb759c 100644 --- a/fsck/fsck.c +++ b/fsck/fsck.

Re: [f2fs-dev] [PATCH] f2fs: skip adding a discard command if exists

2023-11-17 Thread Jaegeuk Kim
On 11/15, Chao Yu wrote: > On 2023/11/15 10:45, Jaegeuk Kim wrote: > > On 11/15, Chao Yu wrote: > > > On 2023/11/15 5:24, Jaegeuk Kim wrote: > > > > When recovering zoned UFS, sometimes we add the same zone to discard > > > > multiple > > > > times. Simple workaround is to bypass adding it. > > >

Re: [f2fs-dev] [PATCH v1] f2fs: New victim selection for GC

2023-11-17 Thread Jaegeuk Kim
Hi Yonggil, On 10/26, Yonggil Song wrote: > Overview > > > Introduce a new way to select the data section first when selecting a > victim in foreground GC. This victim selection method works when the > prefer_data_victim mount option is enabled. If foreground GC migrates only > data sect

Re: [f2fs-dev] [PATCH v2] f2fs-tools: do not reuse corrupted quota inodes

2023-11-17 Thread Daeho Jeong
On Fri, Nov 17, 2023 at 9:24 AM Jaegeuk Kim wrote: > > On 11/15, Chao Yu wrote: > > On 2023/10/27 8:21, Daeho Jeong wrote: > > > From: Daeho Jeong > > > > > > When we detect quota inode corruption, we better deallocate the current > > > space and allocate new ones for a clean start. > > > > > > S

Re: [f2fs-dev] [PATCH v2] f2fs-tools: do not reuse corrupted quota inodes

2023-11-17 Thread Jaegeuk Kim
On 11/15, Chao Yu wrote: > On 2023/10/27 8:21, Daeho Jeong wrote: > > From: Daeho Jeong > > > > When we detect quota inode corruption, we better deallocate the current > > space and allocate new ones for a clean start. > > > > Signed-off-by: Daeho Jeong > > > > --- > > v2: change node count ch