Re: [f2fs-dev] [PATCH v2] f2fs: fix zoned block device information initialization

2024-01-21 Thread Dan Carpenter
Hi Wenjie, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Wenjie-Qi/f2fs-fix-zoned-block-device-information-initialization/20240116-220824 base: https://git.kernel

Re: [f2fs-dev] [PATCH] f2fs-tools: allocate logs after conventional area for HM zoned devices

2024-01-21 Thread Chao Yu
On 2024/1/18 7:00, Daeho Jeong wrote: From: Daeho Jeong Make to allocate logs after conventional area for HM zoned devices to spare them for file pinning support. Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mai

Re: [f2fs-dev] [PATCH V1] f2fs: fix potentail deadloop issue in do_recover_data

2024-01-21 Thread Zhiguo Niu
Hi Chao On Mon, Jan 22, 2024 at 11:46 AM Chao Yu wrote: > > On 2023/12/25 19:11, Zhiguo Niu wrote: > > There is a potentail deadloop issue in the corner case of > > CONFIG_F2FS_FAULT_INJECTION is enabled and the return value > > of f2fs_reserve_new_block is error but not -ENOSPC, such as > > this

Re: [f2fs-dev] [PATCH V1] f2fs: fix potentail deadloop issue in do_recover_data

2024-01-21 Thread Chao Yu
On 2023/12/25 19:11, Zhiguo Niu wrote: There is a potentail deadloop issue in the corner case of CONFIG_F2FS_FAULT_INJECTION is enabled and the return value of f2fs_reserve_new_block is error but not -ENOSPC, such as this error case: if (unlikely(is_inode_flag_set(dn->inode, FI_NO_ALLOC)))

Re: [f2fs-dev] [PATCH] f2fs: use IS_INODE replace IS_DNODE in f2fs_flush_inline_data

2024-01-21 Thread Chao Yu
On 2024/1/17 15:59, Zhiguo Niu wrote: Now IS_DNODE is used in f2fs_flush_inline_data and it has some problems: 1. Just only inodes may include inline data,not all direct nodes 2. When system IO is busy, it is inefficient to lock a direct node page but not an inode page. Besides, if this direct no

Re: [f2fs-dev] [PATCH] f2fs: compress: remove some redundant codes in f2fs_cache_compressed_page

2024-01-21 Thread Chao Yu
On 2024/1/18 13:48, Zhiguo Niu wrote: Just remove some redundant codes, no logic change. Signed-off-by: Zhiguo Niu Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.ne

Re: [f2fs-dev] [PATCH] f2fs: compress: fix to cover f2fs_disable_compressed_file() w/ i_sem

2024-01-21 Thread Chao Yu
On 2024/1/17 2:29, Jaegeuk Kim wrote: On 01/11, Chao Yu wrote: - f2fs_disable_compressed_file - check inode_has_data - f2fs_file_mmap - mkwrite - f2fs_get_block_locked

[f2fs-dev] [PATCH v2] f2fs: compress: fix to cover f2fs_disable_compressed_file() w/ i_sem

2024-01-21 Thread Chao Yu
- f2fs_disable_compressed_file - check inode_has_data - f2fs_file_mmap - mkwrite - f2fs_get_block_locked : update metadata in compresse