Re: [f2fs-dev] [PATCH v4 4/4] f2fs: stop checkpoint when get a out-of-bounds segment

On 2024/2/22 13:48, Zhiguo Niu wrote: Dear Chao, On Thu, Feb 22, 2024 at 11:51 AM Chao Yu mailto:c...@kernel.org>> wrote: On 2024/2/22 10:15, Zhiguo Niu wrote: > > > On Thu, Feb 22, 2024 at 9:37 AM Chao Yu mailto:c...@kernel.org>

Re: [f2fs-dev] [PATCH v4 4/4] f2fs: stop checkpoint when get a out-of-bounds segment

On 2024/2/22 10:15, Zhiguo Niu wrote: On Thu, Feb 22, 2024 at 9:37 AM Chao Yu mailto:c...@kernel.org>> wrote: On 2024/2/20 14:11, Zhiguo Niu wrote: > There is low probability that an out-of-bounds segment will be got > on a small-capacity device. In order to prevent subsequent wr

Re: [f2fs-dev] [PATCH v4 4/4] f2fs: stop checkpoint when get a out-of-bounds segment

On 2024/2/20 14:11, Zhiguo Niu wrote: There is low probability that an out-of-bounds segment will be got on a small-capacity device. In order to prevent subsequent write requests allocating block address from this invalid segment, which may cause unexpected issue, stop checkpoint should be perfor

Re: [f2fs-dev] [PATCH] f2fs: compress: fix to check zstd compress level correctly in mount option

Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Tue, 13 Feb 2024 00:08:18 +0800 you wrote: > f2fs only support to config zstd compress level w/ a positive number due > to layout design, but since commit e0c1b49f5b67 ("lib: zstd: Upgrade to > latest upstream zstd versio

[f2fs-dev] Patchwork summary for: f2fs

Hello: The following patches were marked "accepted", because they were applied to jaegeuk/f2fs.git (dev): Patch: [f2fs-dev,v2] f2fs: introduce get_available_block_count() for cleanup Submitter: Chao Yu Committer: Jaegeuk Kim Patchwork: https://patchwork.kernel.org/project/f2fs/list/?serie

Re: [f2fs-dev] [PATCH v3 1/2] f2fs: separate f2fs_gc_range() to use GC for a range

Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Tue, 13 Feb 2024 09:38:11 -0800 you wrote: > From: Daeho Jeong > > Make f2fs_gc_range() an extenal function to use it for GC for a range. > > Signed-off-by: Daeho Jeong > Signed-off-by: Jaegeuk Kim > > [...] Here

Re: [f2fs-dev] [PATCH v2 0/4] f2fs: fix panic issue in small capacity device

Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Wed, 7 Feb 2024 10:01:00 +0800 you wrote: > A panic issue happened in a reboot test in small capacity device > as following: > 1.The device size is 64MB, and main area has 24 segments, and > CONFIG_F2FS_CHECK_FS is not e

Re: [f2fs-dev] [PATCH] f2fs: fix to create selinux label during whiteout initialization

Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Wed, 7 Feb 2024 15:05:48 +0800 you wrote: > generic/700 - output mismatch (see > /media/fstests/results//generic/700.out.bad) > --- tests/generic/700.out 2023-03-28 10:40:42.735529223 + > +++ /media/fs

Re: [f2fs-dev] [Patch-next] f2fs: Use folio in f2fs_read_merkle_tree_page

Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Thu, 1 Feb 2024 15:38:58 +0800 you wrote: > From: HuangXiaojia > > Use folio in f2fs_read_merkle_tree_page to reduce folio & page converisons > from find_get_page_flags and read_mapping_page functions. But the return >

Re: [f2fs-dev] [PATCH] f2fs: support SEEK_DATA and SEEK_HOLE for compression files

Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Thu, 15 Feb 2024 12:16:33 -0800 you wrote: > From: Daeho Jeong > > Fix to support SEEK_DATA and SEEK_HOLE for compression files > > Signed-off-by: Daeho Jeong > --- > fs/f2fs/file.c | 21 ++--- > 1 fi

Re: [f2fs-dev] [PATCH] f2fs: doc: Fix bouncing email address for Sahitya Tummala

Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Fri, 2 Feb 2024 09:52:08 -0700 you wrote: > The servers for the @codeaurora domain are long retired and any messages > addressed there will bounce. Sahitya Tummala has a .mailmap entry to an > updated address, but the do

Re: [f2fs-dev] [PATCH 1/3] f2fs: deprecate io_bits

Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Tue, 6 Feb 2024 16:51:03 -0800 you wrote: > Let's deprecate an unused io_bits feature to save CPU cycles and memory. > > Signed-off-by: Jaegeuk Kim > --- > Documentation/filesystems/f2fs.rst | 2 - > fs/f2fs/data.c

Re: [f2fs-dev] [PATCH v2] f2fs: introduce get_available_block_count() for cleanup

Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Tue, 20 Feb 2024 11:15:15 +0800 you wrote: > There are very similar codes in inc_valid_block_count() and > inc_valid_node_count() which is used for available user block > count calculation. > > This patch introduces a ne

Re: [f2fs-dev] [PATCH 3/3 v2] f2fs: kill zone-capacity support

On 02/21, Juhyung Park wrote: > On Wed, Feb 21, 2024 at 4:03 AM Jaegeuk Kim wrote: > > > > On 02/20, Chao Yu wrote: > > > Jaegeuk, Daeho, > > > > > > Do we need Cc WD guys? Not sure whether they need this feature... > > > > CC'ed WDC folks. > > > > > > > > For ZUFS: 1) will it only exports 2MB-ali

[f2fs-dev] [PATCH v7 10/10] libfs: Drop generic_set_encrypted_ci_d_ops

No filesystems depend on it anymore, and it is generally a bad idea. Since all dentries should have the same set of dentry operations in case-insensitive capable filesystems, it should be propagated through ->s_d_op. Signed-off-by: Gabriel Krisman Bertazi --- fs/libfs.c | 34

[f2fs-dev] [PATCH v7 08/10] f2fs: Configure dentry operations at dentry-creation time

This was already the case for case-insensitive before commit bb9cd9106b22 ("fscrypt: Have filesystems handle their d_ops"), but it was changed to set at lookup-time to facilitate the integration with fscrypt. But it's a problem because dentries that don't get created through ->lookup() won't have

[f2fs-dev] [PATCH v7 06/10] libfs: Add helper to choose dentry operations at mount-time

In preparation to drop the similar helper that sets d_op at lookup time, add a version to set the right d_op filesystem-wide, through sb->s_d_op. The operations structures are shared across filesystems supporting fscrypt and/or casefolding, therefore we can keep it in common libfs code. Signed-off

[f2fs-dev] [PATCH v7 07/10] ext4: Configure dentry operations at dentry-creation time

This was already the case for case-insensitive before commit bb9cd9106b22 ("fscrypt: Have filesystems handle their d_ops"), but it was changed to set at lookup-time to facilitate the integration with fscrypt. But it's a problem because dentries that don't get created through ->lookup() won't have

[f2fs-dev] [PATCH v7 09/10] ubifs: Configure dentry operations at dentry-creation time

fscrypt now supports configuring dentry operations at dentry-creation time through the preset sb->s_d_op, instead of at lookup time. Enable this in ubifs, since the lookup-time mechanism is going away. Signed-off-by: Gabriel Krisman Bertazi --- fs/ubifs/dir.c | 1 - fs/ubifs/super.c | 1 + 2 f

[f2fs-dev] [PATCH v7 00/10] Set casefold/fscrypt dentry operations through sb->s_d_op

Hi, v7 of this patchset applying the comments from Eric. Thank you for your feedback. Details in changelog of individual patches. As usual, this survived fstests on ext4 and f2fs. Thank you, --- original cover letter: When case-insensitive and fscrypt were adapted to work together, we moved t

[f2fs-dev] [PATCH v7 04/10] fscrypt: Drop d_revalidate once the key is added

When a key is added, existing directory dentries in the DCACHE_NOKEY_NAME form are moved by the VFS to the plaintext version. But, since they have the DCACHE_OP_REVALIDATE flag set, revalidation will be done at each lookup only to return immediately, since plaintext dentries can't go stale until ev

[f2fs-dev] [PATCH v7 05/10] libfs: Merge encrypted_ci_dentry_ops and ci_dentry_ops

In preparation to get case-insensitive dentry operations from sb->s_d_op again, use the same structure with and without fscrypt. Signed-off-by: Gabriel Krisman Bertazi --- Changes since v1: - fix header guard (eric) --- fs/libfs.c | 34 ++ 1 file changed, 6 ins

[f2fs-dev] [PATCH v7 02/10] fscrypt: Factor out a helper to configure the lookup dentry

Both fscrypt_prepare_lookup_partial and fscrypt_prepare_lookup will set DCACHE_NOKEY_NAME for dentries when the key is not available. Extract out a helper to set this flag in a single place, in preparation to also add the optimization that will disable ->d_revalidate if possible. Signed-off-by: Ga

[f2fs-dev] [PATCH v7 01/10] ovl: Always reject mounting over case-insensitive directories

overlayfs relies on the filesystem setting DCACHE_OP_HASH or DCACHE_OP_COMPARE to reject mounting over case-insensitive directories. Since commit bb9cd9106b22 ("fscrypt: Have filesystems handle their d_ops"), we set ->d_op through a hook in ->d_lookup, which means the root dentry won't have them,

[f2fs-dev] [PATCH v7 03/10] fscrypt: Drop d_revalidate for valid dentries during lookup

Unencrypted and encrypted-dentries where the key is available don't need to be revalidated by fscrypt, since they don't go stale from under VFS and the key cannot be removed for the encrypted case without evicting the dentry. Disable their d_revalidate hook on the first lookup, to avoid repeated r

[f2fs-dev] [PATCH] mkfs.f2fs: kill heap allocation

No one uses this feature. Let's kill it. Signed-off-by: Chao Yu --- include/f2fs_fs.h | 1 - man/mkfs.f2fs.8 | 6 +- mkfs/f2fs_format.c | 8 mkfs/f2fs_format_main.c | 5 + 4 files changed, 2 insertions(+), 18 deletions(-) diff --git a/include/f2fs_fs.h b/incl

[f2fs-dev] [PATCH] f2fs: introduce SEGS_TO_BLKS/BLKS_TO_SEGS for cleanup

Just cleanup, no functional change. Signed-off-by: Chao Yu --- fs/f2fs/debug.c | 7 +++ fs/f2fs/f2fs.h| 14 -- fs/f2fs/gc.c | 10 +- fs/f2fs/gc.h | 4 ++-- fs/f2fs/segment.c | 12 ++-- fs/f2fs/segment.h | 8 fs/f2fs/super.c | 16 +

Re: [f2fs-dev] [PATCH 3/3 v2] f2fs: kill zone-capacity support

On Wed, Feb 21, 2024 at 4:03 AM Jaegeuk Kim wrote: > > On 02/20, Chao Yu wrote: > > Jaegeuk, Daeho, > > > > Do we need Cc WD guys? Not sure whether they need this feature... > > CC'ed WDC folks. > > > > > For ZUFS: 1) will it only exports 2MB-aligned zone size, and 2) its zone > > capacity equals

[f2fs-dev] [PATCH] f2fs: control gc_thread_func to run periodically

From: liujinbao1 By default, the gc_thread_func function fluctuates within the range of min_sleep_time to max_sleep_time, and only when gc_mode is GC_URGENT_HIGH, wait_ms can be specified as urgent_sleep_time.For other algorithms, we may also want to execute it periodically. After introducing thi