Re: [f2fs-dev] [PATCH] f2fs: assign write hint in direct write IO path

2024-04-19 Thread Chao Yu
On 2024/4/20 1:53, Jaegeuk Kim wrote: Thanks, Chao, If you don't mind, can I merge this into my patch. Ok? No problem. :) Thanks, On 04/18, Chao Yu wrote: f2fs has its own write_hint policy, let's assign write hint for direct write bio. Cc: Hyunchul Lee Signed-off-by: Chao Yu --- fs/

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix false alarm on invalid block address

2024-04-19 Thread Jaegeuk Kim
On 04/19, Juhyung Park wrote: > On Sat, Apr 13, 2024 at 5:57 AM Jaegeuk Kim wrote: > > > > On 04/11, Chao Yu wrote: > > > On 2024/4/10 4:34, Jaegeuk Kim wrote: > > > > f2fs_ra_meta_pages can try to read ahead on invalid block address which > > > > is > > > > not the corruption case. > > > > > > I

Re: [f2fs-dev] [PATCH] f2fs: assign the write hint per stream by default

2024-04-19 Thread Jaegeuk Kim
On 04/18, Chao Yu wrote: > On 2024/4/18 5:12, Jaegeuk Kim wrote: > > This reverts commit 930e2607638d ("f2fs: remove obsolete whint_mode"), as we > > decide to pass write hints to the disk. > > > > Signed-off-by: Jaegeuk Kim > > --- > > Documentation/filesystems/f2fs.rst | 29 +++ >

Re: [f2fs-dev] [PATCH] f2fs: assign write hint in direct write IO path

2024-04-19 Thread Jaegeuk Kim
Thanks, Chao, If you don't mind, can I merge this into my patch. Ok? On 04/18, Chao Yu wrote: > f2fs has its own write_hint policy, let's assign write hint for > direct write bio. > > Cc: Hyunchul Lee > Signed-off-by: Chao Yu > --- > fs/f2fs/f2fs.h| 1 + > fs/f2fs/file.c| 15

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix false alarm on invalid block address

2024-04-19 Thread Juhyung Park
On Sat, Apr 13, 2024 at 5:57 AM Jaegeuk Kim wrote: > > On 04/11, Chao Yu wrote: > > On 2024/4/10 4:34, Jaegeuk Kim wrote: > > > f2fs_ra_meta_pages can try to read ahead on invalid block address which is > > > not the corruption case. > > > > In which case we will read ahead invalid meta pages? rec