Re: [f2fs-dev] [PATCH v4 1/2] dump.f2fs: Add ability to dump folders

2024-05-23 Thread Daeho Jeong
On Thu, May 23, 2024 at 3:48 PM Daniel Rosenberg via Linux-f2fs-devel wrote: > > This adds the ability to dump folders as well as files. Folders are > dumped recursively. Additionally, dumped files/folders may be directed > to a folder specified by -o [path] instead of ./lost_found. The -r flag >

Re: [f2fs-dev] [PATCH v4 2/2] dump.f2fs: Fix xattr dumping

2024-05-23 Thread Daeho Jeong
On Thu, May 23, 2024 at 3:48 PM Daniel Rosenberg via Linux-f2fs-devel wrote: > > Xattrs for files with inline data were being skipped. This dumps those, > as well as xattrs for folders. > > Signed-off-by: Daniel Rosenberg > Reviewed-by: Daeho Jeong > --- > fsck/dump.c | 39 +

[f2fs-dev] [PATCH v4 1/2] dump.f2fs: Add ability to dump folders

2024-05-23 Thread Daniel Rosenberg via Linux-f2fs-devel
This adds the ability to dump folders as well as files. Folders are dumped recursively. Additionally, dumped files/folders may be directed to a folder specified by -o [path] instead of ./lost_found. The -r flag will dump the entire fs from the root inode. -f or -y will skip the prompt before dumpin

[f2fs-dev] [PATCH v4 2/2] dump.f2fs: Fix xattr dumping

2024-05-23 Thread Daniel Rosenberg via Linux-f2fs-devel
Xattrs for files with inline data were being skipped. This dumps those, as well as xattrs for folders. Signed-off-by: Daniel Rosenberg Reviewed-by: Daeho Jeong --- fsck/dump.c | 39 +++ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/fsck/dump

[f2fs-dev] [PATCH v3 2/2] dump.f2fs: Fix xattr dumping

2024-05-23 Thread Daniel Rosenberg via Linux-f2fs-devel
Xattrs for files with inline data were being skipped. This dumps those, as well as xattrs for folders. Signed-off-by: Daniel Rosenberg Reviewed-by: Daeho Jeong --- fsck/dump.c | 39 +++ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/fsck/dump

[f2fs-dev] [PATCH v3 1/2] dump.f2fs: Add ability to dump folders

2024-05-23 Thread Daniel Rosenberg via Linux-f2fs-devel
This adds the ability to dump folders as well as files. Folders are dumped recursively. Additionally, dumped files/folders may be directed to a folder specified by -o [path] instead of ./lost_found. The -r flag will dump the entire fs from the root inode. -f or -y will skip the prompt before dumpin

Re: [f2fs-dev] [PATCH] f2fs: fix false alarm on invalid block address

2024-05-23 Thread Jaegeuk Kim
Fixed the stable mailing list. On 05/23, Jaegeuk Kim wrote: > Hi Greg, > > Could you please consider to cherry-pick this patch in stable-6.9, since > there are many users suffering from unnecessary fsck runs during boot? > > You can get this from Linus's tree by > (b864ddb57eb0 "f2fs: fix false

Re: [f2fs-dev] [PATCH] f2fs: fix false alarm on invalid block address

2024-05-23 Thread Jaegeuk Kim
Hi Greg, Could you please consider to cherry-pick this patch in stable-6.9, since there are many users suffering from unnecessary fsck runs during boot? You can get this from Linus's tree by (b864ddb57eb0 "f2fs: fix false alarm on invalid block address") Thanks, On 05/20, Jaegeuk Kim wrote: > f

[f2fs-dev] [PATCH] f2fs_io: fix output of do_read()

2024-05-23 Thread Chao Yu
echo 1 > file f2fs_io read 1 0 1 dio 4096 ./file Read 0 bytes total_time = 17 us, print 4096 bytes: : ffd537 ffc957 0500 0100 : 0200 : 0300 : fff

[f2fs-dev] [PATCH] f2fs: fix to force buffered IO on inline_data inode

2024-05-23 Thread Chao Yu
It will return all zero data when DIO reading from inline_data inode, it is because f2fs_iomap_begin() assign iomap->type w/ IOMAP_HOLE incorrectly for this case. We can let iomap framework handle inline data via assigning iomap->type and iomap->inline_data correctly, however, it will be a little

[f2fs-dev] [Bug 218870] F2FS mount/unmount results in invalid_blkaddr

2024-05-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218870 --- Comment #3 from Paul Gover (pmw.go...@yahoo.co.uk) --- Created attachment 306325 --> https://bugzilla.kernel.org/attachment.cgi?id=306325&action=edit syslog showing the problem -- You may reply to this email to add a comment. You are rece

[f2fs-dev] [Bug 218870] F2FS mount/unmount results in invalid_blkaddr

2024-05-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218870 Paul Gover (pmw.go...@yahoo.co.uk) changed: What|Removed |Added CC||pmw.go...@yahoo.co.uk