Re: [f2fs-dev] [PATCH] f2fs-tools: fix do_set_verity ioctl fail issue

2024-06-17 Thread Xiuhong Wang
Chao Yu 于2024年6月18日周二 11:04写道: > > On 2024/6/17 15:11, Xiuhong Wang wrote: > > When using the f2fs_io tool to set_verity, it will fail as follows: > > unisc:/data # ./f2fs_io set_verity file > > FS_IOC_ENABLE_VERITY: Inappropriate ioctl for device > > this is because commit: 95ae251fe828 ("f2fs:

Re: [f2fs-dev] [PATCH] f2fs-tools: fix do_set_verity ioctl fail issue

2024-06-17 Thread Chao Yu
On 2024/6/17 15:11, Xiuhong Wang wrote: When using the f2fs_io tool to set_verity, it will fail as follows: unisc:/data # ./f2fs_io set_verity file FS_IOC_ENABLE_VERITY: Inappropriate ioctl for device this is because commit: 95ae251fe828 ("f2fs: add fs-verity support"), the passed parameters do n

Re: [f2fs-dev] [PATCH] dump.f2fs: Fix dumping inlined files

2024-06-17 Thread Chao Yu
On 2024/6/18 8:41, Daniel Rosenberg wrote: The code for dumping files was ignoring i_extra_isize, leading to invalid data for some inlined files after dumping. This swaps inode dumping to use the common inline_data_addr function. Signed-off-by: Daniel Rosenberg Reviewed-by: Chao Yu Thanks,

[f2fs-dev] [PATCH] f2fs: assign CURSEG_ALL_DATA_ATGC if blkaddr is valid

2024-06-17 Thread Jaegeuk Kim
mkdir /mnt/test/comp f2fs_io setflags compression /mnt/test/comp dd if=/dev/zero of=/mnt/test/comp/testfile bs=16k count=1 truncate --size 13 /mnt/test/comp/testfile In the above scenario, we can get a BUG_ON. kernel BUG at fs/f2fs/segment.c:3589! Call Trace: do_write_page+0x78/0x390 [f2fs]

Re: [f2fs-dev] [PATCH] f2fs: add scope based f2fs_putname() cleanup

2024-06-17 Thread Chao Yu
On 2024/6/12 7:39, jtp.p...@samsung.com wrote: From: Jeongtae Park This patch adds a new scope based f2fs_putname() cleanup to reduce the chances of forgetting a f2fs_putname(). And doing so removes Actually, f2fs_trace_rw_file_path() won't change frequently, so the risk of forgetting f2fs_pu

Re: [f2fs-dev] [PATCH 1/1] f2fs-tools: use atoll replace atoi to avoid data truncate

2024-06-17 Thread Chao Yu
On 2024/6/12 15:17, Xiuhong Wang wrote: If input exceeds int range, data will be truncated, such as lseek: unisoc:/data # ./f2fs_io lseek set 3221225000 file returned offset=2147483647 The offset is truncated. After patch: unisoc:/data # ./f2fs_io lseek set 3221225000 file returned offset=322122

Re: [f2fs-dev] [PATCH] f2fs: clean up set REQ_RAHEAD given rac

2024-06-17 Thread Chao Yu
On 2024/6/13 3:38, Jaegeuk Kim wrote: Let's set REQ_RAHEAD per rac by single source. Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/l

Re: [f2fs-dev] [PATCH] f2fs: fix to use mnt_{want, drop}_write_file replace file_{start, end}_wrtie

2024-06-17 Thread Chao Yu
On 2024/6/13 17:35, Zhiguo Niu wrote: mnt_{want,drop}_write_file is more suitable than file_{start,end}_wrtie and also is consistent with other ioctl operations. Signed-off-by: Zhiguo Niu Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing

[f2fs-dev] [PATCH] dump.f2fs: Fix dumping inlined files

2024-06-17 Thread Daniel Rosenberg via Linux-f2fs-devel
The code for dumping files was ignoring i_extra_isize, leading to invalid data for some inlined files after dumping. This swaps inode dumping to use the common inline_data_addr function. Signed-off-by: Daniel Rosenberg --- fsck/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[f2fs-dev] [PATCH] f2fs-tools: fix do_set_verity ioctl fail issue

2024-06-17 Thread Xiuhong Wang
When using the f2fs_io tool to set_verity, it will fail as follows: unisc:/data # ./f2fs_io set_verity file FS_IOC_ENABLE_VERITY: Inappropriate ioctl for device this is because commit: 95ae251fe828 ("f2fs: add fs-verity support"), the passed parameters do not match the latest kernel version. After