[f2fs-dev] [PATCH 1/2] workqueue: add io priority to work_struct

2024-06-20 Thread Yi Sun
Many works will go to submit_bio(), and in many cases the io priority of kworker cannot meet the real-time requirements of this work. So add the basic attribute ioprio to work_struct, and kworker can adjust its io priority according to this attribute. Add function set_work_ioprio() to set the io

[f2fs-dev] [PATCH 0/2] add io priority feature to work and use it in f2fs fsverity work

2024-06-20 Thread Yi Sun
Many works will go to submit_bio(). In many cases, the default io priority of kworker cannot meet the real-time requirements of the work. Such as f2fs_verify_bio work. If a high-task-priority process reads the verity-file, it is likely that the high-task-priority process will be slowly because the

[f2fs-dev] [PATCH 2/2] f2fs: set f2fs verify work io priority

2024-06-20 Thread Yi Sun
The io priority of reading the original data of the verity-file and reading hash blocks during verification should be consistent. If the io priority is not set, when a high-task-priority process reads the verity-file, the kworker's io priority may be too low, resulting in delayed reading of hash bl

Re: [f2fs-dev] [PATCH v4 01/22] fs: Add generic_atomic_write_valid_size()

2024-06-20 Thread Darrick J. Wong
On Thu, Jun 13, 2024 at 08:35:53AM +0100, John Garry wrote: > On 12/06/2024 22:10, Darrick J. Wong wrote: > > On Fri, Jun 07, 2024 at 02:38:58PM +, John Garry wrote: > > > Add a generic helper for FSes to validate that an atomic write is > > > appropriately sized (along with the other checks).

Re: [f2fs-dev] [PATCH 1/3] fs: Export in_group_or_capable()

2024-06-20 Thread Christian Brauner
On Thu, 20 Jun 2024 11:23:33 +0800, Youling Tang wrote: > Export in_group_or_capable() as a VFS helper function. > > This makes sense to me. --- Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstandi

Re: [f2fs-dev] (2) (2) (2) [PATCH] Revert "f2fs: use flush command instead of FUA for zoned device"

2024-06-20 Thread Chao Yu
On 2024/6/20 15:56, Daejun Park wrote: On 2024/6/20 15:22, Daejun Park wrote: On 2024/6/20 13:56, Daejun Park wrote: Hi Chao, Jaegeuk, Quoted commit message from commit c550e25bca66 ("f2fs: use flush command instead of FUA for zoned device") " The block layer for zoned disk can reorder the F

Re: [f2fs-dev] (2) (2) (2) [PATCH] Revert "f2fs: use flush command instead of FUA for zoned device"

2024-06-20 Thread Daejun Park
>On 2024/6/20 15:22, Daejun Park wrote: >>> On 2024/6/20 13:56, Daejun Park wrote: Hi Chao, > Jaegeuk, > > Quoted commit message from commit c550e25bca66 ("f2fs: use flush command > instead of FUA for zoned device") > " > The block layer for zoned disk can reorder

Re: [f2fs-dev] (2) (2) [PATCH] Revert "f2fs: use flush command instead of FUA for zoned device"

2024-06-20 Thread Chao Yu
On 2024/6/20 15:22, Daejun Park wrote: On 2024/6/20 13:56, Daejun Park wrote: Hi Chao, Jaegeuk, Quoted commit message from commit c550e25bca66 ("f2fs: use flush command instead of FUA for zoned device") " The block layer for zoned disk can reorder the FUA'ed IOs. Let's use flush command to ke

Re: [f2fs-dev] (2) (2) [PATCH] Revert "f2fs: use flush command instead of FUA for zoned device"

2024-06-20 Thread Daejun Park
>On 2024/6/20 13:56, Daejun Park wrote: >> Hi Chao, >> >>> Jaegeuk, >>> >>> Quoted commit message from commit c550e25bca66 ("f2fs: use flush command >>> instead of FUA for zoned device") >>> " >>> The block layer for zoned disk can reorder the FUA'ed IOs. Let's use flush >>> command to keep the wri

Re: [f2fs-dev] (2) [PATCH] Revert "f2fs: use flush command instead of FUA for zoned device"

2024-06-20 Thread Chao Yu
On 2024/6/20 13:56, Daejun Park wrote: Hi Chao, Jaegeuk, Quoted commit message from commit c550e25bca66 ("f2fs: use flush command instead of FUA for zoned device") " The block layer for zoned disk can reorder the FUA'ed IOs. Let's use flush command to keep the write order. " It seems mq-deadl