Re: [f2fs-dev] [PATCH v2 1/8] f2fs: convert f2fs_write_begin() to use folio

2024-08-19 Thread Chao Yu
On 2024/8/20 12:38, Li Zetao wrote: I want to apply your patch set for testing, but there is a conflict on the master branch of linux-next. Maybe it depends on a certain pre-patch. Please let me know, thank you.   Applying: f2fs: convert f2fs_write_begin() to use folio   error: patch failed:

Re: [f2fs-dev] [PATCH v2 1/8] f2fs: convert f2fs_write_begin() to use folio

2024-08-19 Thread Li Zetao via Linux-f2fs-devel
Hi, 在 2024/8/20 11:46, Chao Yu 写道: Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- v2: - fix compi

[f2fs-dev] [PATCH v2 6/8] f2fs: convert __write_node_page() to use folio

2024-08-19 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/node.c | 19 ++- 1 file chan

[f2fs-dev] [PATCH v2 8/8] f2fs: get rid of page->index

2024-08-19 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/compress.c | 2 +- fs/f2fs/data.c | 12

[f2fs-dev] [PATCH v2 5/8] f2fs: convert f2fs_write_data_page() to use folio

2024-08-19 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/data.c | 9 + 1 file changed, 5 inse

[f2fs-dev] [PATCH v2 7/8] f2fs: convert read_node_page() to use folio

2024-08-19 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/node.c | 9 + 1 file changed, 5 inse

[f2fs-dev] [PATCH v2 1/8] f2fs: convert f2fs_write_begin() to use folio

2024-08-19 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- v2: - fix compile error. fs/f2fs/data.c | 44 +++

[f2fs-dev] [PATCH v2 4/8] f2fs: convert f2fs_do_write_data_page() to use folio

2024-08-19 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/data.c | 26 +- 1 fi

[f2fs-dev] [PATCH v2 2/8] f2fs: convert f2fs_write_end() to use folio

2024-08-19 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- v2: - fix compile error. fs/f2fs/data.c | 13 +++

[f2fs-dev] [PATCH v2 3/8] f2fs: convert f2fs_set_compressed_page() to use folio

2024-08-19 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/compress.c | 8 +--- 1 file changed, 5 i

Re: [f2fs-dev] [PATCH 2/8] f2fs: convert f2fs_write_end() to use folio

2024-08-19 Thread Chao Yu
On 2024/8/20 11:04, Li Zetao wrote: Hi, 在 2024/8/19 9:20, Chao Yu 写道: Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-

Re: [f2fs-dev] [PATCH 2/8] f2fs: convert f2fs_write_end() to use folio

2024-08-19 Thread Li Zetao via Linux-f2fs-devel
Hi, 在 2024/8/19 9:20, Chao Yu 写道: Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/data.c

Re: [f2fs-dev] [PATCH v2 2/4] f2fs: atomic: fix to not allow GC to pollute atomic_file

2024-08-19 Thread Sunmin Jeong
Hello Chao Yu, >SQLite App GC Thread Shrinker >- f2fs_ioc_start_atomic_write > >- f2fs_ioc_commit_atomic_write > - f2fs_commit_atomic_write > - filemap_write_and_wait_range > : write atomic_file's data to cow_inode > echo 3

Re: [f2fs-dev] [PATCH v2] f2fs: check discard support for conventional zones

2024-08-19 Thread Chao Yu
On 2024/8/16 12:07, Shin'ichiro Kawasaki wrote: As the helper function f2fs_bdev_support_discard() shows, f2fs checks if the target block devices support discard by calling bdev_max_discard_sectors() and bdev_is_zoned(). This check works well for most cases, but it does not work for conventional

Re: [f2fs-dev] [syzbot] [f2fs?] kernel BUG in f2fs_vm_page_mkwrite

2024-08-19 Thread Chao Yu
#syz fix: f2fs: fix return value of f2fs_convert_inline_inode() On 2024/8/5 23:22, syzbot wrote: syzbot suspects this issue was fixed by commit: commit a8eb3de28e7a365690c61161e7a07a4fc7c60bbf Author: Chao Yu Date: Mon Jun 3 01:07:45 2024 + f2fs: fix return value of f2fs_convert_in

Re: [f2fs-dev] [PATCH v2] f2fs: compress: don't redirty sparse cluster during {, de}compress

2024-08-19 Thread Chao Yu
On 2024/8/19 16:34, Yeongjin Gil wrote: In f2fs_do_write_data_page, when the data block is NULL_ADDR, it skips writepage considering that it has been already truncated. This results in an infinite loop as the PAGECACHE_TAG_TOWRITE tag is not cleared during the writeback process for a compressed f

[f2fs-dev] [PATCH v2] f2fs: compress: don't redirty sparse cluster during {, de}compress

2024-08-19 Thread Yeongjin Gil
In f2fs_do_write_data_page, when the data block is NULL_ADDR, it skips writepage considering that it has been already truncated. This results in an infinite loop as the PAGECACHE_TAG_TOWRITE tag is not cleared during the writeback process for a compressed file including NULL_ADDR in compress_mode=u