[f2fs-dev] [PATCH v3] f2fs: Introduce linear search for dentries

2024-12-20 Thread Daniel Lee via Linux-f2fs-devel
This patch addresses an issue where some files in case-insensitive directories become inaccessible due to changes in how the kernel function, utf8_casefold(), generates case-folded strings from the commit 5c26d2f1d3f5 ("unicode: Don't special case ignorable code points"). F2FS uses these case-fold

Re: [f2fs-dev] [PATCH v3 3/5] f2fs: introduce update_sit_entry_for_release()

2024-12-20 Thread Jaegeuk Kim via Linux-f2fs-devel
This makes the code being inconsistent. Can you refactor first and add the loop later separately? For example, 1) add two functions, update_sit_entry_for_alloc() and update_sit_entry_for_release() 2) add a loop in update_sit_entry_for_release() Thanks, On 11/04, Yi Sun wrote: > This function ca

Re: [f2fs-dev] [PATCH v2] f2fs: Introduce linear search for dentries

2024-12-20 Thread Jaegeuk Kim via Linux-f2fs-devel
On 12/20, Daniel Lee wrote: > This patch addresses an issue where some files in case-insensitive > directories become inaccessible due to changes in how the kernel function, > utf8_casefold(), generates case-folded strings from the commit 5c26d2f1d3f5 > ("unicode: Don't special case ignorable code

[f2fs-dev] [PATCH v2] f2fs: Introduce linear search for dentries

2024-12-20 Thread Daniel Lee via Linux-f2fs-devel
This patch addresses an issue where some files in case-insensitive directories become inaccessible due to changes in how the kernel function, utf8_casefold(), generates case-folded strings from the commit 5c26d2f1d3f5 ("unicode: Don't special case ignorable code points"). F2FS uses these case-fold

Re: [f2fs-dev] [PATCH] f2fs: Introduce linear search for dentries

2024-12-20 Thread Daniel Lee via Linux-f2fs-devel
On Fri, Dec 20, 2024 at 5:25 AM Chao Yu wrote: > > On 2024/12/20 12:59, Daniel Lee wrote: > > On Thu, Dec 19, 2024 at 5:29 AM Chao Yu wrote: > >> > >> Hi Daniel, > >> > >> On 2024/12/17 15:55, Daniel Lee wrote: > >>> This patch addresses an issue where some files in case-insensitive > >>> directo

Re: [f2fs-dev] On FI_INLINE_XATTR vs. FI_EXTRA_ATTR

2024-12-20 Thread Chao Yu via Linux-f2fs-devel
On 2024/12/20 21:51, Dmitry Antipov wrote: On 12/20/24 4:34 PM, Chao Yu wrote: I agree w/ you, I've figured out a patch previously, please check it? Hm... https://syzkaller.appspot.com/bug?extid=e4876215632c2d23b481 and https://syzkaller.appspot.com/bug?extid=69f5379a1717a0b982a1 looks identi

Re: [f2fs-dev] On FI_INLINE_XATTR vs. FI_EXTRA_ATTR

2024-12-20 Thread Dmitry Antipov
On 12/20/24 4:34 PM, Chao Yu wrote: I agree w/ you, I've figured out a patch previously, please check it? Hm... https://syzkaller.appspot.com/bug?extid=e4876215632c2d23b481 and https://syzkaller.appspot.com/bug?extid=69f5379a1717a0b982a1 looks identical (but the second one doesn't provide the

Re: [f2fs-dev] On FI_INLINE_XATTR vs. FI_EXTRA_ATTR

2024-12-20 Thread Chao Yu via Linux-f2fs-devel
Hi, Dmitry, I agree w/ you, I've figured out a patch previously, please check it? https://lore.kernel.org/linux-f2fs-devel/20241216134600.8308-1-c...@kernel.org On 2024/12/20 21:30, Dmitry Antipov wrote: Does FI_INLINE_XATTR always assume FI_EXTRA_ATTR? Looking through the code, it's not quite

[f2fs-dev] [jaegeuk-f2fs:dev-test 15/15] fs/f2fs/dir.c:339:1: warning: label 'start_find_entry' defined but not used

2024-12-20 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test head: 3f1a145b84bcf0fae986212590bfeeaf165d22d6 commit: 3f1a145b84bcf0fae986212590bfeeaf165d22d6 [15/15] f2fs: Introduce linear search for dentries config: arc-randconfig-001-20241220 (https://download.01.org

[f2fs-dev] On FI_INLINE_XATTR vs. FI_EXTRA_ATTR

2024-12-20 Thread Dmitry Antipov
Does FI_INLINE_XATTR always assume FI_EXTRA_ATTR? Looking through the code, it's not quite clear (at a first glance at least). If this is not so, I have a strong suspicion that FI_INLINE_XATTR-related checks in sanity_check_inode() should be moved to outer scope (outside of FI_EXTRA_ATTR check), i

Re: [f2fs-dev] [PATCH] f2fs: Introduce linear search for dentries

2024-12-20 Thread Chao Yu via Linux-f2fs-devel
On 2024/12/20 12:59, Daniel Lee wrote: On Thu, Dec 19, 2024 at 5:29 AM Chao Yu wrote: Hi Daniel, On 2024/12/17 15:55, Daniel Lee wrote: This patch addresses an issue where some files in case-insensitive directories become inaccessible due to changes in how the kernel function, utf8_casefold(

[f2fs-dev] [jaegeuk-f2fs:dev-test 15/15] fs/f2fs/dir.c:339:1: warning: unused label 'start_find_entry'

2024-12-20 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test head: 3f1a145b84bcf0fae986212590bfeeaf165d22d6 commit: 3f1a145b84bcf0fae986212590bfeeaf165d22d6 [15/15] f2fs: Introduce linear search for dentries config: riscv-randconfig-002-20241220 (https://download.01.org