[f2fs-dev] [PATCH] fsck.f2fs: honor --linear-lookup=X for Android case

2025-07-24 Thread Chao Yu via Linux-f2fs-devel
Behavior summary: Android Distro By default disabledenabled Android case: 1) enabled -> disabled - mkfs.f2fs -f -g android -O casefold -C utf8:nohashonly /dev/vdb - dump.f2fs -d3 /dev/vdb |grep s_encoding_flags s_encoding_flags

[f2fs-dev] [PATCH v3] mkfs.f2fs: support -C [no]hashonly to control linear lookup fallback

2025-07-24 Thread Chao Yu via Linux-f2fs-devel
It provides a way to disable linear lookup fallback during mkfs. Behavior summary: Android Distro By default disabledenabled Android case: 1.1) Disable linear lookup: - mkfs.f2fs -f -g android -O casefold -C utf8:hashonly /dev/vdb - dump.f2fs

Re: [f2fs-dev] [PATCH v2] mkfs.f2fs: support -C [no]hashonly to control linear lookup fallback

2025-07-24 Thread Zhiguo Niu
Chao Yu 于2025年7月25日周五 10:45写道: > > On 7/25/2025 10:08 AM, Zhiguo Niu wrote: > > Chao Yu via Linux-f2fs-devel > > 于2025年7月25日周五 09:03写道: > >> > >> It provides a way to disable linear lookup fallback during mkfs. > >> > >> Behavior summary: > >> Android Distro > >>

Re: [f2fs-dev] [PATCH v2] mkfs.f2fs: support -C [no]hashonly to control linear lookup fallback

2025-07-24 Thread Chao Yu via Linux-f2fs-devel
On 7/25/2025 10:08 AM, Zhiguo Niu wrote: Chao Yu via Linux-f2fs-devel 于2025年7月25日周五 09:03写道: It provides a way to disable linear lookup fallback during mkfs. Behavior summary: Android Distro By default disabledenabled Tune w/ [no]hashonly

Re: [f2fs-dev] [PATCH] f2fs: f2fs supports uncached buffered I/O

2025-07-24 Thread Chao Yu via Linux-f2fs-devel
On 7/25/2025 9:44 AM, hanqi wrote: 在 2025/7/24 21:09, Chao Yu 写道: On 2025/7/16 16:27, hanqi wrote: 在 2025/7/16 11:43, Jens Axboe 写道: On 7/15/25 9:34 PM, hanqi wrote: ? 2025/7/15 22:28, Jens Axboe ??: On 7/14/25 9:10 PM, Qi Han wrote: Jens has already completed the development of uncach

Re: [f2fs-dev] [PATCH v2 2/2] f2fs: directly add newly allocated pre-dirty nat entry to dirty set list

2025-07-24 Thread Chao Yu via Linux-f2fs-devel
On 7/25/2025 10:17 AM, wangzijie wrote: On 7/22/25 22:36, wangzijie wrote: When we need to alloc nat entry and set it dirty, we can directly add it to dirty set list(or initialize its list_head for new_ne) instead of adding it to clean list and make a move. Introduce init_dirty flag to do it. S

Re: [f2fs-dev] [PATCH] f2fs: add error checking in do_write_page()

2025-07-24 Thread Chao Yu via Linux-f2fs-devel
On 7/24/2025 11:59 PM, mason.zhang wrote: Otherwise, the filesystem may unaware of potential file corruption. Signed-off-by: mason.zhang --- fs/f2fs/segment.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index ae1223ef648f..

Re: [f2fs-dev] [PATCH v2 2/2] f2fs: directly add newly allocated pre-dirty nat entry to dirty set list

2025-07-24 Thread wangzijie
> On 7/22/25 22:36, wangzijie wrote: > > When we need to alloc nat entry and set it dirty, we can directly add it to > > dirty set list(or initialize its list_head for new_ne) instead of adding it > > to clean list and make a move. Introduce init_dirty flag to do it. > > > > Signed-off-by: wangzij

Re: [f2fs-dev] [PATCH v2] mkfs.f2fs: support -C [no]hashonly to control linear lookup fallback

2025-07-24 Thread Zhiguo Niu
Chao Yu via Linux-f2fs-devel 于2025年7月25日周五 09:03写道: > > It provides a way to disable linear lookup fallback during mkfs. > > Behavior summary: > Android Distro > By default disabledenabled > Tune w/ [no]hashonlyno yes > > Androi

Re: [f2fs-dev] [PATCH] f2fs: f2fs supports uncached buffered I/O

2025-07-24 Thread hanqi via Linux-f2fs-devel
在 2025/7/24 21:09, Chao Yu 写道: On 2025/7/16 16:27, hanqi wrote: 在 2025/7/16 11:43, Jens Axboe 写道: On 7/15/25 9:34 PM, hanqi wrote: ? 2025/7/15 22:28, Jens Axboe ??: On 7/14/25 9:10 PM, Qi Han wrote: Jens has already completed the development of uncached buffered I/O in git [1], and in f

[f2fs-dev] [PATCH v2] mkfs.f2fs: support -C [no]hashonly to control linear lookup fallback

2025-07-24 Thread Chao Yu via Linux-f2fs-devel
It provides a way to disable linear lookup fallback during mkfs. Behavior summary: Android Distro By default disabledenabled Tune w/ [no]hashonlyno yes Android case: 1.1) Disable linear lookup: mkfs.f2fs -f -g android -O casef

[f2fs-dev] [PATCH] mkfs.f2fs: Fix zoned alignment check for multi-device setups

2025-07-24 Thread Daniel Lee via Linux-f2fs-devel
Commit 84447ee7212e correctly relocated the zone alignment check to its proper location. However, this revealed that the original check's condition was incorrect for multi-device setups. This patch corrects the logic to check the alignment relative to the start of the segment0 and improves the err

Re: [f2fs-dev] [PATCH] f2fs: remove unnecessary tracepoint enabled check

2025-07-24 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Wed, 23 Jul 2025 22:24:56 +0800 you wrote: > From: Sheng Yong > > There is no extra work before trace_f2fs_[dataread|datawrite]_end(), > so there is no need to check trace__enabled(). > > Signed-off-by: Sheng Yong >

[f2fs-dev] Patchwork summary for: f2fs

2025-07-24 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: The following patches were marked "accepted", because they were applied to jaegeuk/f2fs.git (dev): Patch: [f2fs-dev] f2fs: remove unnecessary tracepoint enabled check Submitter: Sheng Yong Committer: Jaegeuk Kim Patchwork: https://patchwork.kernel.org/project/f2fs/list/?series=9851

Re: [f2fs-dev] [PATCH v2] f2fs: vm_unmap_ram() may be called from an invalid context

2025-07-24 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Thu, 24 Jul 2025 17:31:15 +0200 you wrote: > When testing F2FS with xfstests using UFS backed virtual disks the > kernel complains sometimes that f2fs_release_decomp_mem() calls > vm_unmap_ram() from an invalid context. E

Re: [f2fs-dev] [PATCH v3] f2fs: zone: wait for inflight dio completion, excluding pinned files read using dio

2025-07-24 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Tue, 22 Jul 2025 15:02:40 +0900 you wrote: > read for the pinfile using Direct I/O do not wait for dio write. > > Signed-off-by: yohan.joung > --- > fs/f2fs/file.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 del

Re: [f2fs-dev] [PATCH] f2fs: don't break allocation when crossing contiguous sections

2025-07-24 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Mon, 21 Jul 2025 10:02:31 +0800 you wrote: > Commit 0638a3197c19 ("f2fs: avoid unused block when dio write in LFS > mode") has fixed unused block issue for dio write in lfs mode. > > However, f2fs_map_blocks() may break

Re: [f2fs-dev] [PATCH] f2fs: ignore valid ratio when free section count is low

2025-07-24 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Fri, 18 Jul 2025 15:04:31 -0700 you wrote: > From: Daeho Jeong > > Otherwise F2FS will not do GC in background in low free section. > > Signed-off-by: Daeho Jeong > --- > fs/f2fs/gc.c | 18 -- > 1 fil

Re: [f2fs-dev] [PATCH] f2fs: merge the two conditions to avoid code duplication

2025-07-24 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Wed, 23 Jul 2025 22:58:37 +0800 you wrote: > No functional changes. > > Signed-off-by: mason.zhang > --- > fs/f2fs/gc.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) Here is the summary with links: -

[f2fs-dev] [PATCH] f2fs: add error checking in do_write_page()

2025-07-24 Thread mason.zhang
Otherwise, the filesystem may unaware of potential file corruption. Signed-off-by: mason.zhang --- fs/f2fs/segment.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index ae1223ef648f..ce80ba226aed 100644 --- a/fs/f2fs/segment.c ++

Re: [f2fs-dev] [PATCH] mkfs.f2fs: support -C [no]hashonly to control linear lookup fallback

2025-07-24 Thread Chao Yu via Linux-f2fs-devel
On 7/24/2025 11:06 PM, Jaegeuk Kim wrote: Can we disable linear lookup by default, but add an option to enable it? Sure. On 07/24, Chao Yu wrote: It provides a way to disable linear lookup fallback during mkfs. Usage: 1. Disable linear lookup: mkfs.f2fs -f -O casefold -C utf8:hashonly /de

[f2fs-dev] [PATCH v2] f2fs: vm_unmap_ram() may be called from an invalid context

2025-07-24 Thread Jan Prusakowski via Linux-f2fs-devel
When testing F2FS with xfstests using UFS backed virtual disks the kernel complains sometimes that f2fs_release_decomp_mem() calls vm_unmap_ram() from an invalid context. Example trace from f2fs/007 test: f2fs/007 5s ... [12:59:38][8.902525] run fstests f2fs/007 [ 11.468026] BUG: sleeping f

Re: [f2fs-dev] [PATCH] mkfs.f2fs: support -C [no]hashonly to control linear lookup fallback

2025-07-24 Thread Jaegeuk Kim via Linux-f2fs-devel
Can we disable linear lookup by default, but add an option to enable it? On 07/24, Chao Yu wrote: > It provides a way to disable linear lookup fallback during mkfs. > > Usage: > > 1. Disable linear lookup: > mkfs.f2fs -f -O casefold -C utf8:hashonly /dev/vdb > dump.f2fs -d3 /dev/vdb |grep s_enco

Re: [f2fs-dev] [PATCH] f2fs: f2fs supports uncached buffered I/O

2025-07-24 Thread Chao Yu via Linux-f2fs-devel
On 2025/7/16 16:27, hanqi wrote: 在 2025/7/16 11:43, Jens Axboe 写道: On 7/15/25 9:34 PM, hanqi wrote: ? 2025/7/15 22:28, Jens Axboe ??: On 7/14/25 9:10 PM, Qi Han wrote: Jens has already completed the development of uncached buffered I/O in git [1], and in f2fs, the feature can be enabled si

Re: [f2fs-dev] [PATCH] f2fs: vm_unmap_ram() may be called from an invalid context

2025-07-24 Thread Chao Yu via Linux-f2fs-devel
Jan, On 2025/7/24 18:30, Jan Prusakowski via Linux-f2fs-devel wrote: When testing F2FS with xfstests using UFS backed virtual disks the kernel complains sometimes that f2fs_release_decomp_mem() calls vm_unmap_ram() from an invalid context. It will be better to include testcase & crash informat

[f2fs-dev] [PATCH] f2fs: vm_unmap_ram() may be called from an invalid context

2025-07-24 Thread Jan Prusakowski via Linux-f2fs-devel
When testing F2FS with xfstests using UFS backed virtual disks the kernel complains sometimes that f2fs_release_decomp_mem() calls vm_unmap_ram() from an invalid context. This patch modifies in_task() check inside f2fs_read_end_io() to also check if interrupts are disabled. This ensures that pages

Re: [f2fs-dev] [STABLE 5.15+] f2fs: sysfs: add encoding_flags entry

2025-07-24 Thread Lee Jones via Linux-f2fs-devel
On Wed, 23 Jul 2025, Greg Kroah-Hartman wrote: > On Wed, Jul 23, 2025 at 09:26:39AM +0100, Lee Jones wrote: > > On Wed, 02 Jul 2025, Greg Kroah-Hartman wrote: > > > > > On Tue, Jun 24, 2025 at 11:00:39AM +0100, Lee Jones wrote: > > > > On Wed, 16 Apr 2025, Chao Yu wrote: > > > > > > > > > This p

Re: [f2fs-dev] [PATCH v2 2/2] f2fs: directly add newly allocated pre-dirty nat entry to dirty set list

2025-07-24 Thread Chao Yu via Linux-f2fs-devel
On 7/22/25 22:36, wangzijie wrote: > When we need to alloc nat entry and set it dirty, we can directly add it to > dirty set list(or initialize its list_head for new_ne) instead of adding it > to clean list and make a move. Introduce init_dirty flag to do it. > > Signed-off-by: wangzijie > --- >

[f2fs-dev] [PATCH 3/3] f2fs: fix to trigger foreground gc during f2fs_map_blocks() in lfs mode

2025-07-24 Thread Chao Yu via Linux-f2fs-devel
w/ "mode=lfs" mount option, generic/299 will cause system panic as below: [ cut here ] kernel BUG at fs/f2fs/segment.c:2835! Call Trace: f2fs_allocate_data_block+0x6f4/0xc50 f2fs_map_blocks+0x970/0x1550 f2fs_iomap_begin+0xb2/0x1e0 iomap_iter+0x1d6/0x430 __iomap_dio_r

[f2fs-dev] [PATCH 2/3] f2fs: fix to calculate dirty data during has_not_enough_free_secs()

2025-07-24 Thread Chao Yu via Linux-f2fs-devel
In lfs mode, dirty data needs OPU, we'd better calculate lower_p and upper_p w/ them during has_not_enough_free_secs(), otherwise we may encounter out-of-space issue due to we missed to reclaim enough free section w/ foreground gc. Fixes: 36abef4e796d ("f2fs: introduce mode=lfs mount option") Cc:

[f2fs-dev] [PATCH 1/3] f2fs: fix to update upper_p in __get_secs_required() correctly

2025-07-24 Thread Chao Yu via Linux-f2fs-devel
Commit 1acd73edbbfe ("f2fs: fix to account dirty data in __get_secs_required()") missed to calculate upper_p w/ data_secs, fix it. Fixes: 1acd73edbbfe ("f2fs: fix to account dirty data in __get_secs_required()") Cc: Daeho Jeong Signed-off-by: Chao Yu --- fs/f2fs/segment.h | 2 +- 1 file changed