[f2fs-dev] [PATCH] f2fs: fix condition in __allow_reserved_blocks()

2025-07-30 Thread Chao Yu via Linux-f2fs-devel
If reserve_root mount option is not assigned, __allow_reserved_blocks() will return false, it's not correct, fix it. Fixes: 7e65be49ed94 ("f2fs: add reserved blocks for root user") Signed-off-by: Chao Yu --- fs/f2fs/f2fs.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs

[f2fs-dev] [PATCH 1/2] f2fs: dump more information when checkpoint was blocked for long time

2025-07-30 Thread Chao Yu via Linux-f2fs-devel
generic/299 w/ mode=lfs will cause long time latency of checkpoint, let's dump more information once we hit case. CP merge: - Queued :0 - Issued :1 - Total :1 - Cur time : 9765(ms) - Peak time : 9765(ms) F2FS-fs (vdc): blocked on checkpoint for 9765 ms CPU: 11 UID: 0 PID: 23

[f2fs-dev] [PATCH 2/2] f2fs: add time stats of checkpoint for debug

2025-07-30 Thread Chao Yu via Linux-f2fs-devel
checkpoint was blocked for 18643 ms Step 0: 0 ms Step 1: 38 ms Step 2: 63 ms Step 3: 4 ms Step 4: 0 ms Step 5: 0 ms Step 6: 9 ms Step 7: 0 ms Step 8: 18277 ms Step 9: 249 ms Cc: Jan Prusakowski Signed-off-by: Chao Yu --- fs/f2fs/checkpoint.c | 46 fs

Re: [f2fs-dev] [PATCH v3] f2fs: add reserved nodes for privileged users

2025-07-30 Thread Chao Yu via Linux-f2fs-devel
On 7/30/25 22:15, Chunhai Guo wrote: > This patch allows privileged users to reserve nodes via the > 'reserve_node' mount option, which is similar to the existing > 'reserve_root' option. > > "-o reserve_node=" means nodes are reserved for privileged > users only. > > Signed-off-by: Chunhai Guo

Re: [f2fs-dev] [PATCH v2] f2fs: add error checking in do_write_page()

2025-07-30 Thread Chao Yu via Linux-f2fs-devel
On 7/30/25 18:06, mason.zhang wrote: > Otherwise, the filesystem may unaware of potential file corruption. > > Signed-off-by: mason.zhang > --- > fs/f2fs/segment.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index ae1

Re: [f2fs-dev] [PATCH] f2fs: f2fs supports uncached buffered I/O read

2025-07-30 Thread Chao Yu via Linux-f2fs-devel
On 7/30/25 23:20, Jens Axboe wrote: > On 7/28/25 2:28 AM, hanqi wrote: >> ? 2025/7/28 16:07, Chao Yu ??: >>> On 7/28/25 16:03, hanqi wrote: ? 2025/7/28 15:38, Chao Yu ??: > On 7/25/25 15:53, Qi Han wrote: >> Jens has already completed the development of uncached buffered I/O >

Re: [f2fs-dev] [PATCH] f2fs: f2fs supports uncached buffered I/O read

2025-07-30 Thread Jens Axboe
On 7/30/25 7:58 PM, hanqi wrote: > > ? 2025/7/30 23:20, Jens Axboe ??: >> On 7/28/25 2:28 AM, hanqi wrote: >>> ? 2025/7/28 16:07, Chao Yu ??: On 7/28/25 16:03, hanqi wrote: > ? 2025/7/28 15:38, Chao Yu ??: > >> On 7/25/25 15:53, Qi Han wrote: >>> Jens has already completed the

Re: [f2fs-dev] [PATCH] f2fs: f2fs supports uncached buffered I/O read

2025-07-30 Thread hanqi via Linux-f2fs-devel
在 2025/7/30 23:20, Jens Axboe 写道: On 7/28/25 2:28 AM, hanqi wrote: ? 2025/7/28 16:07, Chao Yu ??: On 7/28/25 16:03, hanqi wrote: ? 2025/7/28 15:38, Chao Yu ??: On 7/25/25 15:53, Qi Han wrote: Jens has already completed the development of uncached buffered I/O in git [1], and in f2fs, uncac

[f2fs-dev] Patchwork summary for: f2fs

2025-07-30 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: The following patches were marked "accepted", because they were applied to jaegeuk/f2fs.git (dev): Patch: [f2fs-dev] f2fs: drop inode from the donation list when the last file is closed Submitter: Jaegeuk Kim Committer: Jaegeuk Kim Patchwork: https://patchwork.kernel.org/project/f

Re: [f2fs-dev] [PATCH] f2fs: drop inode from the donation list when the last file is closed

2025-07-30 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Tue, 29 Jul 2025 20:47:19 + you wrote: > Let's drop the inode from the donation list when there is no other > open file. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/f2fs.h | 2 ++ > fs/f2fs/file.c | 8 +++-

[f2fs-dev] [PATCH v3] f2fs: add reserved nodes for privileged users

2025-07-30 Thread Chunhai Guo via Linux-f2fs-devel
This patch allows privileged users to reserve nodes via the 'reserve_node' mount option, which is similar to the existing 'reserve_root' option. "-o reserve_node=" means nodes are reserved for privileged users only. Signed-off-by: Chunhai Guo --- v2->v3: Apply Chao's suggestion from v2. v1->v2:

Re: [f2fs-dev] [PATCH] f2fs: f2fs supports uncached buffered I/O read

2025-07-30 Thread Jens Axboe
On 7/28/25 2:28 AM, hanqi wrote: > ? 2025/7/28 16:07, Chao Yu ??: >> On 7/28/25 16:03, hanqi wrote: >>> ? 2025/7/28 15:38, Chao Yu ??: >>> On 7/25/25 15:53, Qi Han wrote: > Jens has already completed the development of uncached buffered I/O > in git [1], and in f2fs, uncached buffered

[f2fs-dev] [PATCH v2] f2fs: add error checking in do_write_page()

2025-07-30 Thread mason.zhang
Otherwise, the filesystem may unaware of potential file corruption. Signed-off-by: mason.zhang --- fs/f2fs/segment.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index ae1223ef648f..10aaa32defca 100644 --- a/fs/f2fs/segment.c

Re: [f2fs-dev] [PATCH v2] f2fs: add reserved nodes for privileged users

2025-07-30 Thread Chunhai Guo via Linux-f2fs-devel
在 7/30/2025 3:23 PM, Chao Yu 写道: > On 2025/7/30 10:42, Chunhai Guo wrote: >> This patch allows privileged users to reserve nodes via the >> 'reserve_node' mount option, which is similar to the existing >> 'reserve_root' option. >> >> "-o reserve_node=" means nodes are reserved for privileged >> us

Re: [f2fs-dev] [PATCH] f2fs: dump more information when checkpoint was blocked for long time

2025-07-30 Thread Chao Yu via Linux-f2fs-devel
On 7/29/25 23:07, Jaegeuk Kim wrote: > On 07/29, Chao Yu wrote: >> generic/299 w/ mode=lfs will cause long time latency, let's dump more >> information once we hit case. >> >> CP merge: >> - Queued :0 >> - Issued :1 >> - Total :1 >> - Cur time : 7565(ms) >> - Peak time : 7565(

Re: [f2fs-dev] [PATCH] f2fs: f2fs supports uncached buffered I/O read

2025-07-30 Thread Chao Yu via Linux-f2fs-devel
On 7/25/25 15:53, Qi Han wrote: > Jens has already completed the development of uncached buffered I/O > in git [1], and in f2fs, uncached buffered I/O read can be enabled > simply by setting the FOP_DONTCACHE flag in f2fs_file_operations. > > I have been testing a use case locally, which aligns wi

Re: [f2fs-dev] [PATCH] f2fs: dump more information when checkpoint was blocked for long time

2025-07-30 Thread Chao Yu via Linux-f2fs-devel
On 7/29/25 23:07, Jaegeuk Kim wrote: > On 07/29, Chao Yu wrote: >> generic/299 w/ mode=lfs will cause long time latency, let's dump more >> information once we hit case. >> >> CP merge: >> - Queued :0 >> - Issued :1 >> - Total :1 >> - Cur time : 7565(ms) >> - Peak time : 7565(

Re: [f2fs-dev] [PATCH] f2fs: drop inode from the donation list when the last file is closed

2025-07-30 Thread Chao Yu via Linux-f2fs-devel
On 7/30/25 04:47, Jaegeuk Kim via Linux-f2fs-devel wrote: > Let's drop the inode from the donation list when there is no other > open file. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-dev

Re: [f2fs-dev] [PATCH] f2fs: don't break allocation when crossing contiguous sections

2025-07-30 Thread Chao Yu via Linux-f2fs-devel
Hi Daejun Thanks for the comments. On 7/30/25 09:53, Daejun Park wrote: > Hi Chao Yu, > >> +        lfs_dio_write = (flag == F2FS_GET_BLOCK_DIO && f2fs_lfs_mode(sbi) && >> +                                map->m_may_create); >> + > > Consider moving the lfs_dio_write assignment to just after th

Re: [f2fs-dev] [PATCH 1/1] f2fs-tools: increase overprovision finding speed

2025-07-30 Thread Chao Yu via Linux-f2fs-devel
On 5/16/25 19:10, Cherniaev Andrei wrote: > I think my optimization makes mkfs.f2fs faster in case of invalid volume > size. So with the commit user will get err faster. > Before start I suggest add debug printf() to `f2fs_fs.h` like this: > ``` > for (; candidate <= end; candidate += diff) { >

Re: [f2fs-dev] [PATCH v2] f2fs: add reserved nodes for privileged users

2025-07-30 Thread Chao Yu via Linux-f2fs-devel
On 2025/7/30 10:42, Chunhai Guo wrote: > This patch allows privileged users to reserve nodes via the > 'reserve_node' mount option, which is similar to the existing > 'reserve_root' option. > > "-o reserve_node=" means nodes are reserved for privileged > users only. > > Signed-off-by: Chunhai Gu