Re: [f2fs-dev] [PATCH v3] f2fs: introduce flush_policy sysfs entry

2025-08-11 Thread Chao Yu via Linux-f2fs-devel
On 8/11/25 21:44, Bart Van Assche wrote: > On 8/11/25 3:52 AM, Christoph Hellwig wrote: >> On Thu, Aug 07, 2025 at 11:48:38AM +0800, Chao Yu wrote: >>> This patch introduces a new sysfs entry /sys/fs/f2fs//flush_policy >>> in order to tune performance of f2fs data flush flow. >>> >>> For example, c

Re: [f2fs-dev] [PATCH v3] f2fs: introduce flush_policy sysfs entry

2025-08-11 Thread Chao Yu via Linux-f2fs-devel
On 8/11/25 18:52, Christoph Hellwig wrote: > On Thu, Aug 07, 2025 at 11:48:38AM +0800, Chao Yu wrote: >> This patch introduces a new sysfs entry /sys/fs/f2fs//flush_policy >> in order to tune performance of f2fs data flush flow. >> >> For example, checkpoint will use REQ_FUA to persist CP metadata,

Re: [f2fs-dev] [PATCH v5 00/13] Move fscrypt and fsverity info out of struct inode

2025-08-11 Thread Eric Biggers via Linux-f2fs-devel
On Mon, Aug 11, 2025 at 03:34:35PM +0200, Christian Brauner wrote: > On Mon, Aug 11, 2025 at 03:17:01PM +0200, Christian Brauner wrote: > > On Sun, Aug 10, 2025 at 02:03:02AM -0700, Eric Biggers wrote: > > > On Sun, Aug 10, 2025 at 10:47:32AM +0200, Christian Brauner wrote: > > > > On Sun, Aug 10,

Re: [f2fs-dev] [PATCH v5 00/13] Move fscrypt and fsverity info out of struct inode

2025-08-11 Thread Christian Brauner via Linux-f2fs-devel
> The fs-specific field solution from this patchset is much more efficient > than the rhashtable: efficient enough that we don't really have to worry > about it, regardless of fscrypt or fsverity. So I think it's a good > middle ground, and I'd like to just do it this way. I agree.

Re: [f2fs-dev] [PATCH v3] f2fs: introduce flush_policy sysfs entry

2025-08-11 Thread Bart Van Assche via Linux-f2fs-devel
On 8/11/25 3:52 AM, Christoph Hellwig wrote: On Thu, Aug 07, 2025 at 11:48:38AM +0800, Chao Yu wrote: This patch introduces a new sysfs entry /sys/fs/f2fs//flush_policy in order to tune performance of f2fs data flush flow. For example, checkpoint will use REQ_FUA to persist CP metadata, however

Re: [f2fs-dev] [PATCH v5 00/13] Move fscrypt and fsverity info out of struct inode

2025-08-11 Thread Christian Brauner via Linux-f2fs-devel
On Mon, Aug 11, 2025 at 03:17:01PM +0200, Christian Brauner wrote: > On Sun, Aug 10, 2025 at 02:03:02AM -0700, Eric Biggers wrote: > > On Sun, Aug 10, 2025 at 10:47:32AM +0200, Christian Brauner wrote: > > > On Sun, Aug 10, 2025 at 12:56:53AM -0700, Eric Biggers wrote: > > > > This is a cleaned-up

Re: [f2fs-dev] [PATCH v5 00/13] Move fscrypt and fsverity info out of struct inode

2025-08-11 Thread Christian Brauner via Linux-f2fs-devel
On Sun, Aug 10, 2025 at 02:03:02AM -0700, Eric Biggers wrote: > On Sun, Aug 10, 2025 at 10:47:32AM +0200, Christian Brauner wrote: > > On Sun, Aug 10, 2025 at 12:56:53AM -0700, Eric Biggers wrote: > > > This is a cleaned-up implementation of moving the i_crypt_info and > > > i_verity_info pointers

Re: [f2fs-dev] [syzbot] [f2fs?] kernel BUG in f2fs_write_end_io

2025-08-11 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer is still triggering an issue: kernel BUG in f2fs_write_end_io F2FS-fs (loop3): inconsistent node block, node_type:0, nid:11, node_footer[nid:0,ino:0,ofs:0,cpver:0,blkaddr:0] [ cut here ] kernel BUG at fs/f2fs

[f2fs-dev] [PATCH] f2fs: clean up w/ get_left_section_blocks()

2025-08-11 Thread Chao Yu via Linux-f2fs-devel
Introduce get_left_section_blocks() for cleanup, no logic changes. Signed-off-by: Chao Yu --- fs/f2fs/segment.h | 28 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h index fdc2c34daa47..36427fdd6b15 100644 --- a/f

Re: [f2fs-dev] [PATCH] inject.f2fs: support inject inode.i_xattr_nid

2025-08-11 Thread Sheng Yong
On 8/11/25 17:47, Chao Yu via Linux-f2fs-devel wrote: Support to inject .i_xattr_nid on inode node. Cc: Sheng Yong Signed-off-by: Chao Yu It looks good to me. Thanks! Reviewed-by: Sheng Yong --- fsck/inject.c | 5 + man/inject.f2fs.8 | 3 +++ 2 files changed, 8 insertions(+)

Re: [f2fs-dev] [syzbot] [f2fs?] kernel BUG in f2fs_write_end_io

2025-08-11 Thread Chao Yu via Linux-f2fs-devel
#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git bugfix/common On 4/2/25 08:00, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:4e82c87058f4 Merge tag 'rust-6.15' of git://git.kernel.org.. > git tree: upstream > console output:

Re: [f2fs-dev] [syzbot] [f2fs?] kernel BUG in f2fs_write_end_io

2025-08-11 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer is still triggering an issue: INFO: task hung in f2fs_update_inode INFO: task syz.2.18:6729 blocked for more than 143 seconds. Not tainted 6.17.0-rc1-syzkaller-g5344e5bb8255 #0 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs"

Re: [f2fs-dev] [PATCH v5 09/13] ext4: move verity info pointer to fs-specific part of inode

2025-08-11 Thread Theodore Ts'o
On Sun, Aug 10, 2025 at 12:57:02AM -0700, Eric Biggers wrote: > Move the fsverity_info pointer into the filesystem-specific part of the > inode by adding the field ext4_inode_info::i_verity_info and configuring > fsverity_operations::inode_info_offs accordingly. > > This is a prerequisite for a la

Re: [f2fs-dev] [PATCH v5 03/13] ext4: move crypt info pointer to fs-specific part of inode

2025-08-11 Thread Theodore Ts'o
On Sun, Aug 10, 2025 at 12:56:56AM -0700, Eric Biggers wrote: > Move the fscrypt_inode_info pointer into the filesystem-specific part of > the inode by adding the field ext4_inode_info::i_crypt_info and > configuring fscrypt_operations::inode_info_offs accordingly. > > This is a prerequisite for a

Re: [f2fs-dev] [syzbot] [f2fs?] kernel BUG in f2fs_write_end_io

2025-08-11 Thread Chao Yu via Linux-f2fs-devel
#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git bugfix/common On 4/15/25 22:14, syzbot wrote: > syzbot has found a reproducer for the following issue on: > > HEAD commit:834a4a689699 Merge tag 'for-linus' of git://git.kernel.org.. > git tree: upstream > consol

Re: [f2fs-dev] [PATCH v3] f2fs: introduce flush_policy sysfs entry

2025-08-11 Thread Christoph Hellwig
On Thu, Aug 07, 2025 at 11:48:38AM +0800, Chao Yu wrote: > This patch introduces a new sysfs entry /sys/fs/f2fs//flush_policy > in order to tune performance of f2fs data flush flow. > > For example, checkpoint will use REQ_FUA to persist CP metadata, however, > some kind device has bad performance

Re: [f2fs-dev] [PATCH] fs: f2fs: end all corrupted fs writes with -EFSCORRUPTED

2025-08-11 Thread Chao Yu via Linux-f2fs-devel
Jaegeuk, I guess we need to drop this patch from dev-test, since xfstests may suffer hang issue w/ it. https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=fb7e51d19b3dc00bb8e3887399eb3e8f8aa1d078 Thanks, On 4/25/25 10:29, Chao Yu wrote: > On 4/24/25 00:15, Dmi

[f2fs-dev] [PATCH] inject.f2fs: support inject inode.i_xattr_nid

2025-08-11 Thread Chao Yu via Linux-f2fs-devel
Support to inject .i_xattr_nid on inode node. Cc: Sheng Yong Signed-off-by: Chao Yu --- fsck/inject.c | 5 + man/inject.f2fs.8 | 3 +++ 2 files changed, 8 insertions(+) diff --git a/fsck/inject.c b/fsck/inject.c index bd6ab84..b291d9d 100644 --- a/fsck/inject.c +++ b/fsck/inject.c @@ -

[f2fs-dev] [PATCH 1/3] f2fs/018: check data eof after partial truncation on compressed cluster

2025-08-11 Thread Chao Yu via Linux-f2fs-devel
This is a regression testcase, it is added to check below case and its variants: - write 16k data into compressed file (data will be compressed) - truncate file to 12k (truncate partial data in compressed cluster) - truncate file to 20k - verify data in range of [12k, 16k] to see whether data is al

[f2fs-dev] [PATCH 2/3] f2fs/019: do sanity check on mapping table

2025-08-11 Thread Chao Yu via Linux-f2fs-devel
This is a regression test: 1. create a file 2. write file to create a direct node at special offset 3. use inject.f2fs to inject nid of direct node w/ ino of the inode 4. check whether f2fs kernel module will detect and report such corruption in the fil Signed-off-by: Chao Yu --- tests/f2fs/0

[f2fs-dev] [PATCH 3/3] f2fs/020: do sanity check on i_xattr_nid

2025-08-11 Thread Chao Yu via Linux-f2fs-devel
This is a regression test: 1. create directory 2. add a new xattr entry to create xattr node 3. use inject.f2fs to inject nid of xattr node w/ ino in a file 4. check whether f2fs kernel module will detect and report such corruption in the file Signed-off-by: Chao Yu --- tests/f2fs/020 | 5