Re: [f2fs-dev] [PATCH v4 15/19] lib/crc32: make crc32c() go directly to lib

2025-10-18 Thread Askar Safin
Eric Biggers : > Now that the lower level __crc32c_le() library function is optimized for This patch (i. e. 38a9a5121c3b ("lib/crc32: make crc32c() go directly to lib")) solves actual bug I found in practice. So, please, backport it to stable kernels. I did bisect. It is possible to apply this p

Re: [f2fs-dev] [PATCH] f2fs: don't call iput() from f2fs_drop_inode()

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
On 10/1/2025 7:29 AM, Mateusz Guzik wrote: iput() calls the problematic routine, which does a ->i_count inc/dec cycle. Undoing it with iput() recurses into the problem. Note f2fs should not be playing games with the refcount to begin with, but that will be handled later. Right now solve the imme

[f2fs-dev] [syzbot] [f2fs?] WARNING in f2fs_delete_entry (2)

2025-10-18 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:2213e57a69f0 Merge branch 'for-next/core' into for-kernelci git tree: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci console output: https://syzkaller.appspot.com/x/log.txt?x=12a822e258 kernel confi

Re: [f2fs-dev] [PATCH] f2fs: Use mapping->gfp_mask to get file cache for writing

2025-10-18 Thread Jiucheng Xu via Linux-f2fs-devel
On 9/24/2025 10:25 AM, Chao Yu wrote: [ EXTERNAL EMAIL ] On 9/18/25 11:32, Jiucheng Xu via B4 Relay wrote: From: Jiucheng Xu On 32-bit architectures, when GFP_NOFS is used, the file cache for write operations cannot be allocated from the highmem and CMA. Hi, Have you suffered any proble

[f2fs-dev] [linus:master] [fs] bc986b1d75: Kernel_panic-not_syncing:softlockup:hung_tasks

2025-10-18 Thread kernel test robot
Hello, kernel test robot noticed "Kernel_panic-not_syncing:softlockup:hung_tasks" on: commit: bc986b1d756482a5ec2d7d9625229d9b9df95ae1 ("fs: stop accessing ->i_count directly in f2fs and gfs2") https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master in testcase: ltp version:

[f2fs-dev] [PATCH v2 02/16] writeback: add support to initialize and free multiple writeback ctxs

2025-10-18 Thread Kundan Kumar
Introduce a new macro for_each_bdi_wb_ctx to iterate over multiple writeback ctxs. Added logic for allocation, init, free, registration and unregistration of multiple writeback contexts within a bdi. Signed-off-by: Kundan Kumar Signed-off-by: Anuj Gupta --- include/linux/backing-dev.h | 4 ++

Re: [f2fs-dev] [PATCH] Documentation: f2fs: wrap tables in literal code blocks to fix LaTeX build

2025-10-18 Thread Masaharu Noguchi
Hello, Thank you for your detailed feedback regarding the f2fs.rst issue. I have tested the current mainline (without my patch) using Sphinx 8.3.0+ (commit ab8303f4bb13) and Docutils 0.21.2 on Python 3.13.7. The pdfdocs build now completes successfully, and the nested tables in f2fs.rst no longe

Re: [f2fs-dev] [PATCH kvm-next V11 6/7] KVM: guest_memfd: Enforce NUMA mempolicy using shared policy

2025-10-18 Thread Sean Christopherson via Linux-f2fs-devel
On Thu, Sep 25, 2025, Sean Christopherson wrote: > On Wed, Aug 27, 2025, Shivank Garg wrote: > > @@ -26,6 +28,9 @@ static inline struct kvm_gmem_inode_info > > *KVM_GMEM_I(struct inode *inode) > > return container_of(inode, struct kvm_gmem_inode_info, vfs_inode); > > } > > > > +static struc

Re: [f2fs-dev] [PATCH v2] f2fs: Use mapping->gfp_mask to get file cache for writing

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
On 10/10/25 18:45, Jiucheng Xu via B4 Relay wrote: > From: Jiucheng Xu > > On 32-bit architectures, when GFP_NOFS is used, the file cache for write > operations cannot be allocated from the highmem and CMA. > > Since mapping->gfp_mask is set to GFP_HIGHUSER_MOVABLE during inode > allocation, usi

[f2fs-dev] [PATCH v2 10/16] fuse: add support for multiple writeback contexts in fuse

2025-10-18 Thread Kundan Kumar
Made a helper to fetch writeback context to which an inode is affined. Use it to perform writeback related operations. Signed-off-by: Kundan Kumar Signed-off-by: Anuj Gupta --- fs/fuse/file.c | 7 +++ include/linux/backing-dev.h | 17 + 2 files changed, 20 inse

[f2fs-dev] [PATCH] f2fs: ensure node page reads complete before f2fs_put_super() finishes

2025-10-18 Thread Jan Prusakowski via Linux-f2fs-devel
Xfstests generic/335, generic/336 sometimes crash with the following message: F2FS-fs (dm-0): detect filesystem reference count leak during umount, type: 9, count: 1 [ cut here ] kernel BUG at fs/f2fs/super.c:1939! Oops: invalid opcode: [#1] SMP NOPTI CPU: 1 UID: 0 PI

Re: [f2fs-dev] [PATCH v2] fs: Make wbc_to_tag() inline and use it in fs.

2025-10-18 Thread Jan Kara
On Mon 29-09-25 19:13:49, Julian Sun wrote: > The logic in wbc_to_tag() is widely used in file systems, so modify this > function to be inline and use it in file systems. > > This patch has only passed compilation tests, but it should be fine. > > Signed-off-by: Julian Sun Looks good. Feel free

Re: [f2fs-dev] [PATCH] common/f2fs: introduce _require_inject_f2fs_command()

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
On 10/1/2025 2:24 PM, Zorro Lang wrote: On Mon, Sep 29, 2025 at 02:52:40AM +0800, Chao Yu wrote: Introduce _require_inject_f2fs_command() to check whether inject.f2fs supports specific metaarea and member parameters. Cc: Jaegeuk Kim Signed-off-by: Chao Yu --- common/f2fs| 25 +++

[f2fs-dev] [PATCH v2 09/16] f2fs: add support in f2fs to handle multiple writeback contexts

2025-10-18 Thread Kundan Kumar
Add support to handle multiple writeback contexts and check for dirty_exceeded across all the writeback contexts. Made a new helper for same. Signed-off-by: Kundan Kumar Signed-off-by: Anuj Gupta --- fs/f2fs/node.c | 4 ++-- fs/f2fs/segment.h | 2 +- include/linux/back

Re: [f2fs-dev] [PATCH] f2fs: Perform sanity check before unlinking directory inode

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
On 10/3/2025 9:47 PM, Nikola Z. Ivanov wrote: Current i_nlink corruption check does not take into account directory inodes which have one additional i_nlink for their "." entry. Add additional check and a common corruption path. Reported-by: [email protected]

[f2fs-dev] [PATCH] Documentation: f2fs: wrap tables in literal code blocks to fix LaTeX build

2025-10-18 Thread Masaharu Noguchi
Sphinx LaTeX builder fails with the following error: Markup is unsupported in LaTeX: filesystems/f2fs:: longtable does not support nesting a table. Wrap the ASCII tables in literal code blocks so that they are rendered as code instead of interpreted as tables. This fixes pdfdocs build failure

Re: [f2fs-dev] [PATCH 1/5] f2fs_io: measure a fsync latency

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
On 9/30/2025 10:37 AM, Jaegeuk Kim via Linux-f2fs-devel wrote: Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2f

[f2fs-dev] [Bug 220575] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000

2025-10-18 Thread bugzilla-daemon--- via Linux-f2fs-devel
https://bugzilla.kernel.org/show_bug.cgi?id=220575 --- Comment #13 from JY ([email protected]) --- Good news! Thank you :) -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. __

Re: [f2fs-dev] [PATCH 3/5] f2fs_io: add mlock to measure the read speed

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
On 9/30/2025 10:37 AM, Jaegeuk Kim via Linux-f2fs-devel wrote: Add missing mmap mode in man page. Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list [email protected] https://lists.sour

[f2fs-dev] [PATCH] f2fs: fix to avoid potential deadlock

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
As Jiaming Zhang and syzbot reported, there is potential deadlock in f2fs as below: Chain exists of: &sbi->cp_rwsem --> fs_reclaim --> sb_internal#2 Possible unsafe locking scenario: CPU0CPU1 rlock(sb_internal#2);

[f2fs-dev] [PATCH v2 12/16] nfs: add support in nfs to handle multiple writeback contexts

2025-10-18 Thread Kundan Kumar
Fetch writeback context to which an inode is affined. Use it to perform writeback related operations. Signed-off-by: Kundan Kumar Signed-off-by: Anuj Gupta --- fs/nfs/internal.h | 3 +-- fs/nfs/write.c| 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/nfs/internal.h

[f2fs-dev] [PATCH] f2fs: use folio_nr_pages() instead of shift operation

2025-10-18 Thread Pedro Demarchi Gomes
folio_nr_pages() is a faster helper function to get the number of pages when NR_PAGES_IN_LARGE_FOLIO is enabled. Signed-off-by: Pedro Demarchi Gomes --- fs/f2fs/f2fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 46be7560548c..4467a6e7

[f2fs-dev] [PATCH 3/3] common/f2fs: introduce _require_inject_f2fs_command()

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
Introduce _require_inject_f2fs_command() to check whether inject.f2fs supports specific metaarea and member parameters. Meanwhile, let's check inject.f2fs requirement inside _require_inject_f2fs_command() for cleanup. Cc: Jaegeuk Kim Signed-off-by: Chao Yu --- common/f2fs| 27 +

[f2fs-dev] [PATCH v2] fs: Make wbc_to_tag() inline and use it in fs.

2025-10-18 Thread Julian Sun via Linux-f2fs-devel
The logic in wbc_to_tag() is widely used in file systems, so modify this function to be inline and use it in file systems. This patch has only passed compilation tests, but it should be fine. Signed-off-by: Julian Sun --- fs/btrfs/extent_io.c | 5 + fs/ceph/addr.c| 6 +-

Re: [f2fs-dev] [BUG] f2fs: divide error in f2fs_all_cluster_page_ready on v6.17

2025-10-18 Thread Bai, Shuangpeng
> On Oct 14, 2025, at 02:18, Chao Yu wrote: > > On 10/14/25 01:56, Bai, Shuangpeng wrote: >> >> >>> On Oct 13, 2025, at 08:41, Chao Yu wrote: >>> >>> On 10/13/25 07:49, Bai, Shuangpeng wrote: Hi Kernel Maintainers, Our tool found a new kernel bug "divide error in f2fs_all_c

Re: [f2fs-dev] [PATCH] f2fs: fix wrong block mapping for multi-devices

2025-10-18 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Tue, 7 Oct 2025 03:53:43 + you wrote: > Assuming the disk layout as below, > > disk0: 0--- 0x00035abfff > disk1: 0x00035ac000 --- 0x00037abfff > disk2: 0x00037ac000 --- 0x00037ebfff > > and we want to r

Re: [f2fs-dev] [PATCH] f2fs/009: Add delay after killing socket tool

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
On 10/6/25 18:07, Jan Prusakowski wrote: > When running the test in a VM on a host with all CPUs busy, the kill command > returns before socket tool shuts down. This prevents unmounting the > scratch, causing the test to fail. > > The added sleep ensures that the socket tool closes before the next

[f2fs-dev] fsck service "Error: In use by the system!"

2025-10-18 Thread realroot via Linux-f2fs-devel
Hello, I am experiencing this bug https://gitlab.alpinelinux.org/alpine/aports/-/issues/17543. I wanted to try the latest commit but it will fail to compile. Gcc: make[3]: Entering directory '/.../f2fs-tools/src/3bd49149dae7237b931b09d87d00b2aef8f7af93/tools/f2fs_io'   CC       f2fs_io.o

Re: [f2fs-dev] [BUG] f2fs: divide error in f2fs_all_cluster_page_ready on v6.17

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
On 10/15/25 04:46, Bai, Shuangpeng wrote: > > >> On Oct 14, 2025, at 02:18, Chao Yu wrote: >> >> On 10/14/25 01:56, Bai, Shuangpeng wrote: >>> >>> On Oct 13, 2025, at 08:41, Chao Yu wrote: On 10/13/25 07:49, Bai, Shuangpeng wrote: > Hi Kernel Maintainers, > > Our tool

Re: [f2fs-dev] [PATCH v2 00/16] Parallelizing filesystem writeback

2025-10-18 Thread Andrew Morton
On Tue, 14 Oct 2025 17:38:29 +0530 Kundan Kumar wrote: > Currently, pagecache writeback is performed by a single thread. Inodes > are added to a dirty list, and delayed writeback is triggered. The single > writeback thread then iterates through the dirty inode list, and executes > the writeback.

Re: [f2fs-dev] [PATCH v4] f2fs: readahead node blocks in F2FS_GET_BLOCK_PRECACHE mode

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
On 9/24/25 15:43, Yunji Kang wrote: > In f2fs_precache_extents(), For large files, It requires reading many > node blocks. Instead of reading each node block with synchronous I/O, > this patch applies readahead so that node blocks can be fetched in > advance. > > It reduces the overhead of repeate

Re: [f2fs-dev] [PATCH] f2fs: fix wrong block mapping for multi-devices

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
On 10/7/2025 11:53 AM, Jaegeuk Kim via Linux-f2fs-devel wrote: Assuming the disk layout as below, disk0: 0--- 0x00035abfff disk1: 0x00035ac000 --- 0x00037abfff disk2: 0x00037ac000 --- 0x00037ebfff and we want to read data from offset=13568 having len=128 across the block devices, we

Re: [f2fs-dev] [PATCH] f2fs: fix ifolio memory leak in f2fs_move_inline_dirents error path

2025-10-18 Thread Haofeng Li via Linux-f2fs-devel
>Fixes a memory leak issue in f2fs_move_inline_dirents() where >the ifolio is not properly released in certain error paths. >Problem Analysis: >- In f2fs_try_convert_inline_dir(), ifolio is acquired via >f2fs_get_inode_folio() >- When do_convert_inline_dir() fails, the caller expects ifolio to be

Re: [f2fs-dev] [PATCH 5/5] f2fs_io: let's try to get contigous memory if possible

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
On 9/30/2025 10:37 AM, Jaegeuk Kim via Linux-f2fs-devel wrote: Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2f

Re: [f2fs-dev] [PATCH] f2fs: fix wrong layout information on 16KB page

2025-10-18 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Tue, 9 Sep 2025 00:27:17 + you wrote: > This patch fixes to support different block size. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/sysfs.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) He

[f2fs-dev] [PATCH v2 14/16] writeback: segregated allocation and free of writeback contexts

2025-10-18 Thread Kundan Kumar
The independent functions of alloc and free will be used while changing the number of writeback contexts. Signed-off-by: Kundan Kumar Signed-off-by: Anuj Gupta --- mm/backing-dev.c | 72 1 file changed, 49 insertions(+), 23 deletions(-) diff --g

[f2fs-dev] [PATCH v2] f2fs-tools: revert summary entry count from 2048 to 512 in 16kb block support

2025-10-18 Thread Daeho Jeong
From: Daeho Jeong The recent increase in the number of Segment Summary Area (SSA) entries from 512 to 2048 was an unintentional change in logic of 16kb block support. This commit corrects the issue. To better utilize the space available from the erroneous 2048-entry calculation, we are implement

[f2fs-dev] [PATCH v3 2/2] f2fs/022: do sanity check on footer of non inode dnode

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
This is a regression test: 1. create foo & bar 2. write 8M data to foo 3. use inject.f2fs to inject i_nid[0] of foo w/ ino of bar 4. fpunch in foo w/ specified range If we haven't applied kernel patch ("f2fs: fix to do sanity check on node footer for non inode dnode"), f2fs may missed to do sanity

Re: [f2fs-dev] [PATCH v4 00/13] f2fs-tools & inject.f2fs: bugfix and new injections

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
Hi Jaegeuk, Could you please consider merging this patchset? Some testcases may rely on these new injection functionality. On 8/25/25 09:54, Sheng Yong wrote: > Hi, all, > > Since we have not yet determined how to check the test result properly, > I split patchset v2 into two parts on Chao's su

Re: [f2fs-dev] [PATCH 2/5] f2fs_io: measure atomic operation latency with random write

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
On 9/30/2025 10:37 AM, Jaegeuk Kim via Linux-f2fs-devel wrote: If we give a negative offset, let's do random writes. f2fs_io write 1 -400 10 rand atomic_commit ./test conducts 10 random writes by picking addresses between 0 and 400 * 4KB. Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu

Re: [f2fs-dev] [PATCH] f2fs: set default valid_thresh_ratio to 80 for zoned devices

2025-10-18 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Tue, 7 Oct 2025 09:46:14 -0700 you wrote: > From: Daeho Jeong > > Zoned storage devices provide marginal over-capacity space, typically > around 10%, for filesystem level storage control. > > By utilizing this extra c

Re: [f2fs-dev] [PATCH v3] f2fs: readahead node blocks in F2FS_GET_BLOCK_PRECACHE mode

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
On 9/24/25 14:53, wangzijie wrote: >> On 9/24/25 13:58, Yunji Kang wrote: >>> In f2fs_precache_extents(), For large files, It requires reading many >>> node blocks. Instead of reading each node block with synchronous I/O, >>> this patch applies readahead so that node blocks can be fetched in >>> ad

[f2fs-dev] [PATCH v2 00/16] Parallelizing filesystem writeback

2025-10-18 Thread Kundan Kumar
Currently, pagecache writeback is performed by a single thread. Inodes are added to a dirty list, and delayed writeback is triggered. The single writeback thread then iterates through the dirty inode list, and executes the writeback. This series parallelizes the writeback by allowing multiple writ

Re: [f2fs-dev] [PATCH v3] common/encrypt: Explicitly set the test file to uncompressed

2025-10-18 Thread Eric Biggers via Linux-f2fs-devel
On Mon, Oct 06, 2025 at 11:58:13AM +0200, Jan Prusakowski wrote: > verify_ciphertext_for_encryption_policy() checks if encryption works > correctly by reading encrypted file's contents directly from a block device > and > comparing it to a known good ciphertext. > > This, however, won't work if t

Re: [f2fs-dev] [GIT PULL] f2fs fix for 6.18-rc2

2025-10-18 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This pull request was applied to jaegeuk/f2fs.git (dev) by Linus Torvalds : On Thu, 16 Oct 2025 17:39:39 + you wrote: > Hi Linus, > > Could you please consider this pull request? > > The following changes since commit 3a8660878839faadb4f1a6dd72c3179c1df56787: > > Linux 6.18-rc1 (2

[f2fs-dev] [PATCH 1/4] f2fs: clean up w/ bio_add_folio_nofail()

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
In add_bio_entry(), adding a page to newly allocated bio should never fail, let's use bio_add_folio_nofail() instead of bio_add_page() & unnecessary error handling for cleanup. Signed-off-by: Chao Yu --- fs/f2fs/data.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/fs

[f2fs-dev] [Bug 220575] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000

2025-10-18 Thread bugzilla-daemon--- via Linux-f2fs-devel
https://bugzilla.kernel.org/show_bug.cgi?id=220575 --- Comment #11 from Chao Yu ([email protected]) --- (In reply to JY from comment #8) > OK, I will try it. > > At the last experiment, I used the newly added '_private' to record non-null > value and dump it when fscrypt_is_bounce_page(page) is tru

Re: [f2fs-dev] [PATCH 1/2] f2fs: avoid unnecessary folio_clear_uptodate() for cleanup

2025-10-18 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Tue, 2 Sep 2025 20:27:19 +0800 you wrote: > In error path of __get_node_folio(), if the folio is not uptodate, let's > avoid unnecessary folio_clear_uptodate() for cleanup. > > Signed-off-by: Chao Yu > --- > fs/f2fs/

Re: [f2fs-dev] [PATCH] f2fs: Perform sanity check before unlinking directory inode

2025-10-18 Thread Nikola Z. Ivanov
On Thu, Oct 09, 2025 at 10:54:40AM +0800, Chao Yu wrote: > On 10/3/2025 9:47 PM, Nikola Z. Ivanov wrote: > > Current i_nlink corruption check does not take into account > > directory inodes which have one additional i_nlink for their "." entry. > > > > Add additional check and a common corruption

Re: [f2fs-dev] [PATCH] f2fs: revert summary entry count from 2048 to 512 in 16kb block support

2025-10-18 Thread kernel test robot
Hi Daeho, kernel test robot noticed the following build warnings: [auto build test WARNING on v6.17] [cannot apply to jaegeuk-f2fs/dev-test jaegeuk-f2fs/dev linus/master next-20251010] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest t

Re: [f2fs-dev] [PATCH kvm-next V11 4/7] KVM: guest_memfd: Use guest mem inodes instead of anonymous inodes

2025-10-18 Thread David Hildenbrand via Linux-f2fs-devel
On 25.09.25 13:44, Garg, Shivank wrote: On 9/25/2025 8:20 AM, Sean Christopherson wrote: My apologies for the super late feedback. None of this is critical (mechanical things that can be cleaned up after the fact), so if there's any urgency to getting this series into 6.18, just ignore it. O

Re: [f2fs-dev] [PATCH v2] f2fs: revert summary entry count from 2048 to 512 in 16kb block support

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
Daeho, I can not apply this patch to last dev-test branch, could you please rebase it? On 10/15/25 04:18, Daeho Jeong wrote: > From: Daeho Jeong > > The recent increase in the number of Segment Summary Area (SSA) entries > from 512 to 2048 was an unintentional change in logic of 16kb block > su

Re: [f2fs-dev] [PATCH] f2fs: maintain one time GC mode is enabled during whole zoned GC cycle

2025-10-18 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Fri, 3 Oct 2025 15:43:08 -0700 you wrote: > From: Daeho Jeong > > The current version missed setting one time GC for normal zoned GC > cycle. So, valid threshold control is not working. Need to fix it to > prevent exce

[f2fs-dev] [PATCH] fs: Make wbc_to_tag() extern and use it in fs.

2025-10-18 Thread Julian Sun via Linux-f2fs-devel
The logic in wbc_to_tag() is widely used in file systems, so modify this function to be extern and use it in file systems. This patch has only passed compilation tests, but it should be fine. Signed-off-by: Julian Sun --- fs/btrfs/extent_io.c | 5 + fs/ceph/addr.c| 6 +-

[f2fs-dev] [PATCH] common/f2fs: introduce _require_inject_f2fs_command()

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
Introduce _require_inject_f2fs_command() to check whether inject.f2fs supports specific metaarea and member parameters. Cc: Jaegeuk Kim Signed-off-by: Chao Yu --- common/f2fs| 25 + tests/f2fs/009 | 2 ++ tests/f2fs/012 | 2 ++ tests/f2fs/019 | 2 ++ tests/f2fs/02

Re: [f2fs-dev] [PATCH] fs: Make wbc_to_tag() extern and use it in fs.

2025-10-18 Thread Julian Sun
On Mon, Sep 29, 2025 at 6:16 PM Qu Wenruo wrote: > > > > 在 2025/9/29 19:25, Julian Sun 写道: > > The logic in wbc_to_tag() is widely used in file systems, so modify this > > function to be extern and use it in file systems. > > > > This patch has only passed compilation tests, but it should be fine.

[f2fs-dev] [PATCH v2 03/16] writeback: link bdi_writeback to its corresponding bdi_writeback_ctx

2025-10-18 Thread Kundan Kumar
Introduce a bdi_writeback_ctx field in bdi_writeback. This helps in fetching the writeback context from the bdi_writeback. Signed-off-by: Kundan Kumar Signed-off-by: Anuj Gupta --- mm/backing-dev.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/mm/backing-dev.

[f2fs-dev] [GIT PULL] f2fs fix for 6.18-rc2

2025-10-18 Thread Jaegeuk Kim via Linux-f2fs-devel
Hi Linus, Could you please consider this pull request? The following changes since commit 3a8660878839faadb4f1a6dd72c3179c1df56787: Linux 6.18-rc1 (2025-10-12 13:42:36 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git tags/f2fs-f

[f2fs-dev] Patchwork summary for: f2fs

2025-10-18 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: The following patches were marked "accepted", because they were applied to jaegeuk/f2fs.git (dev): Patch: [f2fs-dev] f2fs: fix to avoid migrating empty section Submitter: Chao Yu Committer: Jaegeuk Kim Patchwork: https://patchwork.kernel.org/project/f2fs/list/?series=997379 Lore

Re: [f2fs-dev] [PATCH v2 09/16] f2fs: add support in f2fs to handle multiple writeback contexts

2025-10-18 Thread Christoph Hellwig
On Tue, Oct 14, 2025 at 05:38:38PM +0530, Kundan Kumar wrote: > Add support to handle multiple writeback contexts and check for > dirty_exceeded across all the writeback contexts. As said last time, please do a preparation series with all these cleanups for file systems poking into writeback inter

Re: [f2fs-dev] [PATCH] fs: Make wbc_to_tag() extern and use it in fs.

2025-10-18 Thread Jan Kara
On Mon 29-09-25 17:55:44, Julian Sun wrote: > The logic in wbc_to_tag() is widely used in file systems, so modify this > function to be extern and use it in file systems. > > This patch has only passed compilation tests, but it should be fine. > > Signed-off-by: Julian Sun Yeah, good idea. Feel

[f2fs-dev] [PATCH v2 05/16] writeback: modify bdi_writeback search logic to search across all wb ctxs

2025-10-18 Thread Kundan Kumar
Since we have multiple cgwb per bdi, embedded in writeback_ctx now, we iterate over all of them to find the associated writeback. Signed-off-by: Kundan Kumar Signed-off-by: Anuj Gupta --- fs/fs-writeback.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/fs-writeb

Re: [f2fs-dev] [PATCH v2] f2fs: revert summary entry count from 2048 to 512 in 16kb block support

2025-10-18 Thread Daeho Jeong
On Wed, Oct 15, 2025 at 1:21 AM Chao Yu wrote: > > Daeho, > > I can not apply this patch to last dev-test branch, could you please > rebase it? Let me rebase it. > > On 10/15/25 04:18, Daeho Jeong wrote: > > From: Daeho Jeong > > > > The recent increase in the number of Segment Summary Area (SS

Re: [f2fs-dev] [PATCH kvm-next V11 0/7] Add NUMA mempolicy support for KVM guest-memfd

2025-10-18 Thread Sean Christopherson via Linux-f2fs-devel
On Wed, 27 Aug 2025 17:52:41 +, Shivank Garg wrote: > This series introduces NUMA-aware memory placement support for KVM guests > with guest_memfd memory backends. It builds upon Fuad Tabba's work (V17) > that enabled host-mapping for guest_memfd memory [1] and can be applied > directly applied

[f2fs-dev] [PATCH] f2fs: fix ifolio memory leak in f2fs_move_inline_dirents error path

2025-10-18 Thread Haofeng Li via Linux-f2fs-devel
From: Haofeng Li Fixes a memory leak issue in f2fs_move_inline_dirents() where the ifolio is not properly released in certain error paths. Problem Analysis: - In f2fs_try_convert_inline_dir(), ifolio is acquired via f2fs_get_inode_folio() - When do_convert_inline_dir() fails, the caller expects

[f2fs-dev] [PATCH 5/5] f2fs_io: let's try to get contigous memory if possible

2025-10-18 Thread Jaegeuk Kim via Linux-f2fs-devel
Signed-off-by: Jaegeuk Kim --- tools/f2fs_io/f2fs_io.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/f2fs_io/f2fs_io.c b/tools/f2fs_io/f2fs_io.c index 22f9968a35e9..d07e6c6b1bfe 100644 --- a/tools/f2fs_io/f2fs_io.c +++ b/tools/f2fs_io/f2fs_io.c @@ -101,6 +101,10 @@ static void *al

Re: [f2fs-dev] [PATCH] f2fs-tools: remove unnecessary alignment for blocks_for_ssa

2025-10-18 Thread Jaegeuk Kim via Linux-f2fs-devel
On 09/24, Daeho Jeong wrote: > From: Daeho Jeong > > total_valid_blks_available is already a multiple of c.blks_per_seg. > So, we don't need an additional alignment adjustment. Can we add ASSERT? > > Signed-off-by: Daeho Jeong > --- > mkfs/f2fs_format.c | 3 +-- > 1 file changed, 1 insertion

Re: [f2fs-dev] [PATCH kvm-next V11 6/7] KVM: guest_memfd: Enforce NUMA mempolicy using shared policy

2025-10-18 Thread Gregory Price
On Fri, Sep 26, 2025 at 12:36:27PM -0700, Sean Christopherson via Linux-f2fs-devel wrote: > > > > static struct mempolicy *kvm_gmem_get_policy(struct vm_area_struct *vma, > > unsigned long addr, pgoff_t *pgoff) > > { > > *pgoff = vma->vm_pgoff + ((addr

Re: [f2fs-dev] [PATCH 4/5] f2fs_io: add dontcache to measure RWF_DONTCACHE speed

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
On 9/30/2025 10:37 AM, Jaegeuk Kim via Linux-f2fs-devel wrote: It only measures the read performance. Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list [email protected] https://lists.

Re: [f2fs-dev] [PATCH] f2fs: maintain one time GC mode is enabled during whole zoned GC cycle

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
On 10/4/2025 6:43 AM, Daeho Jeong wrote: From: Daeho Jeong The current version missed setting one time GC for normal zoned GC cycle. So, valid threshold control is not working. Need to fix it to prevent excessive GC for zoned devices. Fixes: e791d00bd06c ("f2fs: add valid block ratio not to do

[f2fs-dev] [Bug 220575] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000

2025-10-18 Thread bugzilla-daemon--- via Linux-f2fs-devel
https://bugzilla.kernel.org/show_bug.cgi?id=220575 --- Comment #14 from JY ([email protected]) --- (In reply to Chao Yu from comment #12) > Hi JY, > > I've figured out a reproducer as below: > > 1. mkdir /mnt/f2fs/enc & encrypt /mnt/f2fs/enc > > 2. Run below script in shell #1: > for ((i=1;i>0

Re: [f2fs-dev] [PATCH kvm-next V11 6/7] KVM: guest_memfd: Enforce NUMA mempolicy using shared policy

2025-10-18 Thread Gregory Price
On Wed, Oct 15, 2025 at 03:48:38PM -0700, Sean Christopherson wrote: > On Wed, Oct 15, 2025, Gregory Price wrote: > > why is __kvm_gmem_get_policy using > > mpol_shared_policy_lookup() > > instead of > > get_vma_policy() > > With the disclaimer that I haven't followed the gory details of t

Re: [f2fs-dev] [PATCH kvm-next V11 4/7] KVM: guest_memfd: Use guest mem inodes instead of anonymous inodes

2025-10-18 Thread Sean Christopherson via Linux-f2fs-devel
On Thu, Sep 25, 2025, David Hildenbrand wrote: > On 25.09.25 15:41, Sean Christopherson wrote: > > Regarding timing, how much do people care about getting this into 6.18 in > > particular? > > I think it will be beneficial if we start getting stuff upstream. But > waiting a bit longer probably doe

Re: [f2fs-dev] [PATCH v2] f2fs: fix to update map->m_next_extent correctly in f2fs_map_blocks()

2025-10-18 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Fri, 12 Sep 2025 16:12:50 +0800 you wrote: > Script to reproduce: > mkfs.f2fs -O extra_attr,compression /dev/vdb -f > mount /dev/vdb /mnt/f2fs -o mode=lfs,noextent_cache > cd /mnt/f2fs > f2fs_io write 1 0 1024 rand dsync

Re: [f2fs-dev] [GIT PULL] f2fs for 6.18-rc1

2025-10-18 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This pull request was applied to jaegeuk/f2fs.git (dev) by Linus Torvalds : On Fri, 3 Oct 2025 17:56:27 + you wrote: > Hi Linus, > > Could you please consider this pull request? > > Thanks, > > The following changes since commit 8f5ae30d69d7543eee0d70083daf4de8fe15d585: > > [...]

Re: [f2fs-dev] [GIT PULL] f2fs fix for 6.18-rc2

2025-10-18 Thread pr-tracker-bot--- via Linux-f2fs-devel
The pull request you sent on Thu, 16 Oct 2025 17:39:39 +: > git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git > tags/f2fs-fix-6.18-rc2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/98ac9cc4b4452ed7e714eddc8c90ac4ae5da1a09 Thank you! -- Deet-doot-d

Re: [f2fs-dev] [PATCH kvm-next V11 6/7] KVM: guest_memfd: Enforce NUMA mempolicy using shared policy

2025-10-18 Thread Garg, Shivank via Linux-f2fs-devel
On 10/16/2025 4:18 AM, Sean Christopherson wrote: > On Wed, Oct 15, 2025, Gregory Price wrote: >> On Fri, Sep 26, 2025 at 12:36:27PM -0700, Sean Christopherson via >> Linux-f2fs-devel wrote: static struct mempolicy *kvm_gmem_get_policy(struct vm_area_struct *vma,

Re: [f2fs-dev] [PATCH v2] f2fs: fix to mitigate overhead of f2fs_zero_post_eof_page()

2025-10-18 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Tue, 16 Sep 2025 10:47:09 +0800 you wrote: > f2fs_zero_post_eof_page() may cuase more overhead due to invalidate_lock > and page lookup, change as below to mitigate its overhead: > - check new_size before grabbing invalid

[f2fs-dev] [PATCH 1/3] common/config: source common/f2fs in _source_specific_fs()

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
Let's source common/f2fs in _source_specific_fs() instead of in each testcase. Cc: Jaegeuk Kim Signed-off-by: Chao Yu --- common/config | 1 + tests/f2fs/002 | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/common/config b/common/config index 22b52432..1420e35d 100644 --- a/

Re: [f2fs-dev] [PATCH] fs: Make wbc_to_tag() extern and use it in fs.

2025-10-18 Thread kernel test robot
Hi Julian, kernel test robot noticed the following build errors: [auto build test ERROR on kdave/for-next] [also build test ERROR on ceph-client/testing ceph-client/for-linus tytso-ext4/dev jaegeuk-f2fs/dev-test jaegeuk-f2fs/dev gfs2/for-next akpm-mm/mm-everything linus/master v6.17 next-202509

[f2fs-dev] [Bug 220575] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000

2025-10-18 Thread bugzilla-daemon--- via Linux-f2fs-devel
https://bugzilla.kernel.org/show_bug.cgi?id=220575 --- Comment #16 from JY ([email protected]) --- (In reply to Chao Yu from comment #7) > Can you please hook fscrypt_free_bounce_page() to set page private w/ > special value, something as below: > > void fscrypt_free_bounce_page(struct page *bou

Re: [f2fs-dev] [PATCH] f2fs: Perform sanity check before unlinking directory inode

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
On 10/14/25 20:17, Nikola Z. Ivanov wrote: > On Mon, Oct 13, 2025 at 08:53:04PM +0800, Chao Yu wrote: >> On 10/13/25 05:19, Nikola Z. Ivanov wrote: >>> On Thu, Oct 09, 2025 at 10:54:40AM +0800, Chao Yu wrote: On 10/3/2025 9:47 PM, Nikola Z. Ivanov wrote: > Current i_nlink corruption check

[f2fs-dev] [PATCH] f2fs: use global inline_xattr_slab instead of per-sb slab cache

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
As Hong Yun reported in mailing list: loop7: detected capacity change from 0 to 131072 [ cut here ] kmem_cache of name 'f2fs_xattr_entry-7:7' already exists WARNING: CPU: 0 PID: 24426 at mm/slab_common.c:110 kmem_cache_sanity_check mm/slab_common.c:109 [inline] WARNING: CP

[f2fs-dev] [PATCH] f2fs: revert summary entry count from 2048 to 512 in 16kb block support

2025-10-18 Thread Daeho Jeong
From: Daeho Jeong The recent increase in the number of Segment Summary Area (SSA) entries from 512 to 2048 was an unintentional change in logic of 16kb block support. This commit corrects the issue. To better utilize the space available from the erroneous 2048-entry calculation, we are implement

Re: [f2fs-dev] [PATCH v3] f2fs: readahead node blocks in F2FS_GET_BLOCK_PRECACHE mode

2025-10-18 Thread Chao Yu via Linux-f2fs-devel
On 9/24/25 13:58, Yunji Kang wrote: > In f2fs_precache_extents(), For large files, It requires reading many > node blocks. Instead of reading each node block with synchronous I/O, > this patch applies readahead so that node blocks can be fetched in > advance. > > It reduces the overhead of repeate

Re: [f2fs-dev] [PATCH v2 2/2] f2fs/022: do sanity check on footer of non inode dnode

2025-10-18 Thread Zorro Lang via Linux-f2fs-devel
On Sun, Sep 28, 2025 at 04:34:42PM +0800, Chao Yu wrote: > This is a regression test: > 1. create foo & bar > 2. write 8M data to foo > 3. use inject.f2fs to inject i_nid[0] of foo w/ ino of bar > 4. fpunch in foo w/ specified range > > If we haven't applied kernel patch ("f2fs: fix to do sanity c

Re: [f2fs-dev] [PATCH] f2fs: fix to truncate first page in error path of f2fs_truncate()

2025-10-18 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Wed, 10 Sep 2025 16:40:24 +0800 you wrote: > syzbot reports a bug as below: > > loop0: detected capacity change from 0 to 40427 > F2FS-fs (loop0): Wrong SSA boundary, start(3584) end(4096) blocks(3072) > F2FS-fs (loop0):

[f2fs-dev] Patchwork summary for: f2fs

2025-10-18 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: The following patches were marked "accepted", because they were applied to jaegeuk/f2fs.git (dev): Patch: [f2fs-dev,GIT,PULL] f2fs for 6.18-rc1 Submitter: Jaegeuk Kim Committer: Linus Torvalds Patchwork: https://patchwork.kernel.org/project/f2fs/list/?series=1008341 Lore link: ht

[f2fs-dev] [PATCH] f2fs: Perform sanity check before unlinking directory inode

2025-10-18 Thread Nikola Z. Ivanov
Current i_nlink corruption check does not take into account directory inodes which have one additional i_nlink for their "." entry. Add additional check and a common corruption path. Reported-by: [email protected] Closes: https://syzkaller.appspot.com/bug?extid

[f2fs-dev] Welders

2025-10-18 Thread Luke Walsh via Linux-f2fs-devel
Dear Sir or Madam, I am contacting you on behalf of a company specialising in comprehensive industrial services for businesses requiring the highest precision in component manufacturing. Within one cooperation we provide the outsourcing of certified welders, locksmiths and fitters, as well as

Re: [f2fs-dev] [PATCH kvm-next V11 4/7] KVM: guest_memfd: Use guest mem inodes instead of anonymous inodes

2025-10-18 Thread Sean Christopherson via Linux-f2fs-devel
On Thu, Sep 25, 2025, David Hildenbrand wrote: > On 25.09.25 13:44, Garg, Shivank wrote: > > On 9/25/2025 8:20 AM, Sean Christopherson wrote: > > I did functional testing and it works fine. > > I can queue this instead. I guess I can reuse the patch description and add > Sean as author + add his S

[f2fs-dev] [PATCH v2 16/16] writeback: added XFS support for matching writeback count to allocation group count

2025-10-18 Thread Kundan Kumar
Implemented bdi_inc_writeback() to increase the writeback context count and called this function at XFS mount time to set the desired count. Signed-off-by: Kundan Kumar Signed-off-by: Anuj Gupta --- fs/xfs/xfs_super.c | 2 ++ include/linux/backing-dev.h | 1 + mm/backing-dev.c

Re: [f2fs-dev] [PATCH] f2fs: don't call iput() from f2fs_drop_inode()

2025-10-18 Thread Jaegeuk Kim via Linux-f2fs-devel
On 10/01, Mateusz Guzik wrote: > iput() calls the problematic routine, which does a ->i_count inc/dec > cycle. Undoing it with iput() recurses into the problem. > > Note f2fs should not be playing games with the refcount to begin with, > but that will be handled later. Right now solve the immediat