On Thu, Jul 25, 2024, at 16:39, Christoph Hellwig wrote:
> On Thu, Jul 25, 2024 at 11:01:33AM +0800, Youling Tang wrote:
>> - It doesn't feel good to have only one subinit/exit in a file.
>> Assuming that there is only one file in each file, how do we
>> ensure that the files are linked in orde
On Thu, Sep 28, 2023, at 13:40, Jeff Layton wrote:
> On Thu, 2023-09-28 at 10:19 -0700, Darrick J. Wong wrote:
>>
>> > I remember seeing those patches go by. I don't remember that change
>> > being NaK'ed, but I wasn't paying close attention at the time
>> >
>> > Looking at it objectively now, I
On Thu, Sep 28, 2023, at 07:05, Jeff Layton wrote:
> This shaves 8 bytes off struct inode, according to pahole.
>
> Signed-off-by: Jeff Layton
FWIW, this is similar to the approach that Deepa suggested
back in 2016:
https://lore.kernel.org/lkml/1452144972-15802-3-git-send-email-deepa.ker...@gmai
On Mon, Nov 14, 2022, at 10:23, Zhiguo Niu wrote:
> Arnd Bergmann 于2022年11月11日周五 17:57写道：
> so I just modify struct victim_entry as your suggestion:
> diff --git a/fs/f2fs/gc.h b/fs/f2fs/gc.h
> index 19b956c2d697..e2f25b8fd865 100644
> --- a/fs/f2fs/gc.h
> +++ b/fs/f2fs/gc.h
On Fri, Nov 11, 2022, at 10:40, Zhiguo Niu wrote:
> Arnd Bergmann 于2022年11月10日周四 21:45写道：
> I thinks the gcc complier build warning :
>
> In file included from fs/f2fs/segment.c:24:
>>> fs/f2fs/gc.h:73:1:
On Thu, Nov 10, 2022, at 11:20, Zhiguo Niu wrote:
> Arnd Bergmann 于2022年11月10日周四 17:07写道：
>> On Thu, Nov 10, 2022, at 09:33, kernel test robot wrote:
>> > base:
>> > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git
>> > dev-
On Thu, Nov 10, 2022, at 09:33, kernel test robot wrote:
> Hi zhiguo.niu",
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on jaegeuk-f2fs/dev-test]
> [also build test WARNING on linus/master v6.1-rc4 next-20221109]
> [If your patch is applied to the wrong gi
From: Arnd Bergmann
The f2fs_compress_set_level() function is only used for zstd and
lz4 compression modes, and otherwise causes a compile-time warning
for having no users.
Change the #ifdef check to match what calls it.
Fixes: c08e95fc6466 ("f2fs: compress: support compress level")
On Thu, May 21, 2020 at 11:22 AM Naresh Kamboju
wrote:
> On Thu, 21 May 2020 at 00:39, Chris Down wrote:
> > Since you have i386 hardware available, and I don't, could you please apply
> > only "avoid stale protection" again and check if it only happens with that
> > commit, or requires both? Tha
On Tue, May 19, 2020 at 9:52 AM Michal Hocko wrote:
>
> On Mon 18-05-20 19:40:55, Naresh Kamboju wrote:
> > Thanks for looking into this problem.
> >
> > On Sat, 2 May 2020 at 02:28, Andrew Morton
> > wrote:
> > >
> > > On Fri, 1 May 2020 18:08:28 +0530 Naresh Kamboju
> > > wrote:
> > >
> > >
: Arnd Bergmann
---
fs/compat_ioctl.c | 2 --
fs/ecryptfs/file.c | 1 +
fs/ext4/ioctl.c| 1 +
fs/f2fs/file.c | 1 +
fs/hpfs/dir.c | 1 +
fs/hpfs/file.c | 1 +
fs/nilfs2/ioctl.c | 1 +
fs/ocfs2/ioctl.c | 1 +
8 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/fs
On Fri, Aug 30, 2019 at 5:48 PM Deepa Dinamani wrote:
>
> [resending, rebased onto linux v5.3-rc6, and dropped orangefs patch from the
> series]
>
> Hi Al, Arnd,
>
> This is a pull request for filling in min and max timestamps for filesystems.
> I've added all the acks, and dropped the adfs patch
On Fri, Aug 30, 2019 at 4:02 AM Deepa Dinamani wrote:
> On Thu, Aug 29, 2019 at 6:20 PM Mike Marshall wrote:
> >
> > Hi Deepa...
> >
> > I installed this patch series on top of Linux 5.3-rc6 and ran xfstests
> > on orangefs and got a regression... generic/258 failed
> > with: "Timestamp wrapped".
Remove the special case for FITRIM, and make file systems
handle that like all other ioctl commands with their own
handlers.
Signed-off-by: Arnd Bergmann
---
fs/compat_ioctl.c | 2 --
fs/ecryptfs/file.c | 1 +
fs/ext4/ioctl.c| 1 +
fs/f2fs/file.c | 1 +
fs/hpfs/dir.c | 1 +
fs
ppp_generic
Arnd Bergmann (16):
xfs: compat_ioctl: use compat_ptr()
xfs: compat_ioctl: add missing conversions
gfs2: add compat_ioctl support
fs: compat_ioctl: move FITRIM emulation into file systems
watchdog: cpwd: use generic compat_ptr_ioctl
compat_ioctl: move WDIOC handling into wdt
On Fri, Jun 28, 2019 at 7:58 PM Russell King - ARM Linux admin
wrote:
>
> On Fri, Jun 28, 2019 at 04:46:14PM +0200, Arnd Bergmann wrote:
> > On Fri, Jun 28, 2019 at 3:17 PM Christoph Hellwig
> > wrote:
> > >
> > > On Fri, Jun 28, 2019 at 03:09:47PM +0200,
On Fri, Jun 28, 2019 at 5:59 PM Jaegeuk Kim wrote:
>
> Hi Arnd,
>
> If you don't mind, can I integrate this into the original patch in the queue?
Yes, I think that would be good anyway, it may take a little longer to fix all
the architectures.
Arnd
_
On Fri, Jun 28, 2019 at 3:17 PM Christoph Hellwig wrote:
>
> On Fri, Jun 28, 2019 at 03:09:47PM +0200, Arnd Bergmann wrote:
> > I came across this on arm-nommu (which disables
> > CONFIG_CPU_SPECTRE) during randconfig testing.
> >
> > I don't see an easy
On Fri, Jun 28, 2019 at 2:44 PM Christoph Hellwig wrote:
>
> On Fri, Jun 28, 2019 at 12:39:52PM +0200, Arnd Bergmann wrote:
> > Not all architectures support get_user() with a 64-bit argument:
>
> Which architectures are still missing? I think we finally need to
> get everyo
Not all architectures support get_user() with a 64-bit argument:
ERROR: "__get_user_bad" [fs/f2fs/f2fs.ko] undefined!
Use copy_from_user() here, this will always work.
Fixes: d2ae7494d043 ("f2fs: ioctl for removing a range from F2FS")
Signed-off-by: Arnd Bergmann
---
fs/f2
ifdef around it, but the more
reliable way of doing this seems to be to remove the other #ifdefs
where that is easily possible.
By defining time_to_inject() as a trivial stub, most of the checks for
CONFIG_F2FS_FAULT_INJECTION can go away. This also leads to nicer
formatting of the code.
Signed-o
On Wed, Jul 25, 2018 at 5:21 PM, Chao Yu wrote:
> On 2018/7/24 17:34, Arnd Bergmann wrote:
>> On 32-bit targets, size_t is often 'unsigned int', so printing it as %lu
>> causes a warning:
>>
>> fs/f2fs/inode.c: In function 'sanity_check_inode'
pe 'unsigned int' [-Werror=format=]
The correct format string is %zu.
Fixes: ba3a252d3367 ("f2fs: fix to do sanity check with i_extra_isize")
Signed-off-by: Arnd Bergmann
---
fs/f2fs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/inode.c b/f
On Fri, Jul 13, 2018 at 6:10 PM, Jaegeuk Kim wrote:
> Hi Arnd,
>
> I queued in the testing branch, since I'm trying to fix another issue in
> -next.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=2cdbbf025aac9f3dd54b9dec0a6603839a3171d3
>
> Allow me to
The on-disk representation and the vfs both use 64-bit tv_sec values,
so let's change the last missing piece in the middle.
Reviewed-by: Chao Yu
Signed-off-by: Arnd Bergmann
---
I sent this on Jun 20 and got an Ack, but nobody picked up the patch
into linux-next.
Could you merge this for
The on-disk representation and the vfs both use 64-bit tv_sec values,
so let's change the last missing piece in the middle.
Signed-off-by: Arnd Bergmann
---
fs/f2fs/f2fs.h | 16 ++--
fs/f2fs/inode.c | 12 ++--
fs/f2fs/namei.c | 2 +-
3 files changed, 13 insertions(+
All uses of timespec are deprecated, and this one is not particularly
useful, as the documented method for converting seconds to jiffies
is to multiply by 'HZ'.
Signed-off-by: Arnd Bergmann
---
fs/f2fs/f2fs.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/f2f
e [-Werror=parentheses]
while (nr_pages = pagevec_lookup_tag(&pvec, mapping, &index,
This seems reasonable, so let's do that.
Fixes: 4aba7297f4a5 ("f2fs: simplify page iteration loops")
Signed-off-by: Arnd Bergmann
---
The warning is from mmotm. Andrew, please fold this f
On Fri, Jun 2, 2017 at 2:18 PM, Yan, Zheng wrote:
> On Fri, Jun 2, 2017 at 7:33 PM, Arnd Bergmann wrote:
>> On Fri, Jun 2, 2017 at 1:18 PM, Yan, Zheng wrote:
>> What I meant is another related problem in ceph_mkdir() where the
>> i_ctime field of the parent inode is
On Fri, Jun 2, 2017 at 1:18 PM, Yan, Zheng wrote:
> On Fri, Jun 2, 2017 at 6:51 PM, Arnd Bergmann wrote:
>> On Fri, Jun 2, 2017 at 12:10 PM, Yan, Zheng wrote:
>>> On Fri, Jun 2, 2017 at 5:45 PM, Arnd Bergmann wrote:
>>>> On Fri, Jun 2, 2017 at 4:09 AM, Yan, Zhe
On Fri, Jun 2, 2017 at 12:10 PM, Yan, Zheng wrote:
> On Fri, Jun 2, 2017 at 5:45 PM, Arnd Bergmann wrote:
>> On Fri, Jun 2, 2017 at 4:09 AM, Yan, Zheng wrote:
>>> On Fri, Jun 2, 2017 at 8:57 AM, Deepa Dinamani
>>> wrote:
>>>> On Thu, Jun 1, 2017 at 5:
On Fri, Jun 2, 2017 at 4:09 AM, Yan, Zheng wrote:
> On Fri, Jun 2, 2017 at 8:57 AM, Deepa Dinamani wrote:
>> On Thu, Jun 1, 2017 at 5:36 PM, John Stultz wrote:
>>> On Thu, Jun 1, 2017 at 5:26 PM, Yan, Zheng wrote:
>>>> On Thu, Jun 1, 2017 at 6:22 PM, Arnd Bergma
On Thu, Jun 1, 2017 at 11:56 AM, Yan, Zheng wrote:
> On Sat, Apr 8, 2017 at 8:57 AM, Deepa Dinamani wrote:
>> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
>> index 517838b..77204da 100644
>> --- a/drivers/block/rbd.c
>> +++ b/drivers/block/rbd.c
>> @@ -1922,7 +1922,7 @@ static void rbd
[-Werror=empty-body]
stat_inc_rbtree_node_hit(sbi);
A good way to avoid the warning and make the code more robust is to define
all no-op macros as 'do { } while (0)'.
Fixes: 54c2258cd63a ("f2fs: extract rb-tree operation infrastructure")
Signed-off-by:
On Sat, Apr 8, 2017 at 5:58 PM, Deepa Dinamani wrote:
>> I have no problem merging this patch into audit/next for v4.12, would
>> you prefer me to do that so at least this patch is merged?
>
> This would be fine.
> But, I think whoever takes the last 2 deletion patches should also take them.
> I'm
On Wednesday, November 23, 2016 10:42:26 AM CET Jaegeuk Kim wrote:
>
> Unfortunately, the sector number is usually a 64-bit number, and
> we guarantee that bdev_zone_size() returns a power-of-two number.
The sentence no longer makes sense. Maybe
Fortunately, bdev_zone_size() is guaranteed to ret
tor number is usually a 64-bit number, and
we probably can't guarantee that bdev_zone_size() returns a
power-of-two number, so we actually have to do the expensive 64-bit
operation to get the remainder.
Fixes: 792b84b74b54 ("f2fs: support multiple devices")
Signed-off-by: Arnd Bergman
232 ("f2fs: support in batch multi blocks preallocation")
Signed-off-by: Arnd Bergmann
---
fs/f2fs/data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index a59ea8e60040..6f01aaddfce9 100644
--- a/fs/f2fs/data.c
+++ b/
On Wednesday 02 November 2016, Chao Yu wrote:
> Hi Arnd, Jaegeuk,
>
> It is trivial, but it's better keep commit *title*, commit log and code
> consistent. :)
Sorry for my silly mistake, sent it again with a new subject now.
Arnd
-
232 ("f2fs: support in batch multi blocks preallocation")
Signed-off-by: Arnd Bergmann
---
fs/f2fs/data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
v2: use simpler workaround, as discussed with Chao Yu.
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 68edb47f5f71..cf
On Wednesday, October 26, 2016 10:05:00 PM CEST Chao Yu wrote:
> On 2016/10/18 6:05, Arnd Bergmann wrote:
> > gcc is unsure about the use of last_ofs_in_node, which might happen
> > without a prior initialization:
> >
> > fs/f2fs//git/arm-soc/fs/f2fs/data.c: In functio
sy to trigger, and I will send them for inclusion
in v4.10.
Link: https://rusty.ozlabs.org/?p=232 [1]
Link: https://gcc.gnu.org/wiki/Better_Uninitialized_Warnings [2]
Signed-off-by: Arnd Bergmann
---
Makefile | 10 ++
arch/arc/Makefile | 4 +++-
scripts/Makefile.ubsan
Arnd Bergmann (28):
[v2] netfilter: nf_tables: avoid uninitialized variable warning
[v2] mtd: mtk: avoid warning in mtk_ecc_encode
[v2] infiniband: shut up a maybe-uninitialized warning
f2fs: replace a build-time warning with runtime WARN_ON
ext2: avoid bogus -Wmaybe-uninitialized warning
e this
patch could just be disregarded. It would certainly be helpful
to get an opinion from the maintainers on the matter.
Fixes: 46008c6d4232 ("f2fs: support in batch multi blocks preallocation")
Cc: Chao Yu
Cc: Jaegeuk Kim
Signed-off-by: Arnd Bergmann
---
fs/f2fs/data.c |
On Monday, August 15, 2016 6:23:12 PM CEST Greg KH wrote:
> On Sat, Aug 13, 2016 at 03:48:12PM -0700, Deepa Dinamani wrote:
> > The series is aimed at getting rid of CURRENT_TIME and CURRENT_TIME_SEC
> > macros.
> > The macros are not y2038 safe. There is no plan to transition them into
> > being
; y2038 safe.
> ktime_get_* api's can be used in their place. And, these are y2038 safe.
>
> CURRENT_TIME will be deleted after 4.8 rc1 as there is a dependency function
> time64_to_tm() for one of the CURRENT_TIME occurance.
>
> Thanks to Arnd Bergmann for all the guidance and
in their place. And, these are y2038 safe.
>
> Thanks to Arnd Bergmann for all the guidance and discussions.
>
> Patches 2-4 were mostly generated using coccinelle scripts.
>
> All filesystem timestamps use current_fs_time() for right granularity as
> mentioned in the respe
On Monday, June 20, 2016 11:03:01 AM CEST you wrote:
> On Sun, Jun 19, 2016 at 5:26 PM, Deepa Dinamani
> wrote:
> > The series is aimed at getting rid of CURRENT_TIME and CURRENT_TIME_SEC
> > macros.
> Gcc handles 8-byte structure returns (on most architectures) by
> returning them as two 32-bi
On Wednesday, June 8, 2016 10:04:48 PM CEST Deepa Dinamani wrote:
>
> Signed-off-by: Deepa Dinamani
> Cc: Steve French
> Cc: linux-c...@vger.kernel.org
> Cc: samba-techni...@lists.samba.org
> Cc: Joern Engel
> Cc: Prasad Joshi
> Cc: lo...@logfs.org
> Cc: Andrew Morton
> Cc: Julia Lawall
> Cc
ttr(struct inode *inode, int index,
Thsi changes the prototype of the empty stub function to match
that of the actual implementation. This will not make the key
management work when F2FS_FS_XATTR is disabled, but it gets it
to build at least.
Signed-off-by: Arnd Bergmann
Fixes: 1448eee67def ("
o this,
in order to annotate that this is an expensive operation.
As the function is only called for debug out, we know this
is not performance critical, so it is safe to use div_u64.
Signed-off-by: Arnd Bergmann
Fixes: d1f85bd38db19 ("f2fs: avoid value overflow in showing current status"
On Wednesday 04 June 2014 17:10:24 H. Peter Anvin wrote:
> On 06/04/2014 12:24 PM, Arnd Bergmann wrote:
> >
> > For other timekeeping stuff in the kernel, I agree that using some
> > 64-bit representation (nanoseconds, 32/32 unsigned seconds/nanoseconds,
> > ...) has
On Tuesday 03 June 2014, Dave Chinner wrote:
> On Tue, Jun 03, 2014 at 04:22:19PM +0200, Arnd Bergmann wrote:
> > On Monday 02 June 2014 14:57:26 H. Peter Anvin wrote:
> > > On 06/02/2014 12:55 PM, Arnd Bergmann wrote:
> > The possible uses I can see for non-ktime_t
On Wednesday 04 June 2014 13:30:32 Nicolas Pitre wrote:
> On Wed, 4 Jun 2014, Arnd Bergmann wrote:
>
> > On Tuesday 03 June 2014, Dave Chinner wrote:
> > > Just ot be pedantic, inodes don't need 96 bit timestamps - some
> > > filesystems can *support up t
On Monday 02 June 2014, Joseph S. Myers wrote:
> On Mon, 2 Jun 2014, Arnd Bergmann wrote:
>
> > Ok. Sorry about missing linux-api, I confused it with linux-arch, which
> > may not be as relevant here, except for the one question whether we
> > actually want to have t
On Monday 02 June 2014 14:57:26 H. Peter Anvin wrote:
> On 06/02/2014 12:55 PM, Arnd Bergmann wrote:
> >>
> >> The bit that is really going to hurt is every single ioctl that uses a
> >> timespec.
> >>
> >> Honestly, though, I really don't un
On Tuesday 03 June 2014 14:33:10 Joseph S. Myers wrote:
> On Tue, 3 Jun 2014, Arnd Bergmann wrote:
>
> > I think John Stultz and Thomas Gleixner have already started looking
> > at how the timekeeping code can be updated. Once that is done, we should
> > be able to
On Saturday 31 May 2014 18:30:49 Vyacheslav Dubeyko wrote:
> By the way, what about NILFS2? Is NILFS2 ready for suggested approach
> without any changes?
nilfs2 and a lot of other file systems don't need any changes for
this, because they don't assign the inode time stamp fields to
a 'struct times
On Monday 02 June 2014 13:52:19 Joseph S. Myers wrote:
> On Fri, 30 May 2014, Arnd Bergmann wrote:
>
> > a) is this the right approach in general? The previous discussion
> >pointed this way, but there may be other opinions.
>
> The syscall changes seem like the
On Monday 02 June 2014 12:26:22 H. Peter Anvin wrote:
> On 06/02/2014 12:19 PM, Arnd Bergmann wrote:
> > On Monday 02 June 2014 13:52:19 Joseph S. Myers wrote:
> >> On Fri, 30 May 2014, Arnd Bergmann wrote:
> >>
> >>> a) is this the right appro
: Arnd Bergmann
Cc: Jaegeuk Kim
Cc: linux-f2fs-devel@lists.sourceforge.net
---
fs/f2fs/file.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 37d0e1f..6ff6e5b 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -474,13 +474,13
On Saturday 31 May 2014 16:51:15 Richard Cochran wrote:
> On Fri, May 30, 2014 at 10:01:24PM +0200, Arnd Bergmann wrote:
> >
> > I picked this because it is a fairly isolated problem, as the
> > inode time stamps are rarely assigned to any other time values.
> > As
of times we want to cover.
c) Should we continue this way for all 32-bit platforms for
consistency, including future ones, or should we go to
different 64-bit types right away? My feeling is that the
second approach would complicate this work.
Arnd
[1] http://kernelnewbies.org/
63 matches
Mail list logo
