Re: [f2fs-dev] [PATCH v3] f2fs: introduce flush_policy sysfs entry

2025-08-11 Thread Bart Van Assche via Linux-f2fs-devel
On 8/11/25 3:52 AM, Christoph Hellwig wrote: On Thu, Aug 07, 2025 at 11:48:38AM +0800, Chao Yu wrote: This patch introduces a new sysfs entry /sys/fs/f2fs//flush_policy in order to tune performance of f2fs data flush flow. For example, checkpoint will use REQ_FUA to persist CP metadata, however

Re: [f2fs-dev] [PATCH v5 3/5] fcntl: add F_{SET/GET}_RW_HINT_EX

2024-09-12 Thread Bart Van Assche via Linux-f2fs-devel
On 9/10/24 8:01 AM, Kanchan Joshi wrote: diff --git a/include/linux/rw_hint.h b/include/linux/rw_hint.h index b9942f5f13d3..ff708a75e2f6 100644 --- a/include/linux/rw_hint.h +++ b/include/linux/rw_hint.h @@ -21,4 +21,17 @@ enum rw_lifetime_hint { static_assert(sizeof(enum rw_lifetime_hint) == 1

Re: [f2fs-dev] [PATCH v5 1/5] fs, block: refactor enum rw_hint

2024-09-12 Thread Bart Van Assche via Linux-f2fs-devel
On 9/12/24 8:50 AM, Kanchan Joshi wrote: Wherever hint is being used in generic way, u8 data type is being used. Has it been considered to introduce a new union and to use that as the type of 'hint' instead of 'u8'? Thanks, Bart. ___ Linux-f2fs-de

Re: [f2fs-dev] [PATCH v4 1/5] fs, block: refactor enum rw_hint

2024-08-30 Thread Bart Van Assche via Linux-f2fs-devel
On 8/26/24 1:06 PM, Kanchan Joshi wrote: /* Block storage write lifetime hint values. */ -enum rw_hint { +enum rw_life_hint { The name "rw_life_hint" seems confusing to me. I think that the name "rw_lifetime_hint" would be a better name. Thanks, Bart.

Re: [f2fs-dev] [PATCH v4 1/5] fs, block: refactor enum rw_hint

2024-08-26 Thread Bart Van Assche via Linux-f2fs-devel
On 8/26/24 10:06 AM, Kanchan Joshi wrote: Change i_write_hint (in inode), bi_write_hint (in bio) and write_hint (in request) to use u8 data-type rather than this enum. That sounds fishy to me. Why to increase the size of this enum? Why to reduce the ability of the compiler to perform type check