Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-06-18 Thread Chris Down
Michal Hocko writes: I would really prefer to do that work on top of the fixes we (used to) have in mmotm (with the fixup). Oh, for sure. We should reintroduce the patches with the fix, and then look at longer-term solutions once that's in :-) ___

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-06-18 Thread Chris Down
Yafang Shao writes: On Thu, Jun 18, 2020 at 5:09 AM Chris Down wrote: Naresh Kamboju writes: >After this patch applied the reported issue got fixed. Great! Thank you Naresh and Michal for helping to get to the bottom of this :-) I'll send out a new version tomorrow with the fixes

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-06-17 Thread Chris Down
Naresh Kamboju writes: After this patch applied the reported issue got fixed. Great! Thank you Naresh and Michal for helping to get to the bottom of this :-) I'll send out a new version tomorrow with the fixes applied and both of you credited in the changelog for the detection and fix. ___

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-06-17 Thread Chris Down
Michal Hocko writes: and it makes some sense. Except for the root memcg where we do not account any memory. Adding if (mem_cgroup_is_root(memcg)) return false; should do the trick. The same is the case for mem_cgroup_below_low. Could you give it a try please just to confirm? Oh, of course :-) T

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-06-17 Thread Chris Down
Naresh Kamboju writes: mkfs -t ext4 /dev/disk/by-id/ata-TOSHIBA_MG04ACA100N_Y8RQK14KF6XF mke2fs 1.43.8 (1-Jan-2018) Creating filesystem with 244190646 4k blocks and 61054976 inodes Filesystem UUID: 7c380766-0ed8-41ba-a0de-3c08e78f1891 Superblock backups stored on blocks: 32768, 98304, 163840, 229

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-28 Thread Chris Down
Yafang Shao writes: Look at this patch[1] carefully you will find that it introduces the same issue that I tried to fix in another patch [2]. Even more sad is these two patches are in the same patchset. Although this issue isn't related with the issue found by Naresh, we have to ask ourselves why

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-28 Thread Chris Down
Naresh Kamboju writes: On Thu, 28 May 2020 at 20:33, Michal Hocko wrote: On Fri 22-05-20 02:23:09, Naresh Kamboju wrote: > My apology ! > As per the test results history this problem started happening from > Bad : next-20200430 (still reproducible on next-20200519) > Good : next-20200429 > > T

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-20 Thread Chris Down
Hi Naresh, Naresh Kamboju writes: As a part of investigation on this issue LKFT teammate Anders Roxell git bisected the problem and found bad commit(s) which caused this problem. The following two patches have been reverted on next-20200519 and retested the reproducible steps and confirmed the