[f2fs-dev] [PATCH] f2fs: Use sysfs_emit_at() to simplify code

2024-08-08 Thread Christophe JAILLET via Linux-f2fs-devel
This file already uses sysfs_emit(). So be consistent and also use sysfs_emit_at(). This slightly simplifies the code and makes it more readable. Signed-off-by: Christophe JAILLET --- Compile tested only --- fs/f2fs/sysfs.c | 45 + 1 file changed, 21

Re: [f2fs-dev] [PATCH 2/2] f2fs: move the conditional statement after holding the inode lock in f2fs_fallocate()

2023-05-06 Thread Christophe JAILLET
Le 06/05/2023 à 13:40, Yangtao Li a écrit : For judging the inode flag state, the inode lock must be held. Fixes: fcc85a4d86b5 ("f2fs crypto: activate encryption support for fs APIs") Signed-off-by: Yangtao Li --- fs/f2fs/file.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletio

Re: [f2fs-dev] [PATCH 1/2] f2fs: move the conditional statement after holding the inode lock in f2fs_move_file_range()

2023-05-06 Thread Christophe JAILLET
Le 06/05/2023 à 13:39, Yangtao Li a écrit : For judging the inode flag state, the inode lock must be held. BTW, add compressd file check and to avoid 'if' nesting. Fixes: 4dd6f977fc77 ("f2fs: support an ioctl to move a range of data blocks") Signed-off-by: Yangtao Li --- fs/f2fs/file.c | 14 +

[f2fs-dev] [PATCH] f2fs: remove some dead code

2023-04-17 Thread Christophe JAILLET
'ret' is known to be 0 at the point. So these lines of code should just be removed. Signed-off-by: Christophe JAILLET --- The dead code became after commit 8358014d6be8 ("f2fs: avoid to check PG_error flag") --- fs/f2fs/node.c | 9 ++--- 1 file changed, 2 insert

[f2fs-dev] [PATCH] f2fs: Fix a return value in case of error in 'f2fs_fill_super'

2017-06-11 Thread Christophe JAILLET
err must be set to -ENOMEM, otherwise we return 0. Fixes: a912b54d3aaa0 ("f2fs: split bio cache") Signed-off-by: Christophe JAILLET --- fs/f2fs/super.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 5be27eacea99..38