Re: [f2fs-dev] [PATCH] fscrypt: add support for ChaCha20 contents encryption

2017-12-11 Thread David Gstir
> On 08.12.2017, at 03:51, Jason A. Donenfeld wrote: > > Hi Eric, > > Nice to see more use of ChaCha20. However... > > Can we skip over the "sort of worse than XTS, but not having _real_ > authentication sucks anyway in either case, so whatever" and move > directly to, "linux finally supports

Re: [f2fs-dev] [PATCH 0/4] fscrypt: remove checks for encryption key after file open

2017-05-22 Thread David Gstir
- > fs/f2fs/file.c | 13 - > fs/ubifs/file.c | 9 - > 3 files changed, 29 deletions(-) The whole series looks good to me. So feel free to add my Reviewed-by: David Gstir David -- Check o

Re: [f2fs-dev] [PATCH] fscrypto: make XTS tweak initialization endian-independent

2016-10-05 Thread David Gstir
Eric, > On 04.10.2016, at 18:38, Eric Biggers wrote: > > On Tue, Oct 04, 2016 at 10:46:54AM +0200, Richard Weinberger wrote: >>> Also, currently this code *is* only supposed to be used for XTS. There's a >>> bug >>> where a specially crafted filesystem can cause this code path to be entered >