Re: [PATCH 6/6] mm: Remove page_mapping()

2024-04-24 Thread David Hildenbrand
"internal.h" -struct address_space *page_mapping(struct page *page) -{ - return folio_mapping(page_folio(page)); -} -EXPORT_SYMBOL(page_mapping); - void unlock_page(struct page *page) { return folio_unlock(page_folio(page)); Reviewed-by: David Hildenbrand -- Chee

Re: [PATCH 5/6] userfault; Expand folio use in mfill_atomic_install_pte()

2024-04-24 Thread David Hildenbrand
On 24.04.24 00:55, Matthew Wilcox (Oracle) wrote: Call page_folio() a little earlier so we can use folio_mapping() instead of page_mapping(), saving a call to compound_head(). Signed-off-by: Matthew Wilcox (Oracle) --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb

Re: [PATCH 4/6] migrate: Expand the use of folio in __migrate_device_pages()

2024-04-24 Thread David Hildenbrand
On 24.04.24 00:55, Matthew Wilcox (Oracle) wrote: Removes a few calls to compound_head() and a call to page_mapping(). Signed-off-by: Matthew Wilcox (Oracle) --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb

Re: [PATCH 3/6] memory-failure: Remove calls to page_mapping()

2024-04-24 Thread David Hildenbrand
On 24.04.24 00:55, Matthew Wilcox (Oracle) wrote: This is mostly just inlining page_mapping() into the two callers. Signed-off-by: Matthew Wilcox (Oracle) --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb

Re: [PATCH 2/6] f2fs: Convert f2fs_clear_page_cache_dirty_tag to use a folio

2024-04-24 Thread David Hildenbrand
folio->index, PAGECACHE_TAG_DIRTY); xa_unlock_irqrestore(>i_pages, flags); } Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb

Re: [PATCH 1/6] fscrypt: Convert bh_get_inode_and_lblk_num to use a folio

2024-04-24 Thread David Hildenbrand
On 24.04.24 00:55, Matthew Wilcox (Oracle) wrote: Remove uses of page->index, page_mapping() and b_page. Saves a call to compound_head(). Signed-off-by: Matthew Wilcox (Oracle) --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb

Re: [f2fs-dev] [PATCH v2 03/19] fs: Add aops->migrate_folio

2022-06-10 Thread David Hildenbrand
On 09.06.22 16:35, Matthew Wilcox wrote: > On Thu, Jun 09, 2022 at 02:50:20PM +0200, David Hildenbrand wrote: >> On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote: >>> diff --git a/Documentation/filesystems/locking.rst >>> b/Documentation/filesystems/locking

Re: [f2fs-dev] [PATCH v2 03/19] fs: Add aops->migrate_folio

2022-06-09 Thread David Hildenbrand
On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote: > Provide a folio-based replacement for aops->migratepage. Update the > documentation to document migrate_folio instead of migratepage. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > --- >

Re: [f2fs-dev] [PATCH v2 01/19] secretmem: Remove isolate_page

2022-06-09 Thread David Hildenbrand
secretmem_isolate_page, > }; > > static int secretmem_setattr(struct user_namespace *mnt_userns, Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH v2 02/19] mm: Convert all PageMovable users to movable_operations

2022-06-09 Thread David Hildenbrand
++- > 14 files changed, 94 insertions(+), 365 deletions(-) You probably should have cc'ed the relevant maintainers (including me :P ). For everything except z3fold.c and zsmalloc.c, Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb _

Re: [f2fs-dev] [PATCH 15/20] balloon: Convert to migrate_folio

2022-06-08 Thread David Hildenbrand
On 07.06.22 21:21, Matthew Wilcox wrote: > On Tue, Jun 07, 2022 at 03:24:15PM +0100, Matthew Wilcox wrote: >> On Tue, Jun 07, 2022 at 09:36:21AM +0200, David Hildenbrand wrote: >>> On 06.06.22 22:40, Matthew Wilcox (Oracle) wrote: >>>> const struct address

Re: [f2fs-dev] [PATCH 15/20] balloon: Convert to migrate_folio

2022-06-07 Thread David Hildenbrand
On 06.06.22 22:40, Matthew Wilcox (Oracle) wrote: > This is little more than changing the types over; there's no real work > being done in this function. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/balloon_compaction.c | 15 +++ > 1 file changed, 7 insertions(+), 8

Re: [f2fs-dev] [RFC PATCH] mm: introduce kv[mz]alloc helpers

2016-12-08 Thread David Hildenbrand
Am 08.12.2016 um 11:33 schrieb Michal Hocko: > From: Michal Hocko > > Using kmalloc with the vmalloc fallback for larger allocations is a > common pattern in the kernel code. Yet we do not have any common helper > for that and so users have invented their own helpers. Some of