> I think it's unclear from the orangefs source code what the intention is,
> as there is a mixed of signed and unsigned types used for the inode
> stamps:
>
> #define encode_PVFS_time encode_int64_t
> #define encode_int64_t(pptr,x) do { \
> *(int64_t*) *(pptr) = cpu_to_le64(*(x)); \
> *(pp
nges up to 5ad32b3acded06183f40806f76b030c3143017bb:
isofs: Initialize filesystem timestamp ranges (2019-08-30 08:11:25 -0700)
- Deepa
Deepa Dinamani (18):
vfs: Add file timestamp range support
vfs: Add timestamp_trun
On Thu, Aug 29, 2019 at 6:20 PM Mike Marshall wrote:
>
> Hi Deepa...
>
> I installed this patch series on top of Linux 5.3-rc6 and ran xfstests
> on orangefs and got a regression... generic/258 failed
> with: "Timestamp wrapped"...
>
> # cat results/generic/258.out.bad
> QA output created by 258
>
Adding the others who were on original cc, just in case.
- Deepa
On Wed, Aug 28, 2019 at 9:12 PM Deepa Dinamani wrote:
>
> Hi Al, Arnd,
>
> This is a pull request for filling in min and max timestamps for filesystems.
> I've added all the acks, and dropped the adfs patch.
pression e;
@@
inode->i_xtime =
- timespec64_trunc(
+ timestamp_truncate(
...,
- e);
+ inode);
Signed-off-by: Deepa Dinamani
Cc: adrian.hun...@intel.com
Cc: dedeki...@gmail.com
Cc: gre...@linuxfoundation.org
Cc: h...@lst.de
Cc: jaeg...@kernel.org
Cc: jl...@evilplan.org
Cc: rich...@nod.at
Cc: t.
since v2:
* Introduce early boot param override for checks.
* Drop afs patch for timestamp limits.
Changes since v1:
* return EROFS on mount errors
* fix mtime copy/paste error in utimes
Deepa Dinamani (20):
vfs: Add file timestamp range support
vfs: Add timestamp_truncate() api
On Tue, Jul 30, 2019 at 3:28 PM Anton Altaparmakov wrote:
>
> Hi Deepa,
>
> > On 30 Jul 2019, at 18:26, Deepa Dinamani wrote:
> >
> > On Tue, Jul 30, 2019 at 1:27 AM OGAWA Hirofumi
> > wrote:
> >>
> >> Deepa Dinamani writes:
> >>
On Tue, Jul 30, 2019 at 1:27 AM OGAWA Hirofumi
wrote:
>
> Deepa Dinamani writes:
>
> > diff --git a/fs/fat/misc.c b/fs/fat/misc.c
> > index 1e08bd54c5fb..53bb7c6bf993 100644
> > --- a/fs/fat/misc.c
> > +++ b/fs/fat/misc.c
> > @@ -307,8 +307,9 @@ int fat_tr
change in mount behavior because of expiry of timestamps.
* Included limits for more filesystems.
Deepa Dinamani (20):
vfs: Add file timestamp range support
vfs: Add timestamp_truncate() api
timestamp_truncate: Replace users of timespec64_trunc
mount: Add mount warning for impending timestamp
pression e;
@@
inode->i_xtime =
- timespec64_trunc(
+ timestamp_truncate(
...,
- e);
+ inode);
Signed-off-by: Deepa Dinamani
Cc: adrian.hun...@intel.com
Cc: an...@tuxera.com
Cc: dedeki...@gmail.com
Cc: gre...@linuxfoundation.org
Cc: h...@lst.de
Cc: hirof...@mail.parknet.co.jp
Cc: jaeg...@kern
On Thu, Jun 1, 2017 at 5:36 PM, John Stultz wrote:
> On Thu, Jun 1, 2017 at 5:26 PM, Yan, Zheng wrote:
>> On Thu, Jun 1, 2017 at 6:22 PM, Arnd Bergmann wrote:
>>> On Thu, Jun 1, 2017 at 11:56 AM, Yan, Zheng wrote:
>>>> On Sat, Apr 8, 2017 at 8:57 AM, Deepa Dinaman
> I have no problem merging this patch into audit/next for v4.12, would
> you prefer me to do that so at least this patch is merged?
This would be fine.
But, I think whoever takes the last 2 deletion patches should also take them.
I'm not sure how that part works out.
> It would probably make lif
>> - trace_seq_printf(s, "#%-5u inner/outer(us): %4llu/%-5llu ts:%ld.%09ld",
>> + trace_seq_printf(s, "#%-5u inner/outer(us): %4llu/%-5llu
>> ts:%lld.%09ld",
>>field->seqnum,
>>field->duration,
>>field->outer_duration,
timestamps can also be transitioned into
using timespec64 when all other timestamps for cifs is transitioned
to use timespec64.
Signed-off-by: Deepa Dinamani
Reviewed-by: Arnd Bergmann
---
fs/cifs/cifsencrypt.c | 4 +++-
fs/cifs/cifssmb.c | 10 +-
fs/cifs/inode.c | 28
transitioned
to y2038 safe behavior along with this change.
CURRENT_TIME macro will be deleted before merging the
aforementioned change.
Signed-off-by: Deepa Dinamani
---
security/apparmor/apparmorfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/apparmor/apparmorfs.c b
All uses of CURRENT_TIME_SEC and CURRENT_TIME macros have
been replaced by other time functions. These macros are
also not y2038 safe.
And, all their use cases can be fulfilled by y2038 safe
ktime_get_* variants.
Signed-off-by: Deepa Dinamani
Acked-by: John Stultz
Reviewed-by: Arnd Bergmann
All uses of the current_fs_time() function have been
replaced by other time interfaces.
And, its use cases can be fulfilled by current_time()
or ktime_get_* variants.
Signed-off-by: Deepa Dinamani
Reviewed-by: Arnd Bergmann
---
include/linux/fs.h | 1 -
kernel/time/time.c | 14
CURRENT_TIME is not y2038 safe.
Replace it with ktime_get_real_ts64().
Inode time formats are already 64 bit long and
accommodates time64_t.
Signed-off-by: Deepa Dinamani
---
fs/ufs/ialloc.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/ufs/ialloc.c b/fs/ufs
the server, use
timespec_trunc() to truncate the timestamp, using the right
granularity from the superblock.
This api will be transitioned to be y2038 safe along
with vfs.
Signed-off-by: Deepa Dinamani
Reviewed-by: Arnd Bergmann
---
drivers/block/rbd.c | 2 +-
fs/ceph/mds_client.c | 4
1024 characters.
Signed-off-by: Deepa Dinamani
Reviewed-by: Arnd Bergmann
Acked-by: Paul Moore
Acked-by: Richard Guy Briggs
---
include/linux/audit.h | 4 ++--
kernel/audit.c| 10 +-
kernel/audit.h| 2 +-
kernel/auditsc.c | 6 +++---
4 files changed, 11
CURRENT_TIME_SEC is not y2038 safe.
Replace use of CURRENT_TIME_SEC with ktime_get_real_seconds
in segment timestamps used by GC algorithm including the
segment mtime timestamps.
Signed-off-by: Deepa Dinamani
Reviewed-by: Arnd Bergmann
---
fs/f2fs/segment.c | 2 +-
fs/f2fs/segment.h | 5
timespec64 as well.
Signed-off-by: Deepa Dinamani
Acked-by: David Sterba
Reviewed-by: Arnd Bergmann
---
fs/btrfs/root-tree.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/root-tree.c b/fs/btrfs/root-tree.c
index a08224e..7d6bc30 100644
--- a/fs/btrfs/root-tree.c
x27;s super_block.
The granularity check to call current_fs_time() or
CURRENT_TIME_SEC is not required.
Use current_time() directly to update inode timestamp.
Use timespec_trunc during file system creation, before
the first inode is created.
Signed-off-by: Deepa Dinamani
Reviewed-by: Arnd Ber
with this change.
CURRENT_TIME macro will be deleted before merging the
aforementioned change.
Signed-off-by: Deepa Dinamani
---
drivers/staging/lustre/lustre/llite/llite_lib.c | 6 +++---
drivers/staging/lustre/lustre/osc/osc_io.c | 4 ++--
2 files changed, 5 insertions(+), 5 deletions
struct timespec is not y2038 safe on 32 bit machines
and needs to be replaced by struct timespec64
in order to represent times beyond year 2038 on such
machines.
Fix all the timestamp representation in struct trace_hwlat
and all the corresponding implementations.
Signed-off-by: Deepa Dinamani
f you will be picking up
the patch in your trees.
Let me know if anybody has other preferences for merging.
Deepa Dinamani (12):
fs: f2fs: Use ktime_get_real_seconds for sit_info times
trace: Make trace_hwlat timestamp y2038 safe
fs: cifs: Replace CURRENT_TIME by other appropriate apis
CURRENT_TIME_SEC is not y2038 safe.
Replace use of CURRENT_TIME_SEC with ktime_get_real_seconds
in segment timestamps used by GC algorithm including the
segment mtime timestamps.
Signed-off-by: Deepa Dinamani
---
fs/f2fs/segment.c | 2 +-
fs/f2fs/segment.h | 5 +++--
2 files changed, 4
CURRENT_TIME_SEC is not y2038 safe.
Replace use of CURRENT_TIME_SEC with ktime_get_real_seconds
in segment timestamps used by GC algorithm including the
segment mtime timestamps.
Signed-off-by: Deepa Dinamani
Reviewed-by: Arnd Bergmann
Cc: Jaegeuk Kim
Cc: Changman Lee
Cc: linux-f2fs-devel
08-13 13:44:41 -0700)
----
Deepa Dinamani (26):
vfs: Add current_time() api
fs: proc: Delete inode time initializations in proc_alloc_inode()
fs: Replace CURRENT_TIME with current_time() for inode timestamps
fs: Replace CURRENT_TIME_SEC with current_time() for inode time
Thank you for the suggestion.
> Who are you execting to pull this huge patch series?
The last pull request was addressed to Al as per Arnd's suggestion.
I'm not completely sure who should it be addressed to.
> Why not just introduce the new api call, wait for that to be merged, and
> then push t
CURRENT_TIME_SEC is not y2038 safe.
Replace use of CURRENT_TIME_SEC with ktime_get_real_seconds
in segment timestamps used by GC algorithm including the
segment mtime timestamps.
Signed-off-by: Deepa Dinamani
Reviewed-by: Arnd Bergmann
Cc: Jaegeuk Kim
Cc: Changman Lee
Cc: linux-f2fs-devel
ized sb in inode.
* Minor fixes according to Arnd's comments.
* Leave out the fnic and deletion of CURRENT_TIME to be submitted after 4.8 rc1.
Deepa Dinamani (24):
vfs: Add current_time() api
fs: proc: Delete inode time initializations in proc_alloc_inode()
fs: Replace CURRENT_TIME with cur
CURRENT_TIME_SEC is not y2038 safe.
Replace use of CURRENT_TIME_SEC with ktime_get_real_seconds
in segment timestamps used by GC algorithm including the
segment mtime timestamps.
Signed-off-by: Deepa Dinamani
Cc: Jaegeuk Kim
Cc: Changman Lee
Cc: linux-f2fs-devel@lists.sourceforge.net
---
fs
are being handled in a series separate from transitioning vfs to use.
Changes from v1:
* Change current_fs_time(struct super_block *) to current_time(struct inode *)
* Note that change to add time64_to_tm() is already part of John's
kernel tree: https://lkml.org/lkml/2016/6/17/875 .
Dee
> This version now looks ok to me.
>
> I do have a comment (or maybe just a RFD) for future work.
>
> It does strike me that once we actually change over the inode times to
> use timespec64, the calling conventions are going to be fairly
> horrendous on most 32-bit architectures.
>
> Gcc handles 8-
CURRENT_TIME_SEC is not y2038 safe.
Replace use of CURRENT_TIME_SEC with ktime_get_real_seconds
in segment timestamps used by GC algorithm including the
segment mtime timestamps.
Signed-off-by: Deepa Dinamani
Cc: Jaegeuk Kim
Cc: Changman Lee
Cc: linux-f2fs-devel@lists.sourceforge.net
---
fs
On Thu, Jun 9, 2016 at 12:08 PM, Linus Torvalds
wrote:
> On Wed, Jun 8, 2016 at 10:04 PM, Deepa Dinamani
> wrote:
>> CURRENT_TIME macro is not appropriate for filesystems as it
>> doesn't use the right granularity for filesystem timestamps.
>> Use current_fs_time
CURRENT_TIME_SEC is not y2038 safe.
Replace use of CURRENT_TIME_SEC with ktime_get_real_seconds
in segment timestamps used by GC algorithm including the
segment mtime timestamps.
Signed-off-by: Deepa Dinamani
Cc: Jaegeuk Kim
Cc: Changman Lee
Cc: Chao Yu
Cc: linux-f2fs-devel
make them
y2038 safe. As part of the effort current_fs_time() will be
extended to do range checks. Hence, it is necessary for all
file system timestamps to use current_fs_time(). Also,
current_fs_time() will be transitioned along with vfs to be
y2038 safe.
Signed-off-by: Deepa Dinamani
Cc:
RRENT_TIME
macro bug fixes are being handled in a series separate from transitioning
vfs to use 64 bit timestamps.
Some reviewers have requested not to change line wrapping only for the
longer function call names, so checkpatch warnings for such cases are
ignored in the patch series.
Deepa Dinamani
40 matches
Mail list logo
