[f2fs-dev] [PATCH v2] f2fs: remove redundant lines in allocate_data_block

2014-07-29 Thread Dongho Sim
dant." Jaegeuk said: "Right. The new address is always allocated from old_curseg." Signed-off-by: Dongho Sim --- fs/f2fs/segment.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 8a6e57d..7af4a8d 100644 --- a/fs/f2fs/segment.c +++ b/f

[f2fs-dev] [PATCH v2] Remove an unnecessary line in allocate_data_block.

2014-07-29 Thread Dongho Sim
old seg(X) and old curseg(Y). So, because we've done about old curseg(Y), calling locate_dirty_segment(sbi, old_cursegno) again is redundant. Thanks. :-) Signed-off-by: Dongho Sim --- fs/f2fs/segment.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segm

Re: [f2fs-dev] [PATCH] Remove an unnecessary line in allocate_data_block.

2014-07-28 Thread Dongho Sim
Hi, Chao. It's my mistake. Thanks :-) Signed-off-by: Dongho Sim --- fs/f2fs/segment.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 8a6e57d..7af4a8d 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -973,14 +973,12 @@

Re: [f2fs-dev] [PATCH] Remove an unnecessary line in allocate_data_block.

2014-07-27 Thread Dongho Sim
Yes, there was another one. Thanks Chao, :-) Signed-off-by: Dongho Sim --- fs/f2fs/segment.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 8a6e57d..3ab7749 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -980,7 +980,6 @@ void

[f2fs-dev] [PATCH] Remove an unnecessary line in allocate_data_block.

2014-07-27 Thread Dongho Sim
Hi. There was an unnecessary line in function, allocate_data_block. It is already done in refresh_sit_entry(sbi, old_blkaddr, *new_blkaddr); Thanks. Signed-off-by: Dongho Sim --- fs/f2fs/segment.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c