[f2fs-dev] [PATCH 3/3] f2fs: fix inode rwsem regression

2019-09-11 Thread Goldwyn Rodrigues
From: Goldwyn Rodrigues This is similar to 942491c9e6d6 ("xfs: fix AIM7 regression") Apparently our current rwsem code doesn't like doing the trylock, then lock for real scheme. So change our read/write methods to just do the trylock for the RWF_NOWAIT case. We don

[f2fs-dev] [PATCH 2/3] ext4: fix inode rwsem regression

2019-09-11 Thread Goldwyn Rodrigues
From: Goldwyn Rodrigues This is similar to 942491c9e6d6 ("xfs: fix AIM7 regression") Apparently our current rwsem code doesn't like doing the trylock, then lock for real scheme. So change our read/write methods to just do the trylock for the RWF_NOWAIT case. Fixes: 728fbc0e10b7

[f2fs-dev] Fix inode sem regression for nowait

2019-09-11 Thread Goldwyn Rodrigues
This changes the way we acquire the inode semaphore when the I/O is marked with IOCB_NOWAIT. The regression was discovered in AIM7 and later by Andres in ext4. This has been fixed in XFS by 942491c9e6d6 ("xfs: fix AIM7 regression") I realized f2fs and btrfs also have the same code and need to be u

[f2fs-dev] [PATCH 1/3] btrfs: fix inode rwsem regression

2019-09-11 Thread Goldwyn Rodrigues
From: Goldwyn Rodrigues This is similar to 942491c9e6d6 ("xfs: fix AIM7 regression") Apparently our current rwsem code doesn't like doing the trylock, then lock for real scheme. So change our read/write methods to just do the trylock for the RWF_NOWAIT case. Fixes: edf064e7c6fe

Re: [f2fs-dev] [PATCH v11 10/63] xarray: Add xa_for_each

2018-04-22 Thread Goldwyn Rodrigues
On 04/20/2018 08:34 PM, Matthew Wilcox wrote: > On Fri, Apr 20, 2018 at 07:00:47AM -0500, Goldwyn Rodrigues wrote: >> This function name sounds like you are performing the operation for each >> tag. >> >> Can it be called xas_for_each_tagged() or xas_tag_for_ea

[f2fs-dev] [PATCH v11 19/63] page cache: Convert page deletion to XArray

2018-04-20 Thread Goldwyn Rodrigues
On 04/14/2018 09:12 AM, Matthew Wilcox wrote: > From: Matthew Wilcox > > The code is slightly shorter and simpler. > > Signed-off-by: Matthew Wilcox > --- > mm/filemap.c | 30 ++ > 1 file changed, 14 insertions(+), 16 deletions(-) > > diff --git a/mm/filemap.c b/

Re: [f2fs-dev] [PATCH v11 10/63] xarray: Add xa_for_each

2018-04-20 Thread Goldwyn Rodrigues
On 04/14/2018 09:12 AM, Matthew Wilcox wrote: > From: Matthew Wilcox > > This iterator allows the user to efficiently walk a range of the array, > executing the loop body once for each entry in that range that matches > the filter. This commit also includes xa_find() and xa_find_above() > whic

Re: [f2fs-dev] [PATCH v10 00/62] Convert page cache to XArray

2018-04-17 Thread Goldwyn Rodrigues
On 04/14/2018 02:58 PM, Matthew Wilcox wrote: > On Sat, Apr 14, 2018 at 12:50:30PM -0700, Matthew Wilcox wrote: >> On Mon, Apr 09, 2018 at 04:18:07PM -0500, Goldwyn Rodrigues wrote: >> >> I'm sorry I missed this email. My inbox is a disaster :( >> >>> I

[f2fs-dev] [PATCH v10 00/62] Convert page cache to XArray

2018-04-09 Thread Goldwyn Rodrigues
Hi Matthew, On 03/29/2018 10:41 PM, Matthew Wilcox wrote: > From: Matthew Wilcox > > I'd like to thank Andrew for taking the first eight XArray patches > into -next. He's understandably nervous about taking the rest of the > patches into -next given how few of the remaining patches have review

Re: [f2fs-dev] [PATCH v2] f2fs: add nowait aio support

2018-03-08 Thread Goldwyn Rodrigues
And xfstests generic/471 is passed. > > [1]: 6be96d "Introduce RWF_NOWAIT and FMODE_AIO_NOWAIT" > > Signed-off-by: Hyunchul Lee Looks good. Reviewed-by: Goldwyn Rodrigues > --- > Changes from v1: > - Return EGAIN if dio_rwsem is not lockable in f2f