Re: [f2fs-dev] fsck handling of inode incorrectly used as DIR and REG_FILE?

2015-03-27 Thread JP Abgrall
The 6 patches worked for my case. This one seems to have done the work: fsck.f2fs: remove inconsistent named directories [__chk_dentries: 804] [ 5]-[0x8] name[rJx8QtCT5u-dJsmZ4GOp2ahzwPs] len[0x1b] ino[0x24e49] type[0x2] [ASSERT] (sanity_check_nid: 296) --> mismatch name [0x24e49] [r

[f2fs-dev] fsck handling of inode incorrectly used as DIR and REG_FILE?

2015-03-26 Thread JP Abgrall
I have an image where an inode shows up once as an F2FS_FT_DIR and later as an F2FS_FT_REG_FILE. With fsck 1.4.1, This causes the i_blocks and i_link fix to toggle and the image is never fixed, leading to the kernel complaining. Any ideas on how to fix this? I'm tempted to have fsck track the t

[f2fs-dev] [PATCH] fsck.f2fs: add a missing 'fixed' during chk_dentries()

2014-11-13 Thread JP Abgrall
One of the cases would update the dentries but not set fixed=1 causing the update to not be written out. Change-Id: I111d599f93f7d5306dacd7d62da946fdb5c262ee Signed-off-by: JP Abgrall --- :100644 100644 78737d5... fa667dc... M fsck/fsck.c fsck/fsck.c | 1 + 1 file changed, 1 insertion(+) diff

[f2fs-dev] [fsck.f2fs] Not seeing the main bitmap getting written back out?

2014-11-13 Thread JP Abgrall
With a top-of-tree master f2fs-tools. 232ce7671ea505dfbb9f0ca7be74516ca9687a7b tries to fix the wrong segment types. Running fsck more than twice shows the same errors... # fsck.f2fs -f /dev/block/platform/sdhci-tegra.3/by-name/UDA ... [FIX] (f2fs_set_main_bitmap: 36) --> Wrong segment type [

Re: [f2fs-dev] Don't merge not sended patches

2014-11-09 Thread JP Abgrall
I agree. Next time, I'll remember to send the patches to this list. > On Mon, Nov 10, 2014 at 01:12:44PM +0900, Changman Lee wrote: >> Hi Jaegeuk, >> >> I've found new 2 patches when I pull f2fs-tools. >> The patches didn't show in mailing list. >> I think although patches is very trivial, it sho

Re: [f2fs-dev] [PATCH 1/2] dump.f2fs: support dump_file from image

2014-08-26 Thread JP Abgrall
> diff --git a/lib/libf2fs_io.c b/lib/libf2fs_io.c > index 5d9b68d..46b5484 100644 > --- a/lib/libf2fs_io.c > +++ b/lib/libf2fs_io.c > @@ -28,11 +28,11 @@ struct f2fs_configuration config; > /* > * IO interfaces > */ > -int dev_read(void *buf, __u64 offset, size_t len) > +int dev_read(void *bu

Re: [f2fs-dev] SELinux context not working

2014-06-19 Thread JP Abgrall
On Thu, Jun 19, 2014 at 8:33 AM, Jaegeuk Kim wrote: >> Any clues? > > If so, I suspect your sepolicy. > Could you give me the following results? I was stuck until: https://android-review.googlesource.com/#/c/96593/ --

[f2fs-dev] [PATCH] libf2fs: move the finalize_device() into the io lib.

2014-06-13 Thread JP Abgrall
This is required so that libf2fs.c can be used against any kind of device (E.g. an in-memory sparse file) just by linking against something that provides the libf2fs_io.c functions. libf2fs is currently libf2fs.c + libf2fs_io.c Signed-off-by: JP Abgrall --- lib/libf2fs.c| 12

Re: [f2fs-dev] [PATCH] libf2fs, fsck, mkfs: call f2fs_finalize_device before exit

2014-06-13 Thread JP Abgrall
On Fri, Jun 13, 2014 at 1:25 AM, Jaegeuk Kim wrote: > diff --git a/lib/libf2fs.c b/lib/libf2fs.c > index 6168c5c..8d6c670 100644 > --- a/lib/libf2fs.c > +++ b/lib/libf2fs.c > @@ -493,3 +493,15 @@ int f2fs_get_device_info(struct f2fs_configuration *c) > return 0; > } > > +void f2fs_finaliz

[f2fs-dev] [PATCH] mkfs: support passing in the number of sectors to use

2014-06-11 Thread JP Abgrall
Adds the optional sectors count: mkfs.f2fs [options] device [sectors] Change-Id: I3ac83121576574bda074140ffa60195a2bc9947b --- lib/libf2fs.c | 7 +++ mkfs/f2fs_format_main.c | 13 ++--- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/lib/libf2fs.c b/lib/li

[f2fs-dev] [PATCH] License tweak: LGPL v2.1 vs LGPL v2

2014-06-11 Thread JP Abgrall
, and (2) will operate properly with a modified version of the library, if the user installs one, as long as the modified version is interface-compatible with the version that the work was made with. Change-Id: Ic1a02ec5cfcb2bedda3d53f3061037e1e7437221 Signed-off-by: JP Abgrall --- CO