Re: [f2fs-dev] [PATCH] fs/writeback: convert wbc_account_cgroup_owner to take a folio

2024-09-30 Thread Jaegeuk Kim via Linux-f2fs-devel
On 09/26, Matthew Wilcox wrote: > On Thu, Sep 26, 2024 at 04:01:21PM +0200, Pankaj Raghav (Samsung) wrote: > > Convert wbc_account_cgroup_owner() to take a folio instead of a page, > > and convert all callers to pass a folio directly except f2fs. > > > > Convert the page to folio for all the calle

Re: [f2fs-dev] [GIT PULL] f2fs for 6.12-rc1

2024-09-24 Thread Jaegeuk Kim via Linux-f2fs-devel
On 09/24, Linus Torvalds wrote: > On Mon, 23 Sept 2024 at 19:42, Jaegeuk Kim wrote: > > > > In this series, the main changes include 1) converting major IO paths to use > > folio, and 2) adding various knobs to control GC more flexibly for Zoned > > devices. > > Hmm. I get mostly the same merge r

[f2fs-dev] [GIT PULL] f2fs for 6.12-rc1

2024-09-23 Thread Jaegeuk Kim via Linux-f2fs-devel
Hi Linus, Could you please consider this pull reuqest? Thanks, The following changes since commit c813111d19e65b6336a6352eae9c1ff5c40f722f: Merge tag 'slab-fixes-for-6.11-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab (2024-08-05 09:23:00 -0700) are available in the Git

Re: [f2fs-dev] [PATCH v2] f2fs: introduce device aliasing file

2024-09-23 Thread Jaegeuk Kim via Linux-f2fs-devel
On 09/24, Chao Yu wrote: > On 2024/9/23 23:53, Daeho Jeong wrote: > > From: Daeho Jeong > > > > F2FS should understand how the device aliasing file works and support > > deleting the file after use. A device aliasing file can be created by > > mkfs.f2fs tool and it can map the whole device with a

Re: [f2fs-dev] [PATCH] f2fs: introduce device aliasing file

2024-09-23 Thread Jaegeuk Kim via Linux-f2fs-devel
On 09/23, Chao Yu wrote: > On 2024/9/20 23:38, Daeho Jeong wrote: > > On Thu, Sep 19, 2024 at 6:14 AM Chao Yu wrote: > > > > > > On 2024/9/14 5:28, Daeho Jeong wrote: > > > > From: Daeho Jeong > > > > > > > > F2FS should understand how the device aliasing file works and support > > > > deleting

Re: [f2fs-dev] [PATCH v2 2/2] mkfs.f2fs: add device aliasing feature

2024-09-18 Thread Jaegeuk Kim via Linux-f2fs-devel
In file included from f2fs_format.c:14: f2fs_format.c: In function ‘allocate_blocks_for_aliased_device’: f2fs_format.c:1705:24: error: too few arguments to function ‘dev_write_block’ 1705 | ASSERT(dev_write_block(sit_blk, sit_blk_addr) >= 0); |^~~~

Re: [f2fs-dev] [PATCH 2/2] mkfs.f2fs: add device aliasing feature

2024-09-16 Thread Jaegeuk Kim via Linux-f2fs-devel
On 09/16, Daeho Jeong wrote: > On Fri, Sep 13, 2024 at 3:27 PM Jaegeuk Kim wrote: > > > > On 09/13, Daeho Jeong wrote: > > > From: Daeho Jeong > > > > > > We can add a device aliasing file which can map the whole device with an > > > extent, not using node blocks. This mapped area should be pinne

[f2fs-dev] [PATCH] f2fs: allow F2FS_IPU_NOCACHE for pinned file

2024-09-14 Thread Jaegeuk Kim via Linux-f2fs-devel
This patch allows f2fs to submit bios of in-place writes on pinned file. Signed-off-by: Jaegeuk Kim --- fs/f2fs/sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c index d18931b7b094..c56e8c873935 100644 --- a/fs/f2fs/sysfs.c +++ b/fs/f

Re: [f2fs-dev] [PATCH 2/2] mkfs.f2fs: add device aliasing feature

2024-09-13 Thread Jaegeuk Kim via Linux-f2fs-devel
On 09/13, Daeho Jeong wrote: > From: Daeho Jeong > > We can add a device aliasing file which can map the whole device with an > extent, not using node blocks. This mapped area should be pinned and > normally used for read-only usages. After finished using it, we can > deallocate the whole area an

Re: [f2fs-dev] [PATCH] f2fs: forcibly migrate to secure space for zoned device file pinning

2024-09-12 Thread Jaegeuk Kim via Linux-f2fs-devel
On 09/11, Daeho Jeong wrote: > From: Daeho Jeong > > We need to migrate data blocks even though it is full to secure space > for zoned device file pinning. > > Signed-off-by: Daeho Jeong > Fixes: 9703d69d9d15 ("f2fs: support file pinning for zoned devices") > --- > fs/f2fs/gc.c | 3 +-- > 1 fi

Re: [f2fs-dev] [PATCH v2] f2fs-tools: add write hint support

2024-09-10 Thread Jaegeuk Kim via Linux-f2fs-devel
+627,7 @@ static int __dev_write(void *buf, __u64 offset, size_t len, enum rw_hint whint) if (ret != -1) c.whint = whint; } +#endif if (write(fd, buf, len) < 0) return -1; On 09/07, Jaegeuk Kim via Linux-f2fs-devel wrot

Re: [f2fs-dev] [PATCH v2] f2fs-tools: add write hint support

2024-09-06 Thread Jaegeuk Kim via Linux-f2fs-devel
Applied this change for Android build. --- a/fsck/mount.c +++ b/fsck/mount.c @@ -4222,7 +4222,7 @@ int f2fs_sparse_initialize_meta(struct f2fs_sb_info *sbi) DBG(1, "\tSparse: filling sit area at block offset: 0x%08"PRIx64" len: %u\n",

Re: [f2fs-dev] [PATCH] Revert "f2fs: stop allocating pinned sections if EAGAIN happens"

2024-09-06 Thread Jaegeuk Kim via Linux-f2fs-devel
On 09/06, Chao Yu wrote: > On 2024/9/6 16:31, Wu Bo wrote: > > On Tue, Feb 20, 2024 at 02:50:11PM +0800, Chao Yu wrote: > > > On 2024/2/8 16:11, Wu Bo wrote: > > > > On 2024/2/5 11:54, Chao Yu wrote: > > > > > How about calling f2fs_balance_fs() to double check and make sure > > > > > there is > >

Re: [f2fs-dev] [RCF PATCH v3 09/10] inject.f2fs: add dentry injection

2024-09-03 Thread Jaegeuk Kim via Linux-f2fs-devel
On 09/03, Sheng Yong wrote: > Hi, Jaegeuk, > > I noticed that this commit is not queued in either dev or master branch. > Do you have any comments on this commit :-) Thanks, I missed. Let me queue in the branches. :) > > thanks, > shengyong > > On 2024/7/4 10:57, Sheng Yong wrote: > > This pat

Re: [f2fs-dev] [PATCH v2] f2fs: Do not check the FI_DIRTY_INODE flag when umounting a ro fs.

2024-09-03 Thread Jaegeuk Kim via Linux-f2fs-devel
On 09/03, Chao Yu wrote: > On 2024/9/2 21:01, Julian Sun wrote: > > On Mon, 2024-09-02 at 16:13 +0800, Chao Yu wrote: > > > > On 2024/8/29 0:54, Julian Sun wrote: > > > > > > Hi, all. > > > > > > > > > > > > Recently syzbot reported a bug as following: > > > > > > > > > > > > kernel BUG at fs/f2f

Re: [f2fs-dev] [PATCH] f2fs: Do not check the FI_DIRTY_INODE flag when umounting a ro fs.

2024-08-28 Thread Jaegeuk Kim via Linux-f2fs-devel
On 08/27, Julian Sun wrote: > Hi, all. > > Recently syzbot reported a bug as following: > > kernel BUG at fs/f2fs/inode.c:896! > CPU: 1 UID: 0 PID: 5217 Comm: syz-executor605 Not tainted > 6.11.0-rc4-syzkaller-00033-g872cf28b8df9 #0 > RIP: 0010:f2fs_evict_inode+0x1598/0x15c0 fs/f2fs/inode.c:896

Re: [f2fs-dev] [PATCH v2 2/4] f2fs: atomic: fix to not allow GC to pollute atomic_file

2024-08-28 Thread Jaegeuk Kim via Linux-f2fs-devel
On 08/14, Chao Yu wrote: > SQLite AppGC Thread Shrinker > - f2fs_ioc_start_atomic_write > > - f2fs_ioc_commit_atomic_write > - f2fs_commit_atomic_write > - filemap_write_and_wait_range > : write atomic_file's data to cow_inode >

[f2fs-dev] [PATCH] f2fs: guarantee to write dirty data when enabling checkpoint back

2021-09-08 Thread Jaegeuk Kim via Linux-f2fs-devel
From: Jaegeuk Kim commit 3d65293a52c2c3850c19b1e5115712e534d8 upstream. We must flush all the dirty data when enabling checkpoint back. Let's guarantee that first by adding a retry logic on sync_inodes_sb(). In addition to that, this patch adds to flush data in fsync when checkpoint is disab