Re: [f2fs-dev] [PATCH] f2fs: Fix the typos in comments

2025-06-17 Thread Luis Chamberlain via Linux-f2fs-devel
On Tue, Jun 17, 2025 at 05:40:47PM +, Swarna Prabhu wrote: > This patch fixes minor typos in comments in f2fs. > > Signed-off-by: Swarna Prabhu Reviewed-by: Luis Chamberlain Luis ___ Linux-f2fs-devel mailing list Linux-f

Re: [f2fs-dev] [PATCH] f2fs: Support enhanced hot/cold data separation for f2fs

2024-01-26 Thread Luis Chamberlain
On Fri, Jan 26, 2024 at 09:01:06PM +, Matthew Wilcox wrote: > On Thu, Jan 25, 2024 at 12:54:47PM -0800, Luis Chamberlain wrote: > > On Thu, Jan 25, 2024 at 08:47:39PM +, Matthew Wilcox wrote: > > > On Wed, Dec 07, 2022 at 12:51:13PM -0800, Luis Chamberlain wrote: > &g

Re: [f2fs-dev] [PATCH] f2fs: Support enhanced hot/cold data separation for f2fs

2024-01-25 Thread Luis Chamberlain
On Thu, Jan 25, 2024 at 08:47:39PM +, Matthew Wilcox wrote: > On Wed, Dec 07, 2022 at 12:51:13PM -0800, Luis Chamberlain wrote: > > On Wed, Nov 30, 2022 at 03:18:41PM +, Matthew Wilcox wrote: > > > From a filesystem point of view, you need to ensure that you handle folios

Re: [f2fs-dev] [PATCH 00/79] fs: new accessors for inode->i_ctime

2023-06-30 Thread Luis Chamberlain
On Wed, Jun 21, 2023 at 03:21:41PM -0400, Steven Rostedt wrote: > On Wed, 21 Jun 2023 10:45:05 -0400 > Jeff Layton wrote: > > > Most of this conversion was done via coccinelle, with a few of the more > > non-standard accesses done by hand. There should be no behavioral > > changes with this set.

Re: [f2fs-dev] [PATCH 01/79] fs: add ctime accessors infrastructure

2023-06-30 Thread Luis Chamberlain
t; them. In order to do that safely though, we'll need to eradicate raw > accesses of the inode->i_ctime field from the kernel. > > Add new accessor functions for the ctime that we can use to replace them. > > Signed-off-by: Jeff Layt

Re: [f2fs-dev] [PATCH 14/17] block: open code __generic_file_write_iter for blkdev writes

2023-05-24 Thread Luis Chamberlain
On Mon, Apr 24, 2023 at 07:49:23AM +0200, Christoph Hellwig wrote: > Open code __generic_file_write_iter to remove the indirect call into > ->direct_IO and to prepare using the iomap based write code. > > Signed-off-by: Christoph Hellwig > --- > block/fops.c | 46

Re: [f2fs-dev] [PATCH 17/17] fs: add CONFIG_BUFFER_HEAD

2023-04-30 Thread Luis Chamberlain
On Sat, Apr 29, 2023 at 02:20:17AM +0100, Matthew Wilcox wrote: > On Fri, Apr 28, 2023 at 05:11:57PM -0700, Luis Chamberlain wrote: > > [ 11.245248] BUG: kernel NULL pointer dereference, address: > > > > [ 11.254581] #PF: supervisor read

Re: [f2fs-dev] [PATCH 17/17] fs: add CONFIG_BUFFER_HEAD

2023-04-28 Thread Luis Chamberlain
On Mon, Apr 24, 2023 at 07:49:26AM +0200, Christoph Hellwig wrote: > +const struct address_space_operations def_blk_aops = { > + .dirty_folio= filemap_dirty_folio, > + .release_folio = iomap_release_folio, > + .invalidate_folio = iomap_invalidate_folio, > + .read_

Re: [f2fs-dev] [PATCH] f2fs: Support enhanced hot/cold data separation for f2fs

2022-12-07 Thread Luis Chamberlain
On Wed, Nov 30, 2022 at 03:18:41PM +, Matthew Wilcox wrote: > On Wed, Nov 30, 2022 at 08:48:04PM +0800, Yangtao Li wrote: > > Hi, > > > > > Thanks for reviewing this. I think the real solution to this is > > > that f2fs should be using large folios. That way, the page cache > > > will keep t

Re: [f2fs-dev] [PATCH 16/16] dm-zoned: ensure only power of 2 zone sizes are allowed

2022-04-28 Thread Luis Chamberlain
On Fri, Apr 29, 2022 at 06:43:58AM +0900, Damien Le Moal wrote: > On 4/29/22 02:34, Luis Chamberlain wrote: > > One step at a time. > > Yes, in general, I agree. But in this case, that will create kernel > versions that end up having partial support for zoned drives. Not ideal

Re: [f2fs-dev] [PATCH 16/16] dm-zoned: ensure only power of 2 zone sizes are allowed

2022-04-28 Thread Luis Chamberlain
On Thu, Apr 28, 2022 at 08:42:41AM +0900, Damien Le Moal wrote: > On 4/28/22 01:02, Pankaj Raghav wrote: > > From: Luis Chamberlain > > > > Today dm-zoned relies on the assumption that you have a zone size > > with a power of 2. Even though the block layer today en

Re: [f2fs-dev] [PATCH 04/16] block: allow blk-zoned devices to have non-power-of-2 zone size

2022-04-28 Thread Luis Chamberlain
On Thu, Apr 28, 2022 at 08:37:27AM +0900, Damien Le Moal wrote: > Also, the entire premise of this patch series is that it is hard for > people to support the unusable sectors between zone capacity and zone end > for drives with a zone capacity smaller than the zone size. > > Yet, here you do not

Re: [f2fs-dev] Baseline for f2fs

2022-04-20 Thread Luis Chamberlain
On Wed, Apr 20, 2022 at 11:12:33AM -0700, Jaegeuk Kim wrote: > On 04/19, Luis Chamberlain wrote: > > On Tue, Apr 19, 2022 at 4:26 PM Luis Chamberlain wrote: > > > Oh... so this is not upstream... I see.. ok hrm.. > > > > Any plans to try to upstream your delta?

Re: [f2fs-dev] Baseline for f2fs

2022-04-19 Thread Luis Chamberlain
On Tue, Apr 19, 2022 at 4:26 PM Luis Chamberlain wrote: > Oh... so this is not upstream... I see.. ok hrm.. Any plans to try to upstream your delta? Luis ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net ht

Re: [f2fs-dev] Baseline for f2fs

2022-04-19 Thread Luis Chamberlain
On Tue, Apr 19, 2022 at 4:03 PM Jaegeuk Kim wrote: > > On 04/19, Luis Chamberlain wrote: > > On Tue, Apr 19, 2022 at 3:42 PM Jaegeuk Kim wrote: > > > > > > On 04/19, Luis Chamberlain wrote: > > > > I'm going to add automation support for f2fs withi

Re: [f2fs-dev] Baseline for f2fs

2022-04-19 Thread Luis Chamberlain
On Tue, Apr 19, 2022 at 3:42 PM Jaegeuk Kim wrote: > > On 04/19, Luis Chamberlain wrote: > > I'm going to add automation support for f2fs within kdevops [0]. This > > should enable folks to test for regressions for f2fs from scratch with > > just a few commands. Bef

[f2fs-dev] Baseline for f2fs

2022-04-19 Thread Luis Chamberlain
I'm going to add automation support for f2fs within kdevops [0]. This should enable folks to test for regressions for f2fs from scratch with just a few commands. Before I go ahead and add that I was curious if folks have a known baseline of known failures from fstests for f2fs so I can expunge the

Re: [f2fs-dev] [PATCH 2/3] libf2fs: add support to report zone size

2022-04-12 Thread Luis Chamberlain
On Tue, Apr 12, 2022 at 12:14:13PM +, Damien Le Moal wrote: > On Tue, 2022-04-12 at 13:27 +0200, Pankaj Raghav wrote: > > From: Luis Chamberlain > > > > Expand get_device_info() to report the zone size. > > This is now important give power of 2 zone sizees (PO2)