Re: [f2fs-dev] [PATCH 09/12] fs: factor out a direct_write_fallback helper

2023-05-31 Thread Miklos Szeredi via Linux-f2fs-devel
On Wed, 31 May 2023 at 09:50, Christoph Hellwig wrote: > > Add a helper dealing with handling the syncing of a buffered write fallback > for direct I/O. > > Signed-off-by: Christoph Hellwig Reviewed-by: Miklos Szeredi ___ Linux-f2fs-devel mailing li

Re: [f2fs-dev] [PATCH 10/12] fuse: update ki_pos in fuse_perform_write

2023-05-31 Thread Miklos Szeredi via Linux-f2fs-devel
On Wed, 31 May 2023 at 09:51, Christoph Hellwig wrote: > > Both callers of fuse_perform_write need to updated ki_pos, move it into > common code. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Damien Le Moal > --- > fs/fuse/file.c | 23 ++- > 1 file changed, 10 insertio

Re: [f2fs-dev] [PATCH 12/12] fuse: use direct_write_fallback

2023-05-31 Thread Miklos Szeredi via Linux-f2fs-devel
On Wed, 31 May 2023 at 09:51, Christoph Hellwig wrote: > > Use the generic direct_write_fallback helper instead of duplicating the > logic. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Damien Le Moal > --- > fs/fuse/file.c | 24 ++-- > 1 file changed, 2 insertions(+),

Re: [f2fs-dev] [PATCH 11/11] fuse: drop redundant arguments to fuse_perform_write

2023-05-24 Thread Miklos Szeredi via Linux-f2fs-devel
On Wed, 24 May 2023 at 08:38, Christoph Hellwig wrote: > > pos is always equal to iocb->ki_pos, and mapping is always equal to > iocb->ki_filp->f_mapping. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Damien Le Moal Acked-by: Miklos Szeredi _

Re: [f2fs-dev] [PATCH 10/11] fuse: update ki_pos in fuse_perform_write

2023-05-24 Thread Miklos Szeredi via Linux-f2fs-devel
On Wed, 24 May 2023 at 08:38, Christoph Hellwig wrote: > > Both callers of fuse_perform_write need to updated ki_pos, move it into > common code. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Damien Le Moal > --- > fs/fuse/file.c | 25 +++-- > 1 file changed, 11 insert

Re: [f2fs-dev] [PATCH 09/11] fs: factor out a direct_write_fallback helper

2023-05-24 Thread Miklos Szeredi via Linux-f2fs-devel
On Wed, 24 May 2023 at 08:38, Christoph Hellwig wrote: > > Add a helper dealing with handling the syncing of a buffered write fallback > for direct I/O. > > Signed-off-by: Christoph Hellwig > --- > fs/libfs.c | 36 + > include/linux/fs.h | 2 ++ > mm/filemap.c

Re: [f2fs-dev] [PATCH 10/13] fs: factor out a direct_write_fallback helper

2023-05-22 Thread Miklos Szeredi via Linux-f2fs-devel
On Fri, 19 May 2023 at 11:36, Christoph Hellwig wrote: > > Add a helper dealing with handling the syncing of a buffered write fallback > for direct I/O. > > Signed-off-by: Christoph Hellwig > --- > fs/libfs.c | 36 > include/linux/fs.h | 2 ++ > mm/filemap.c