Re: [f2fs-dev] [PATCH v14 00/74] Convert page cache to XArray

On Wed, Jul 25, 2018 at 02:03:23PM -0700, Matthew Wilcox wrote: > On Wed, Jun 27, 2018 at 01:44:38PM -0600, Ross Zwisler wrote: > > On Wed, Jun 27, 2018 at 04:05:29AM -0700, Matthew Wilcox wrote: > > > On Tue, Jun 19, 2018 at 10:16:38AM -0700, Matthew Wilcox wrote: > >

Re: [f2fs-dev] [PATCH v14 00/74] Convert page cache to XArray

On Wed, Jul 25, 2018 at 02:03:23PM -0700, Matthew Wilcox wrote: > On Wed, Jun 27, 2018 at 01:44:38PM -0600, Ross Zwisler wrote: > > On Wed, Jun 27, 2018 at 04:05:29AM -0700, Matthew Wilcox wrote: > > > On Tue, Jun 19, 2018 at 10:16:38AM -0700, Matthew Wilcox wrote: > >

Re: [f2fs-dev] [PATCH v14 68/74] dax: Convert dax_lock_page to XArray

On Sat, Jun 16, 2018 at 07:00:46PM -0700, Matthew Wilcox wrote: > Signed-off-by: Matthew Wilcox > --- <> > +static void *dax_make_page_entry(struct page *page, void *entry) > +{ > + pfn_t pfn = page_to_pfn_t(page); > + return dax_make_entry(pfn, dax_is_pmd_entry(entry)); > +} This

Re: [f2fs-dev] [PATCH v14 00/74] Convert page cache to XArray

On Thu, Jun 28, 2018 at 01:39:09AM -0700, Matthew Wilcox wrote: > On Wed, Jun 27, 2018 at 01:44:38PM -0600, Ross Zwisler wrote: > > On Wed, Jun 27, 2018 at 04:05:29AM -0700, Matthew Wilcox wrote: > > > On Tue, Jun 19, 2018 at 10:16:38AM -0700, Matthew Wilcox wrote: > >

Re: [f2fs-dev] [PATCH v14 00/74] Convert page cache to XArray

On Wed, Jun 27, 2018 at 04:05:29AM -0700, Matthew Wilcox wrote: > On Tue, Jun 19, 2018 at 10:16:38AM -0700, Matthew Wilcox wrote: > > I think I see a bug. No idea if it's the one you're hitting ;-) > > > > I had been intending to not use the 'entry' to decide whether we were > > waiting on a 2MB

Re: [f2fs-dev] [PATCH v14 00/74] Convert page cache to XArray

On Tue, Jun 19, 2018 at 02:22:30AM -0700, Matthew Wilcox wrote: > On Mon, Jun 18, 2018 at 09:12:57PM -0600, Ross Zwisler wrote: > > Hit another deadlock. This one reproduces 100% of the time in my setup with > > XFS + DAX + generic/340. It doesn't reproduce for me at all with &g

Re: [f2fs-dev] [PATCH v14 00/74] Convert page cache to XArray

On Sat, Jun 16, 2018 at 06:59:38PM -0700, Matthew Wilcox wrote: > The XArray is a replacement for the radix tree. For the moment it uses > the same data structures, enabling a gradual replacement. This patch > set implements the XArray and converts the page cache to use it. > > A version of

Re: [f2fs-dev] [PATCH v13 00/72] Convert page cache to XArray

On Tue, Jun 12, 2018 at 12:46:19PM -0700, Matthew Wilcox wrote: > On Tue, Jun 12, 2018 at 01:37:41PM -0600, Ross Zwisler wrote: > > On Tue, Jun 12, 2018 at 04:31:22AM -0700, Matthew Wilcox wrote: > > > On Tue, Jun 12, 2018 at 12:40:41PM +0200, David Sterba wrote: > > >

Re: [f2fs-dev] [PATCH v13 00/72] Convert page cache to XArray

On Tue, Jun 12, 2018 at 04:31:22AM -0700, Matthew Wilcox wrote: > On Tue, Jun 12, 2018 at 12:40:41PM +0200, David Sterba wrote: > > [ 9875.174796] kernel BUG at fs/inode.c:513! > > What the ... > > Somehow the fix for that got dropped. I spent most of last week chasing > that problem! This is

Re: [f2fs-dev] [PATCH v11 00/63] Convert page cache to XArray

On Thu, May 31, 2018 at 02:46:12PM -0700, Matthew Wilcox wrote: > On Thu, May 31, 2018 at 03:37:42PM -0600, Ross Zwisler wrote: > > Never mind, just saw your mail from a few weeks ago. :-/ I'll retest on my > > end. > > Don't strain too hard; I found (and fixed)

Re: [f2fs-dev] [PATCH v11 00/63] Convert page cache to XArray

On Thu, May 31, 2018 at 03:36:43PM -0600, Ross Zwisler wrote: > On Mon, Apr 16, 2018 at 10:01:33AM -0600, Ross Zwisler wrote: > > On Sat, Apr 14, 2018 at 07:12:13AM -0700, Matthew Wilcox wrote: > > > From: Matthew Wilcox > > > > > > This conversion keeps the r

Re: [f2fs-dev] [PATCH v11 00/63] Convert page cache to XArray

On Mon, Apr 16, 2018 at 10:01:33AM -0600, Ross Zwisler wrote: > On Sat, Apr 14, 2018 at 07:12:13AM -0700, Matthew Wilcox wrote: > > From: Matthew Wilcox > > > > This conversion keeps the radix tree and XArray data structures in sync > > at all times. That allows us to

Re: [f2fs-dev] [PATCH v11 53/63] dax: Rename some functions

On Mon, May 21, 2018 at 03:11:39AM -0700, Matthew Wilcox wrote: > On Sun, May 20, 2018 at 10:42:36PM -0600, Ross Zwisler wrote: > > > @@ -1519,15 +1517,14 @@ int dax_iomap_fault(struct vm_fault *vmf, enum > > > page_entry_size pe_size, > > > } > >

Re: [f2fs-dev] [PATCH v11 54/63] dax: Hash on XArray instead of mapping

On Mon, May 21, 2018 at 03:25:24AM -0700, Matthew Wilcox wrote: > On Sun, May 20, 2018 at 10:47:56PM -0600, Ross Zwisler wrote: > > On Sat, Apr 14, 2018 at 07:13:07AM -0700, Matthew Wilcox wrote: > > > From: Matthew Wilcox <mawil...@microsoft.com> > > > &

Re: [f2fs-dev] [PATCH v11 54/63] dax: Hash on XArray instead of mapping

On Sat, Apr 14, 2018 at 07:13:07AM -0700, Matthew Wilcox wrote: > From: Matthew Wilcox > > Since the XArray is embedded in the struct address_space, this contains > exactly as much entropy as the address of the mapping. I agree that they both have the same amount of

Re: [f2fs-dev] [PATCH v11 53/63] dax: Rename some functions

On Sat, Apr 14, 2018 at 07:13:06AM -0700, Matthew Wilcox wrote: > From: Matthew Wilcox > > Remove mentions of 'radix' and 'radix tree'. Simplify some names by > dropping the word 'mapping'. > > Signed-off-by: Matthew Wilcox > @@ -74,18 +74,18

Re: [f2fs-dev] [PATCH v11 51/63] dax: Fix use of zero page

t.com> Feel free to add my: Reviewed-by: Ross Zwisler <ross.zwis...@linux.intel.com> To this version as well if you keep this patch in the larger series. -- Check out the vibrant tech community on one of

Re: [f2fs-dev] [PATCH v11 00/63] Convert page cache to XArray

On Sat, Apr 14, 2018 at 07:12:13AM -0700, Matthew Wilcox wrote: > From: Matthew Wilcox > > This conversion keeps the radix tree and XArray data structures in sync > at all times. That allows us to convert the page cache one function at > a time and should allow for

Re: [f2fs-dev] [PATCH v4 00/73] XArray version 4

On Tue, Dec 05, 2017 at 04:40:46PM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > I looked through some notes and decided this was version 4 of the XArray. > Last posted two weeks ago, this version includes a *lot* of changes. > I'd like to thank Dave Chinner for

Re: [f2fs-dev] [PATCH v3 06/20] dax: set errors in mapping when writeback fails

On Mon, Apr 24, 2017 at 09:22:45AM -0400, Jeff Layton wrote: > In order to get proper error codes from fsync, we must set an error in > the mapping range when writeback fails. > > Signed-off-by: Jeff Layton <jlay...@redhat.com> Works fine in some error injection testing. Teste

Re: [f2fs-dev] [PATCH 37/45] drivers: use req op accessor

On Sun, Jun 5, 2016 at 1:32 PM, wrote: > From: Mike Christie > > The req operation REQ_OP is separated from the rq_flag_bits > definition. This converts the block layer drivers to > use req_op to get the op from the request struct. > > Signed-off-by:

Re: [f2fs-dev] [PATCH 42/45] block, fs, drivers: remove REQ_OP compat defs and related code

On Sun, Jun 5, 2016 at 1:32 PM, wrote: > From: Mike Christie > > This patch drops the compat definition of req_op where it matches > the rq_flag_bits definitions, and drops the related old and compat > code that allowed users to set either the op or