parent ino is [0x4]
Rename sets LOST_PINO for old_inode. However, the flag cannot be cleared,
since dir is written back with CP. So, let's get rid of LOST_PINO for a
renamed dir and fix the pino directly at the end of rename.
Signed-off-by: Sheng Yong
---
fs/f2fs/namei.c | 5 -
Since directories will be written back with checkpoint and fsync a
directory will always write CP, there is no need to set LOST_PINO
after creating a directory.
Signed-off-by: Sheng Yong
---
fs/f2fs/dir.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/dir.c b/fs
Hi, Jaegeuk
On 2017/7/1 23:10, Jaegeuk Kim wrote:
Hi,
On 06/26, Sheng Yong wrote:
After renaming a directory, fsck could detect unmatched pino. The scenario
can be reproduced as the following:
$ mkdir /bar/subbar /foo
$ rename /bar/subbar /foo
Then fsck will report:
[ASSERT
f2fs_iget checks if i_mode is valid. If it is not, the file cannot be
accessed as well as deleted. To make sure such files can be removed,
fsck adds the same check, and removes incorrect inode blocks.
Signed-off-by: Sheng Yong
---
fsck/fsck.c | 21 +
fsck/mount.c | 4
Commit 7d96d138a378 ("fsck.f2fs: remove list.h") has already the usage
of list.h. So let's remove list.h itself.
Signed-off-by: Sheng Yong
---
include/list.h | 88 --
1 file changed, 88 deletions(-)
delete mode 100644 inclu
With --dry-run enabled, fsck.f2fs will do all checks and "fixes" except
that all fixes will not be written to storage at last.
Signed-off-by: Sheng Yong
---
fsck/main.c | 14 +-
include/f2fs_fs.h | 1 +
lib/libf2fs.c | 1 +
lib/libf2fs_io.c | 3 +++
4 files c
This patch exports read_all_xattrs to allow dump/fsck to get all xattrs,
and introduces print_xattr_entry which tries to parse an xattr entry
accroding to its xattr index.
Signed-off-by: Sheng Yong
---
fsck/dump.c | 18 -
fsck/fsck.h | 7 +++-
fsck/mount.c | 127
Fixing corrupted data depends on c.fix_on. If it's not set, we should not
force fixing corrupted data. So if nat entries are found invalid when
building nat_area_bitmap, we should just set c.bug_on, and fix it later.
Signed-off-by: Sheng Yong
---
fsck/mount.c | 21 ++---
1
If a file is encrypted, its content is cipher text on the storage. So
there is no need to dump an encrypted file.
Signed-off-by: Sheng Yong
---
fsck/dump.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/fsck/dump.c b/fsck/dump.c
index 01889fd..d11e8e2 100644
This patch introduces dump_xattr to create xattrs for dumped files.
Signed-off-by: Sheng Yong
---
fsck/dump.c | 63 ++---
1 file changed, 60 insertions(+), 3 deletions(-)
diff --git a/fsck/dump.c b/fsck/dump.c
index 90fd073..01889fd
Do not set fix_on if it is allowed by user.
Signed-off-by: Sheng Yong
---
fsck/main.c | 2 +-
fsck/mount.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fsck/main.c b/fsck/main.c
index c9411eb..93037e1 100644
--- a/fsck/main.c
+++ b/fsck/main.c
@@ -429,7 +429,7
Hi, Chao
On 2017/10/31 15:20, Chao Yu wrote:
On 2017/10/31 9:38, Sheng Yong wrote:
Fixing corrupted data depends on c.fix_on. If it's not set, we should not
force fixing corrupted data. So if nat entries are found invalid when
building nat_area_bitmap, we should just set c.bug_on, and f
On 2017/10/31 15:51, Chao Yu wrote:
On 2017/10/31 9:38, Sheng Yong wrote:
[...]
+
+void print_xattr_entry(struct f2fs_xattr_entry *ent)
+{
+ char *value = (char *)(ent->e_name + le16_to_cpu(ent->e_name_len));
+ struct fscrypt_context *ctx;
+ int i;
+
+ MSG(0, &q
On 2017/10/31 15:51, Chao Yu wrote:
On 2017/10/31 9:38, Sheng Yong wrote:
This patch introduces dump_xattr to create xattrs for dumped files.
Signed-off-by: Sheng Yong
---
fsck/dump.c | 63 ++---
1 file changed, 60 insertions(+), 3
On 2017/10/31 15:57, Chao Yu wrote:
On 2017/10/31 9:38, Sheng Yong wrote:
If a file is encrypted, its content is cipher text on the storage. So
there is no need to dump an encrypted file.
IMO, if user have encryption key, it still has chance to read that file,
right? So how about keeping
On 2017/10/31 15:57, Chao Yu wrote:
On 2017/10/31 9:38, Sheng Yong wrote:
With --dry-run enabled, fsck.f2fs will do all checks and "fixes" except
that all fixes will not be written to storage at last.
Signed-off-by: Sheng Yong
---
fsck/main.c | 14 +-
include
On 2017/10/31 16:04, Chao Yu wrote:
On 2017/10/31 9:38, Sheng Yong wrote:
f2fs_iget checks if i_mode is valid. If it is not, the file cannot be
accessed as well as deleted. To make sure such files can be removed,
fsck adds the same check, and removes incorrect inode blocks.
Signed-off-by
On 2017/10/31 15:06, Chao Yu wrote:
On 2017/10/31 9:38, Sheng Yong wrote:
Do not set fix_on if it is allowed by user.
Signed-off-by: Sheng Yong
---
fsck/main.c | 2 +-
fsck/mount.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fsck/main.c b/fsck/main.c
index
This patch introduces dump_xattr to create xattrs for dumped files.
Signed-off-by: Sheng Yong
---
fsck/dump.c | 63 ++---
1 file changed, 60 insertions(+), 3 deletions(-)
diff --git a/fsck/dump.c b/fsck/dump.c
index 90fd073..3d64cb7
f2fs_iget checks if i_mode is valid. If it is not, the file cannot be
accessed as well as deleted. To make sure such files can be removed,
fsck adds the same check, and removes incorrect inode blocks.
Signed-off-by: Sheng Yong
---
fsck/fsck.c | 21 +
1 file changed, 21
If a file is encrypted, its content is cipher text on the storage. So
there is no need to dump an encrypted file.
Signed-off-by: Sheng Yong
Reviewed-by: Chao Yu
---
fsck/dump.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/fsck/dump.c b/fsck/dump.c
index
v1-v2:
[PATCH 3] print values of USER/SECRUITY xattr as hex instead of plain text.
[PATCH 4] replace xattr value if it already exists by setting parameter
`flags' as 0 of fsetxattr.
[PATCH 1/7] move message printing modification into a different patch.
thanks,
Sheng
Sheng Yo
Commit 7d96d138a378 ("fsck.f2fs: remove list.h") has already the usage
of list.h. So let's remove list.h itself.
Signed-off-by: Sheng Yong
Reviewed-by: Chao Yu
---
include/list.h | 88 --
1 file changed, 88 deletions(
This patch removes an extra '\n' at the end of the string in FIX_MSG.
Signed-off-by: Sheng Yong
---
fsck/fsck.c | 4 ++--
fsck/mount.c | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/fsck/fsck.c b/fsck/fsck.c
index 77490d8..1905319 100644
--- a/fsck/fsck.c
With --dry-run enabled, fsck.f2fs will do all checks and "fixes" except
that all fixes will not be written to storage at last.
Signed-off-by: Sheng Yong
Reviewed-by: Chao Yu
---
fsck/main.c | 14 +-
include/f2fs_fs.h | 1 +
lib/libf2fs.c | 1 +
lib/libf2fs_
Do not set fix_on if it is allowed by user.
Signed-off-by: Sheng Yong
---
fsck/main.c | 2 +-
fsck/mount.c | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/fsck/main.c b/fsck/main.c
index c9411eb..93037e1 100644
--- a/fsck/main.c
+++ b/fsck/main.c
@@ -429,7 +429,7 @@ static
This patch exports read_all_xattrs to allow dump/fsck to get all xattrs,
and introduces print_xattr_entry which tries to parse an xattr entry
accroding to its xattr index.
Signed-off-by: Sheng Yong
---
fsck/dump.c | 18 -
fsck/fsck.h | 7 +++-
fsck/mount.c | 123
Fixing corrupted data depends on c.fix_on. If it's not set, we should not
force fixing corrupted data. So if nat entries are found invalid when
building nat_area_bitmap, we should just set c.bug_on, and fix it later.
Signed-off-by: Sheng Yong
Reviewed-by: Chao Yu
---
fsck/mount.c
This patch exports read_all_xattrs to allow dump/fsck to get all xattrs,
and introduces print_xattr_entry which tries to parse an xattr entry
accroding to its xattr index.
Signed-off-by: Sheng Yong
---
v2->v3:
check if is supported. If it is not, print ACL value
in hex format.
configure
This patch exports read_all_xattrs to allow dump/fsck to get all xattrs,
and introduces print_xattr_entry which tries to parse an xattr entry
accroding to its xattr index.
Signed-off-by: Sheng Yong
---
v3->v4:
Please ignore the previous [PATCH v3] because of the bad indent. Sorry
for the no
This patch exports read_all_xattrs to allow dump/fsck to get all xattrs,
and introduces print_xattr_entry which tries to parse an xattr entry
accroding to its xattr index.
Signed-off-by: Sheng Yong
---
v3->v5:
Please ignore the previous [PATCH v3/v4] because of the bad indent (some
configure
0m01.94s user 0m50.80s system
enable readdir_ra: 0m18.55s real 0m00.44s user 0m15.39s system
Signed-off-by: Sheng Yong
---
Documentation/ABI/testing/sysfs-fs-f2fs | 6 ++
fs/f2fs/dir.c | 4
fs/f2fs/f2fs.h | 1 +
fs
If there is not enough space left, f2fs_preallocate_blocks may only
preallocte partial blocks. As a result, the write operation fails
but i_blocks is not 0. To avoid this, f2fs should write data in
non-preallocation way and write as many data as the size of i_blocks.
Signed-off-by: Sheng Yong
Commit d260081ccf37 ("f2fs: change recovery policy of xattr node block")
removes the use of blkaddr, which is no longer used. So remove the
parameter.
Signed-off-by: Sheng Yong
---
fs/f2fs/f2fs.h | 3 +--
fs/f2fs/node.c | 2 +-
fs/f2fs/recovery.c | 6 +++---
3 files
On 2017/12/15 14:25, Yunlong Song wrote:
Signed-off-by: Yunlong Song
---
fsck/fsck.c | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/fsck/fsck.c b/fsck/fsck.c
index 2212aa3..8ff4e4b 100644
--- a/fsck/fsck.c
+++ b/fsck/fsck.c
@@ -643,7 +643,7 @@ void
On 2017/12/15 14:26, Yunlong Song wrote:
Signed-off-by: Yunlong Song
---
fsck/fsck.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/fsck/fsck.c b/fsck/fsck.c
index 11b8b0b..2212aa3 100644
--- a/fsck/fsck.c
+++ b/fsck/fsck.c
@@ -14,6 +14,15 @@
char *tree_ma
to provide an option for user to decide if the readahead is
needed.
thanks,
Sheng
On Thu, Nov 23, 2017 at 10:11 PM, Chao Yu wrote:
On 2017/11/22 18:23, Sheng Yong wrote:
This patch introduces a sysfs interface readdir_ra to enable/disable
readaheading inode block in f2fs_readdir. When readd
If seed is not set, rand always uses 1 as the default seed.
Signed-off-by: Liu Xue
Signed-off-by: Sheng Yong
---
mkfs/f2fs_format.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
index a130001..9d7e180 100644
--- a/mkfs/f2fs_format.c
+++ b/mkfs
Signed-off-by: Sheng Yong
---
fsck/mount.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fsck/mount.c b/fsck/mount.c
index 971fc5a..52dd6c3 100644
--- a/fsck/mount.c
+++ b/fsck/mount.c
@@ -2353,7 +2353,7 @@ int f2fs_do_mount(struct f2fs_sb_info *sbi
For dentry name, we should check if parent directory is encrypted. If it
is, show digest-encoded name instead of cipher text when unlink corrupted
dir entries.
Signed-off-by: Sheng Yong
---
fsck/fsck.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fsck/fsck.c b
e_work+0x3a7/0x6f0
[ 246.756533] worker_thread+0x82/0x750
[ 246.756537] kthread+0x16f/0x1c0
[ 246.756541] ? trace_event_raw_event_workqueue_work+0x110/0x110
[ 246.756544] ? kthread_create_worker_on_cpu+0xb0/0xb0
[ 246.756548] ret_from_fork+0x1f/0x30
Signed-off-by: Sheng Yong
---
fs/f2fs/gc.c | 11 +
Signed-off-by: Sheng Yong
---
v2->v1: do not change the index in meta inode
make move_data_block aware EAGAIN error
---
fs/f2fs/gc.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 33e79697e41c..aa720cc44509 100644
--- a/fs/f2fs/gc
sb_getblk does not guarantee the buffer head is uptodate. If bh is not
uptodate, the data (may be used as boot code) in area before
F2FS_SUPER_OFFSET may get corrupted when super block is committed.
Signed-off-by: Sheng Yong
---
fs/f2fs/super.c | 4 ++--
1 file changed, 2 insertions(+), 2
Hi, Chao
On 2018/1/29 16:27, Chao Yu wrote:
On 2018/1/29 16:04, Sheng Yong wrote:
sb_getblk does not guarantee the buffer head is uptodate. If bh is not
uptodate, the data (may be used as boot code) in area before
Why boot code can be stored into the position f2fs superblock locates
On 2018/1/29 16:58, Chao Yu wrote:
Hi Sheng Yong,
On 2018/1/29 16:39, Sheng Yong wrote:
Hi, Chao
On 2018/1/29 16:27, Chao Yu wrote:
On 2018/1/29 16:04, Sheng Yong wrote:
sb_getblk does not guarantee the buffer head is uptodate. If bh is not
uptodate, the data (may be used as boot code) in
sb_getblk does not guarantee the buffer head is uptodate. If bh is not
uptodate, the data (may be used as boot code) in area before
F2FS_SUPER_OFFSET may get corrupted when super block is committed.
Signed-off-by: Sheng Yong
---
fs/f2fs/super.c | 5 ++---
1 file changed, 2 insertions(+), 3
.
Signed-off-by: Sheng Yong
---
include/f2fs_fs.h | 5 +
mkfs/f2fs_format.c | 46 +-
2 files changed, 22 insertions(+), 29 deletions(-)
diff --git a/include/f2fs_fs.h b/include/f2fs_fs.h
index 548a3e8..ca4522d 100644
--- a/include/f2fs_fs.h
+++ b
[Fail]
[FIX] (nullify_nat_entry:2064) --> Remove nid [0xb] in NAT
[FIX] (nullify_nat_entry:2064) --> Remove nid [0xf] in NAT
Info: Write valid nat_bits in checkpoint
Done.
$ tree /data
/data/
└── lost+found
├── 12
├── 14
├── 16
└── 6
Any comments and tests are app
In sanity_check_nid, __check_inode_mode will check i_mode value of an
inode. So integrate sanity_check_inode to __check_inode_mode to clean
up the code.
Signed-off-by: Sheng Yong
---
fsck/fsck.c | 26 +-
1 file changed, 5 insertions(+), 21 deletions(-)
diff --git a/fsck
root directory cannot be encrypted. So if lost+found
feature is enabled, let's avoid to encrypt root directory.
Signed-off-by: Sheng Yong
---
fs/f2fs/f2fs.h | 2 ++
fs/f2fs/super.c | 12
2 files changed, 14 insertions(+)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
.
4. If reconnect fails drop the node and restore filesystem metadata.
Signed-off-by: Sheng Yong
---
fsck/dir.c | 19 ++-
fsck/fsck.c | 376 ++-
fsck/fsck.h | 3 +
fsck/mount.c | 2 +
4 files changed, 397 insertions(+), 3 dele
This patch introduces F2FS_FEATURE_FUNCS to clean up the definitions of
different f2fs_sb_has_xxx functions.
Signed-off-by: Sheng Yong
---
fs/f2fs/data.c| 2 +-
fs/f2fs/f2fs.h| 51 +--
fs/f2fs/file.c| 6 +++---
fs/f2fs/segment.c | 4
This patchset introduces lost+found feature in f2fs. If the feature is
enabled, f2fs should avoid to encrypting root directory.
For more information, please check the mail "f2fs-tools: introduce lost+
found feature".
Thanks,
Sheng
Sheng Yong (2):
f2fs: clean up f2fs_sb_has_xxx
ed to
save unreachable files, which have no parent directory or their parent
directory is removed by fsck. Encrypted files are also allowed to be
saved here.
Signed-off-by: Sheng Yong
---
fsck/mount.c| 3 +
include/f2fs_fs.h | 6 ++
mkfs/f2fs_format.c
Signed-off-by: Sheng Yong
---
lib/libf2fs.c | 18 ++
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/lib/libf2fs.c b/lib/libf2fs.c
index e8b1842..0c684d5 100644
--- a/lib/libf2fs.c
+++ b/lib/libf2fs.c
@@ -586,24 +586,17 @@ void f2fs_init_configuration(void
On 2018/2/6 12:31, Sheng Yong wrote:
This patch introduces lost+found feature to fsck. If a file is found
unreachable by fsck. Fsck tries to reconnect the file to lost+found
directory:
1. Scan all unreachable file inodes, ignore non-inodes ones and
directories.
2. Check them and fix
On 2018/2/7 18:01, Sheng Yong wrote:
[...]
+
+/* lookup lost+found in root directory */
+lpf_ino = f2fs_lookup(sbi, node, (u8 *) LPF, strlen(LPF));
The 4th parameter should be namelen but not strlen(LPF).
Sorry for the noise. The comment here is wrong :(
[...]
+
+static int
Hi, Chao
Add Hyojun.
On 2018/2/8 21:30, Chao Yu wrote:
On 2018/2/6 12:31, Sheng Yong wrote:
/* only root inode was written before truncating dnodes */
last_inode_pos = start_inode_pos +
- c.cur_seg[CURSEG_HOT_NODE] * c.blks_per_seg + quota_inum
Hi, Chao
On 2018/2/8 23:08, Chao Yu wrote:
On 2018/2/6 12:31, Sheng Yong wrote:
This patch introduces a new feature F2FS_FEATURE_LOST_FOUND. It can be
switched on by indicating a new option `lost+found' with -O. If
Not sure, do we need to change this option to 'lost_found'
Hi, Chao
On 2018/2/8 21:29, Chao Yu wrote:
On 2018/2/6 12:31, Sheng Yong wrote:
Introduce lost+found feature. The lost+found is a directory which saves
Nitpick, lost_found feature...
Needs to add /sys/fs/f2fs/features/lost_found sysfs entry, and show
'lost_found' in /sys/fs/f2fs
Hi, Jaegeuk
On 2018/2/10 10:50, Jaegeuk Kim wrote:
On 02/06, Sheng Yong wrote:
This patchset introduces lost+found feature in f2fs. If the feature is
enabled, f2fs should avoid to encrypting root directory.
In that case, we need to add test_dummy_encryption likewise ext4.
If the
nat_entry->blk_addr of dir [PASS]
Any comments and tests are appreciated.
Thanks,
Sheng
Sheng Yong (7):
fsck.f2fs: fix typo
mkfs.f2fs: introduce mkfs parameters in f2fs_configuration
f2fs-tools: init f2fs_configuration as 0
fsck.f2fs: integrate sanity_check_inode to __check_inode_mode
mkfs
Signed-off-by: Sheng Yong
---
fsck/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fsck/main.c b/fsck/main.c
index 804f71a..bbf82c3 100644
--- a/fsck/main.c
+++ b/fsck/main.c
@@ -137,7 +137,7 @@ static void error_out(char *prog)
else if (!strcmp("sload
which have no parent directory or their parent
directory is removed by fsck. Encrypted files are also allowed to be
saved here.
Signed-off-by: Sheng Yong
---
fsck/mount.c| 3 +
include/f2fs_fs.h | 6 ++
mkfs/f2fs_format.c
.
4. If reconnect fails drop the node and restore filesystem metadata.
Signed-off-by: Sheng Yong
---
fsck/dir.c | 19 ++-
fsck/fsck.c | 388 ++-
fsck/fsck.h | 3 +
fsck/mount.c | 2 +
4 files changed, 409 insertions(+), 3 dele
fsck will cache all valid nat entries in memory. But when we try to
get a nat entry which is not cached, for example allocate a new nid
during reconnecting files, we need to read the uncached nat entry
from nat block again.
Signed-off-by: Sheng Yong
---
fsck/mount.c | 4 +++-
1 file changed, 3
discard obsolete dnodes after all inodes are created.
Signed-off-by: Sheng Yong
---
include/f2fs_fs.h | 5
mkfs/f2fs_format.c | 85 ++
2 files changed, 46 insertions(+), 44 deletions(-)
diff --git a/include/f2fs_fs.h b/include/f2fs_fs.h
index
Signed-off-by: Sheng Yong
Reviewed-by: Chao Yu
---
lib/libf2fs.c | 18 ++
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/lib/libf2fs.c b/lib/libf2fs.c
index e8b1842..0c684d5 100644
--- a/lib/libf2fs.c
+++ b/lib/libf2fs.c
@@ -586,24 +586,17 @@ void
In sanity_check_nid, __check_inode_mode will check i_mode value of an
inode. So integrate sanity_check_inode to __check_inode_mode to clean
up the code.
Signed-off-by: Sheng Yong
---
fsck/fsck.c | 33 +++--
1 file changed, 11 insertions(+), 22 deletions(-)
diff
t. This is used by
xfstests.
Signed-off-by: Sheng Yong
---
v2->v1:
* introduce new mount option test_dummy_context
* add sysfs entry for LOST_FOUND feature
fs/f2fs/f2fs.h | 6 ++
fs/f2fs/super.c | 37 +
fs/f2fs/sysfs.c | 7 +++
3 files changed,
s because config.h is not included first, as a result, macros
defined in config.h is not recognized. So let's include f2fs_fs.h
before other header files.
Signed-off-by: Sheng Yong
---
tools/fibmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/fibmap.c b/tools
.
4. If reconnect fails drop the node and restore filesystem metadata.
Signed-off-by: Sheng Yong
---
fsck/dir.c | 19 ++-
fsck/fsck.c | 389 ++-
fsck/fsck.h | 3 +
fsck/mount.c | 2 +
4 files changed, 410 insertions(+), 3 dele
Testcases:
1) corrupt nat_entry->blk_addr of dir [PASS]
2) corrupt nat_entry->blk_addr of encrypt-dir [PASS]
3) remove lost+found, then corrupt nat_entry->blk_addr of dir [PASS]
Any comments and tests are appreciated.
Thanks,
Sheng
Sheng Yong (2):
mkfs.f2fs: create lost+found dir
text. This is used by
xfstests.
Signed-off-by: Sheng Yong
---
v3->v2:
* fix test_dummy_encryption
v2->v1:
* introduce new mount option test_dummy_encryption
* add sysfs entry for LOST_FOUND feature
fs/f2fs/dir.c | 6 --
fs/f2fs/f2fs.h | 17 +
fs/f2fs/namei.c |
which have no parent directory or their parent
directory is removed by fsck. Encrypted files are also allowed to be
saved here.
Signed-off-by: Sheng Yong
Reviewed-by: Chao Yu
---
fsck/mount.c| 3 +
include/f2fs_fs.h | 6 ++
mkfs/f2fs_format.c
Hi, Eric
On 2018/3/7 3:38, Eric Biggers wrote:
[+Cc linux-fscrypt]
Hi Sheng,
On Tue, Mar 06, 2018 at 11:39:04AM +0800, Sheng Yong wrote:
This patch introduces a new feature, F2FS_FEATURE_LOST_FOUND, which
is set by mkfs. It creates a directory named lost+found, which saves
unreachable files
Hi, Yunlei,
On 2018/3/7 10:41, Yunlei He wrote:
fix a wrong report for dump an {d,id,did}node like this:
[print_node_info: 283] Node ID [0x6820:26656] is direct node or indirect node.
[0] [0x 16b6684 : 23815812]
[1] [0x 16b6685 : 23815813]
[2]
On 2018/3/7 11:30, heyunlei wrote:
-Original Message-
From: shengyong (A)
Sent: Wednesday, March 07, 2018 11:21 AM
To: heyunlei; jaeg...@kernel.org; Yuchao (T);
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] dump.f2fs: fix a wrong report for dump an {d,
id,
This patch introduces a new mount option `test_dummy_encryption' to
allow fscrypt to create a fake fscrypt context. This is used by xfstests.
Signed-off-by: Sheng Yong
---
fs/f2fs/dir.c | 4 +++-
fs/f2fs/f2fs.h | 11 +++
fs/f2fs/namei.c | 9 ++---
fs/f2fs/super.c
is is used by
xfstests.
Thanks,
Sheng
Sheng Yong (3):
f2fs: introduce F2FS_FEATURE_LOST_FOUND feature
f2fs: introduce a new mount option test_dummy_encryption
ext4: do not allow mount with test_dummy_encryption if encrypt not set
fs/ext4/super.c | 5 +++--
fs/f2fs/dir.c | 4 +++-
.
lost+found directory could not be encrypted. As a result, the root
directory cannot be encrypted too. So if LOST_FOUND feature is enabled,
let's avoid to encrypt root directory.
Signed-off-by: Sheng Yong
---
fs/f2fs/f2fs.h | 2 ++
fs/f2fs/super.c | 12
fs/f2fs/sysfs.c | 7 +
When mounting with test_dummy_encryption option, if encrypt feature
is not set, return fail instead of setting encrypt feature forcely.
CC: linux-e...@vger.kernel.org
Signed-off-by: Sheng Yong
---
fs/ext4/super.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/ext4
Hi, Chao
On 2018/3/9 20:32, Chao Yu wrote:
On 2018/3/9 15:53, Sheng Yong wrote:
This patch introduces a new mount option `test_dummy_encryption' to
allow fscrypt to create a fake fscrypt context. This is used by xfstests.
It needs to add doc for this new mount option.
Oh. Right,
.
lost+found directory could not be encrypted. As a result, the root
directory cannot be encrypted too. So if LOST_FOUND feature is enabled,
let's avoid to encrypt root directory.
Signed-off-by: Sheng Yong
Reviewed-by: Chao Yu
---
fs/f2fs/f2fs.h | 2 ++
fs/f2fs/super.c | 12
fs
ion
* add sysfs entry for LOST_FOUND feature
---8<---
This patchset introduces LOST_FOUND feature in f2fs. If the feature is
enabled, f2fs should avoid to encrypt root directory.
A new mount option "test_dummy_encryption" is introduced, this is used by
xfstests.
Thanks,
Sheng
She
This patch introduces a new mount option `test_dummy_encryption'
to allow fscrypt to create a fake fscrypt context. This is used
by xfstests.
Signed-off-by: Sheng Yong
---
Documentation/filesystems/f2fs.txt | 2 ++
fs/f2fs/dir.c | 4 +++-
fs/f2fs/f
When mounting with test_dummy_encryption option, if encrypt feature
is not set, return fail instead of setting encrypt feature forcely.
Cc: linux-e...@vger.kernel.org
Signed-off-by: Sheng Yong
---
fs/ext4/super.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/ext4
Hi, Ju Hyung and list,
On 2018/3/17 23:04, Park Ju Hyung wrote:
- Print errors and warnings to stderr
- Print errors and warnings regardless of debugging level
- Make info/error/warning logs consistent
- Print POSIX errors when possible
- Use more consistent terms and grammar
Shall w
Resize rebuilds checkpoint with 6 summary blocks, so if
CP_COMPACT_SUM_FLAG is set in the old checkpoint, clear it.
Signed-off-by: Sheng Yong
---
fsck/resize.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fsck/resize.c b/fsck/resize.c
index 7643511..019da71 100644
--- a/fsck/resize.c
This patch introduces a new option -V to show the version of mkfs.f2fs
and exit after that.
Signed-off-by: Sheng Yong
---
mkfs/f2fs_format_main.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c
index 3c70513..3520882
On 2018/4/10 1:55, Jaegeuk Kim wrote:
On 04/08, Chao Yu wrote:
On 2018/4/8 10:15, Sheng Yong wrote:
This patch introduces a new option -V to show the version of mkfs.f2fs
and exit after that.
BTW, should we add -V for other misc tools?
Yes, could you please add this for others?
OK
This patch introduces a new option -V to show the version of f2fs tools
and exit after that.
Signed-off-by: Sheng Yong
---
v2->v1: add -V for all f2fs tools
fsck/main.c | 30 +-
include/f2fs_fs.h | 6 ++
mkfs/f2fs_format_main.c | 6 +-
The variable `c' is declared twice in f2fs_fs.h. This patch removes
the second declaration.
Signed-off-by: Sheng Yong
---
include/f2fs_fs.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/f2fs_fs.h b/include/f2fs_fs.h
index 2b0be2d..cbfdab5 100644
--- a/include/f2fs_fs.h
`cur' will never be NULL, we should check inmem_pages list instead.
Signed-off-by: Sheng Yong
---
fs/f2fs/segment.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 5854cc4e1d67..bf9dab55b370 100644
--- a/fs/f2fs/segment.c
+++
This patch removes duplicated dquot_initialize in recover_orphan_inode(),
and fix the error handling if dquot_initialize fails.
Signed-off-by: Sheng Yong
---
fs/f2fs/checkpoint.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
Only dir may have F2FS_INLINE_DOTS flag, so there is no need to check
the flag in recover flow.
Signed-off-by: Sheng Yong
---
fs/f2fs/recovery.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
index 1b23d3febe4c..709dd4daaf29 100644
--- a/fs/f2fs
If SBI_NEED_FSCK is set, discard_wake will never be cleared. As a
result, the condition of wait_event_interruptible_timeout() is always
true, which gets discard thread run too frequently.
Signed-off-by: Sheng Yong
---
fs/f2fs/segment.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions
resize.f2fs (f2fs_defragment) tries to migrate blocks to new positions.
However, if a curseg is selected, and f2fs_defragment is broken by any
error, curseg->next_blkoff is left not updated.
To avoid this, we skip cursegs when finding next free block.
Signed-off-by: Sheng Yong
---
fsck/f2f
Hi, Jaegeuk
On 2018/6/5 4:55, Jaegeuk Kim wrote:
On 06/04, Sheng Yong wrote:
resize.f2fs (f2fs_defragment) tries to migrate blocks to new positions.
However, if a curseg is selected, and f2fs_defragment is broken by any
error, curseg->next_blkoff is left not updated.
To avoid this, we s
If curseg is an empty segment, it will not be checked. This patch
introduces fsck_chk_curseg_info() to check SIT/SSA type of cursegs
to avoid curseg corruption.
Signed-off-by: Sheng Yong
---
fsck/fsck.c | 34 ++
fsck/fsck.h | 1 +
fsck/main.c | 2 ++
3 files
1 - 100 of 293 matches
Mail list logo
