Re: [f2fs-dev] [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-17 Thread Steven Rostedt
On Fri, 17 May 2024 10:36:37 -0700 Guenter Roeck wrote: > Building csky:allmodconfig (and others) ... failed > -- > Error log: > In file included from include/trace/trace_events.h:419, > from include/trace/define_trace.h:102, > from drivers/cxl/core/t

Re: [f2fs-dev] [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-03-14 Thread Steven Rostedt
On Thu, 14 Mar 2024 09:57:57 -0700 Alison Schofield wrote: > On Fri, Feb 23, 2024 at 12:56:34PM -0500, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > > > [ > >This is a treewide change. I will likely re-create this patch again in > >

Re: [f2fs-dev] [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-02-23 Thread Steven Rostedt
On Fri, 23 Feb 2024 13:46:53 -0500 Steven Rostedt wrote: > Now one thing I could do is to not remove the parameter, but just add: > > WARN_ON_ONCE((src) != __data_offsets->item##_ptr_); > > in the __assign_str() macro to make sure that it's still the same that is

Re: [f2fs-dev] [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-02-23 Thread Steven Rostedt
On Fri, 23 Feb 2024 14:50:49 -0500 Kent Overstreet wrote: > Tangentially related though, what would make me really happy is if we > could create the string with in the TP__fast_assign() section. I have to > have a bunch of annoying wrappers right now because the string length > has to be known wh

Re: [f2fs-dev] [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-02-23 Thread Steven Rostedt
On Fri, 23 Feb 2024 10:30:45 -0800 Jeff Johnson wrote: > On 2/23/2024 9:56 AM, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > > > [ > >This is a treewide change. I will likely re-create this patch again in > >the second week of

Re: [f2fs-dev] [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-02-23 Thread Steven Rostedt
On Fri, 23 Feb 2024 12:56:34 -0500 Steven Rostedt wrote: > Note, the same updates will need to be done for: > > __assign_str_len() > __assign_rel_str() > __assign_rel_str_len() Correction: The below macros do not pass in their source to the entry macros, so they will

Re: [f2fs-dev] [PATCH v1 1/1] f2fs: Use return value of strreplace()

2023-07-10 Thread Steven Rostedt
On Wed, 28 Jun 2023 18:02:43 +0300 Andy Shevchenko wrote: > Since strreplace() returns the pointer to the string itself, > we may use it directly in the code. > > Signed-off-by: Andy Shevchenko > --- > include/trace/events/f2fs.h | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) >

Re: [f2fs-dev] [PATCH 00/79] fs: new accessors for inode->i_ctime

2023-06-21 Thread Steven Rostedt
On Wed, 21 Jun 2023 10:45:05 -0400 Jeff Layton wrote: > Most of this conversion was done via coccinelle, with a few of the more > non-standard accesses done by hand. There should be no behavioral > changes with this set. That will come later, as we convert individual > filesystems to use multigra

Re: [f2fs-dev] [PATCH v6] f2fs: add async reset zone command support

2023-05-23 Thread Steven Rostedt
On Tue, 9 May 2023 11:53:35 -0700 Jaegeuk Kim wrote: > On 05/08, Daejun Park wrote: > > v5 -> v6 > > Added trace_f2fs_iostat support for zone reset command. > > > > v4 -> v5 > > Added f2fs iostat for zone reset command. > > > > v3 -> v4 > > Fixed build error caused by unused function. > > > >

Re: [f2fs-dev] [PATCH] f2fs: Fix f2fs_truncate_partial_nodes ftrace event

2023-03-28 Thread Steven Rostedt
On Tue, 28 Mar 2023 17:36:06 -0700 Jaegeuk Kim wrote: > > I'm hoping you are not waiting for the merge window to get this in. Please > > get it to Linus before rc5 is out, because I plan on adding my patch[1] > > which will cause this to fail the build at rc5. > > > > The above is a fix to bug t

Re: [f2fs-dev] [PATCH] f2fs: Fix f2fs_truncate_partial_nodes ftrace event

2023-03-28 Thread Steven Rostedt
On Tue, 07 Mar 2023 17:40:24 + patchwork-bot+f...@kernel.org wrote: > Hello: > > This patch was applied to jaegeuk/f2fs.git (dev) > by Jaegeuk Kim : > > On Mon, 6 Mar 2023 12:25:49 + you wrote: > > From: Douglas Raillard > > > > Fix the nid_t field so that its size is correctly report

Re: [f2fs-dev] [PATCH] f2fs: Fix f2fs_truncate_partial_nodes ftrace event

2023-03-06 Thread Steven Rostedt
On Mon, 6 Mar 2023 11:15:13 -0500 Steven Rostedt wrote: > > diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h > > index 31d994e6b4ca..8d053838d6cf 100644 > > --- a/include/trace/events/f2fs.h > > +++ b/include/trace/events/f2fs.h > > @

Re: [f2fs-dev] [PATCH] f2fs: Fix f2fs_truncate_partial_nodes ftrace event

2023-03-06 Thread Steven Rostedt
On Mon, 6 Mar 2023 12:25:49 + Douglas RAILLARD wrote: > diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h > index 31d994e6b4ca..8d053838d6cf 100644 > --- a/include/trace/events/f2fs.h > +++ b/include/trace/events/f2fs.h > @@ -512,7 +512,7 @@ TRACE_EVENT(f2fs_truncate_par

Re: [f2fs-dev] [PATCH 02/12] trace: Make trace_hwlat timestamp y2038 safe

2017-04-07 Thread Steven Rostedt
trace_hwlat > and all the corresponding implementations. > > diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c > index 02a4aeb..08f9bab 100644 > --- a/kernel/trace/trace_output.c > +++ b/kernel/trace/trace_output.c > @@ -4,7 +4,6 @@ > * Copy

[f2fs-dev] [PATCH RT 19/22] f2fs: Mutex cant be used by down_write_nest_lock()

2016-03-14 Thread Steven Rostedt
Cc: rost...@goodmis.org Cc: linux-f2fs-devel@lists.sourceforge.net Cc: linux-fsde...@vger.kernel.org Cc: jaeg...@kernel.org Link: http://lkml.kernel.org/r/1456532725-4126-1-git-send-email-yang@linaro.org Signed-off-by: Thomas Gleixner Signed-off-by: Steven Rostedt --- fs/f2fs/f2fs.h | 4 +---

[f2fs-dev] [PATCH RT 17/20] f2fs: Mutex cant be used by down_write_nest_lock()

2016-03-14 Thread Steven Rostedt
Cc: rost...@goodmis.org Cc: linux-f2fs-devel@lists.sourceforge.net Cc: linux-fsde...@vger.kernel.org Cc: jaeg...@kernel.org Link: http://lkml.kernel.org/r/1456532725-4126-1-git-send-email-yang@linaro.org Signed-off-by: Thomas Gleixner Signed-off-by: Steven Rostedt --- fs/f2fs/f2fs.h | 4 +---

[f2fs-dev] [PATCH RT 14/17] f2fs: Mutex cant be used by down_write_nest_lock()

2016-03-14 Thread Steven Rostedt
Cc: rost...@goodmis.org Cc: linux-f2fs-devel@lists.sourceforge.net Cc: linux-fsde...@vger.kernel.org Cc: jaeg...@kernel.org Link: http://lkml.kernel.org/r/1456532725-4126-1-git-send-email-yang@linaro.org Signed-off-by: Thomas Gleixner Signed-off-by: Steven Rostedt --- fs/f2fs/f2fs.h | 4 +---

Re: [f2fs-dev] [RFC 5/5] f2fs: add tracepoints to debug inline data operations

2013-06-03 Thread Steven Rostedt
On Mon, 2013-06-03 at 18:04 +0800, Huajun Li wrote: > From: Haicheng Li > > Add tracepoints for: f2fs_read_inline_data(), f2fs_convert_inline_data(), > f2fs_write_inline_data(). > > Cc: Steven Rostedt > Signed-off-by: Haicheng Li > Signed-off-by: Huajun Li &