Re: [f2fs-dev] [PATCH] fs/writeback: convert wbc_account_cgroup_owner to take a folio

2024-09-26 Thread Tejun Heo via Linux-f2fs-devel
Pankaj Raghav >From cgroup writeback POV: Acked-by: Tejun Heo Thanks. -- tejun ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH v2 1/2] workqueue: new struct io_work

2024-07-02 Thread Tejun Heo
Hello, On Tue, Jul 02, 2024 at 05:27:19PM +0800, yi sun wrote: > Yes, adding the io priority attribute to work will bring huge benefits in the > following scenarios: > The system has huge IO pressure (these IOs may all be low-priority IOs), > and a work (we hope to complete quickly) is also doing

Re: [f2fs-dev] [PATCH v2 1/2] workqueue: new struct io_work

2024-07-01 Thread Tejun Heo
Hello, On Mon, Jul 01, 2024 at 03:51:37PM +0800, Yi Sun wrote: > +/* > + * If a work may do disk IO, it is recommended to use struct io_work > + * instead of struct work_struct. > + */ > +struct io_work { > + struct work_struct work; > + > + /* If the work does submit_bio, io priority may

Re: [f2fs-dev] Performance drop due to alloc_workqueue() misuse and recent change

2023-12-19 Thread Tejun Heo
Hello, again. On Mon, Dec 04, 2023 at 04:03:47PM +, Naohiro Aota wrote: ... > In summary, we misuse max_active, considering it is a global limit. And, > the recent commit introduced a huge performance drop in some cases. We > need to review alloc_workqueue() usage to check if its max_active s

Re: [f2fs-dev] Performance drop due to alloc_workqueue() misuse and recent change

2023-12-04 Thread Tejun Heo
Hello, On Mon, Dec 04, 2023 at 04:03:47PM +, Naohiro Aota wrote: > Recently, commit 636b927eba5b ("workqueue: Make unbound workqueues to use > per-cpu pool_workqueues") changed WQ_UNBOUND workqueue's behavior. It > changed the meaning of alloc_workqueue()'s max_active from an upper limit > imp

Re: [f2fs-dev] [PATCH] f2fs: fix cgroup writeback accounting with fs-layer encryption

2023-02-03 Thread Tejun Heo
the I/O to the owner > of the pagecache page as it should. > > Fix this by always passing the pagecache page to > wbc_account_cgroup_owner(). > > Fixes: 578c647879f7 ("f2fs: implement cgroup writeback support") > Cc: sta...@vger.kernel.org > Reported-by: Matthew Wil

Re: [f2fs-dev] [PATCH] fscrypt: Copy the memcg information to the ciphertext page

2023-02-02 Thread Tejun Heo
Hello, On Tue, Jan 31, 2023 at 10:31:31PM -0800, Eric Biggers wrote: > > These can usually be handled by explicitly associating the bio's to the > > desired cgroups using one of bio_associate_blkg*() or > > bio_clone_blkg_association(). > > Here that already happens in wbc_init_bio(), called from

Re: [f2fs-dev] [PATCH] fscrypt: Copy the memcg information to the ciphertext page

2023-01-31 Thread Tejun Heo
Hello, On Sun, Jan 29, 2023 at 09:26:57PM +, Matthew Wilcox wrote: > > > diff --git a/fs/crypto/crypto.c b/fs/crypto/crypto.c > > > index e78be66bbf01..a4e76f96f291 100644 > > > --- a/fs/crypto/crypto.c > > > +++ b/fs/crypto/crypto.c > > > @@ -205,6 +205,9 @@ struct page *fscrypt_encrypt_pagec

Re: [f2fs-dev] [GIT PULL] f2fs update for 4.16-rc1

2018-04-03 Thread Tejun Heo
Hello, Stephen. On Tue, Apr 03, 2018 at 12:29:19PM +1000, Stephen Rothwell wrote: > > I am still applying this to the merge of the btrfs tree every day ... > > > > Commit > > 578c647879f7 ("f2fs: implement cgroup writeback support") > > was merged into Linus' tree on Jan 31. > > > > Here is th