Re: [f2fs-dev] [PATCH v3 2/2] f2fs: enable fast symlink by utilizing inline data

2015-03-24 Thread Wanpeng Li
Just see it merged, sorry for the noise. On Tue, Mar 24, 2015 at 03:41:59PM +0800, Wanpeng Li wrote: >Ping this one. >On Tue, Mar 24, 2015 at 10:20:28AM +0800, Wanpeng Li wrote: >>Fast symlink can utilize inline data flow to avoid using any >>i_addr region, since we need to hand

Re: [f2fs-dev] [PATCH v3 2/2] f2fs: enable fast symlink by utilizing inline data

2015-03-24 Thread Wanpeng Li
Ping this one. On Tue, Mar 24, 2015 at 10:20:28AM +0800, Wanpeng Li wrote: >Fast symlink can utilize inline data flow to avoid using any >i_addr region, since we need to handle many cases such as >truncation, roll-forward recovery, and fsck/dump tools. > >Signed-off-by: Wanpeng Li

[f2fs-dev] [PATCH v3 2/2] f2fs: enable fast symlink by utilizing inline data

2015-03-23 Thread Wanpeng Li
Fast symlink can utilize inline data flow to avoid using any i_addr region, since we need to handle many cases such as truncation, roll-forward recovery, and fsck/dump tools. Signed-off-by: Wanpeng Li --- fs/f2fs/inline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs

[f2fs-dev] [PATCH v3 1/2] f2fs: enable inline data by default

2015-03-23 Thread Wanpeng Li
Enable inline_data feature by default since it brings us better performance and space utilization and now has already stable. Add another option noinline_data to disable it during mount. Suggested-by: Jaegeuk Kim Suggested-by: Chao Yu Signed-off-by: Wanpeng Li --- v2 -> v3: * re

Re: [f2fs-dev] [PATCH v2 1/2] f2fs: enable inline data by default

2015-03-23 Thread Wanpeng Li
line_data, noinline_data" w/ noinline_data mount option, just >> "rw,noinline_data" dump out. > >Try 'cat /proc/mounts'? Ah, I just try mount command, and "inline_data, noinline_data" dump out when cat /proc/mounts, I will fix it soon. Reg

Re: [f2fs-dev] [PATCH v2 1/2] f2fs: enable inline data by default

2015-03-23 Thread Wanpeng Li
Hi Chao, On Mon, Mar 23, 2015 at 03:25:45PM +0800, Chao Yu wrote: >Hi Wanpeng, > >> -Original Message----- >> From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] >> Sent: Monday, March 23, 2015 7:44 AM >> To: Jaegeuk Kim >> Cc: Changman Lee; Chao Yu; li

[f2fs-dev] [PATCH v2 2/2] f2fs: enable fast symlink by utilizing inline data

2015-03-22 Thread Wanpeng Li
Fast symlink can utilize inline data flow to avoid using any i_addr region, since we need to handle many cases such as truncation, roll-forward recovery, and fsck/dump tools. Signed-off-by: Wanpeng Li --- fs/f2fs/inline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs

[f2fs-dev] [PATCH v2 1/2] f2fs: enable inline data by default

2015-03-22 Thread Wanpeng Li
Enable inline_data feature by default since it brings us better performance and space utilization and now has already stable. Add another option noinline_data to disable it during mount. Suggested-by: Jaegeuk Kim Suggested-by: Chao Yu Signed-off-by: Wanpeng Li --- v1 -> v2: * ret

Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-22 Thread Wanpeng Li
"? Will do, thanks for you and Chao's help. Regards, Wanpeng Li > >Thanks, > >On Thu, Mar 19, 2015 at 11:17:17AM +0800, Chao Yu wrote: >> Hi Wanpeng, >> >> > -Original Message- >> > From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] &

[f2fs-dev] [PATCH] f2fs: enable fast symlink by utilizing inline data

2015-03-18 Thread Wanpeng Li
Fast symlink can utilize inline data flow to avoid using any i_addr region, since we need to handle many cases such as truncation, roll-forward recovery, and fsck/dump tools. Signed-off-by: Wanpeng Li --- fs/f2fs/inline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs

[f2fs-dev] [PATCH] f2fs: enable inline data by default

2015-03-18 Thread Wanpeng Li
Enable inline_data feature by default since it brings us better performance and space utilization and now has already stable. Signed-off-by: Wanpeng Li --- Documentation/filesystems/f2fs.txt | 2 -- fs/f2fs/f2fs.h | 11 +-- fs/f2fs/inline.c | 3

Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-18 Thread Wanpeng Li
Hi Jaegeuk, On Wed, Mar 18, 2015 at 11:05:28AM -0700, Jaegeuk Kim wrote: >Hi, > >On Wed, Mar 18, 2015 at 04:58:52PM +0800, Wanpeng Li wrote: >> Hi Jaegeuk, >> On Tue, Mar 17, 2015 at 10:21:27AM -0700, Jaegeuk Kim wrote: >> >> - err = page_symlink(inode, symname, sy

Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-18 Thread Wanpeng Li
't recommend using any i_addr region, since we need to handle >many cases such as truncation, roll-forward recovery, and fsck/dump tools. > >It is more sensible to enable inline_data by default, isn't it? Do you mean to replace the codes above by something lik

Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-16 Thread Wanpeng Li
Hi Chao, On Mon, Mar 16, 2015 at 09:03:30PM +0800, Chao Yu wrote: >Hi Wanpeng, Jaegeuk, > >> -Original Message----- >> From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] >> Sent: Friday, March 13, 2015 2:34 PM >> To: Jaegeuk Kim >> Cc: Cha

Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-16 Thread Wanpeng Li
Ping Jaegeuk, On Fri, Mar 13, 2015 at 02:33:39PM +0800, Wanpeng Li wrote: >This patch introduces the improvement fast symlinks to allow storage of >the target path within inode, thus symlinks with short target paths are >more accessed quickly. It will fall back to using the original slow

[f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-12 Thread Wanpeng Li
This patch introduces the improvement fast symlinks to allow storage of the target path within inode, thus symlinks with short target paths are more accessed quickly. It will fall back to using the original slow symlink if the target path exceeds the available inode space. Signed-off-by: Wanpeng

[f2fs-dev] [PATCH v2] f2fs: add fast symlink support

2015-03-12 Thread Wanpeng Li
This patch introduces the improvement fast symlinks to allow storage of the target path within inode, thus symlinks with short target paths are more accessed quickly. It will fall back to using the original slow symlink if the target path exceeds the available inode space. Signed-off-by: Wanpeng

Re: [f2fs-dev] [PATCH RFC] f2fs: add fast symlink

2015-03-12 Thread Wanpeng Li
Hi Chao, On Thu, Mar 12, 2015 at 05:02:47PM +0800, Chao Yu wrote: >Hi Wanpeng, > >> -Original Message----- >> From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] >> Sent: Thursday, March 12, 2015 2:42 PM >> To: Chao Yu >> Cc: 'Wanpeng Li'; '

Re: [f2fs-dev] [PATCH RFC] f2fs: add fast symlink

2015-03-12 Thread Wanpeng Li
view, I just handle all your comments and it works well. Btw, one question, if inline xattr data area is reserved in inode even if it isn't mounted w/ inline_xattr option? If yes, why it is reserved? Regards, Wanpeng Li --

Re: [f2fs-dev] [PATCH] f2fs: add fast symlink support

2015-03-11 Thread Wanpeng Li
Sorry, please ignore this one which w/o patch description. On Thu, Mar 12, 2015 at 02:35:33PM +0800, Wanpeng Li wrote: >Signed-off-by: Wanpeng Li >--- > fs/f2fs/f2fs.h | 15 ++ > fs/f2fs/file.c | 2 ++ > fs/f2fs/inode.c | 9 +++-- &g

[f2fs-dev] [PATCH] f2fs: add fast symlink support

2015-03-11 Thread Wanpeng Li
: Wanpeng Li --- fs/f2fs/f2fs.h | 15 ++ fs/f2fs/file.c | 2 ++ fs/f2fs/inode.c | 9 +++-- fs/f2fs/namei.c | 53 + include/linux/f2fs_fs.h | 2 ++ 5 files changed, 75 insertions(+), 6 deletions(-) diff

[f2fs-dev] [PATCH] f2fs: add fast symlink support

2015-03-11 Thread Wanpeng Li
Signed-off-by: Wanpeng Li --- fs/f2fs/f2fs.h | 15 ++ fs/f2fs/file.c | 2 ++ fs/f2fs/inode.c | 9 +++-- fs/f2fs/namei.c | 53 + include/linux/f2fs_fs.h | 2 ++ 5 files changed, 75 insertions

[f2fs-dev] [PATCH RFC] f2fs: add fast symlink

2015-03-11 Thread Wanpeng Li
This patch add fast symlink for f2fs, I'm not sure if inline interference with fast symlink, f2fs_follow_link can't be called in my patch, so my patch still can't work correctly, please help review and give comments to help me out. Signed-off-by: Wanpeng Li --- fs/f2

Re: [f2fs-dev] [PATCH 2/3] f2fs: fix get stale meta pages when build free nids

2015-03-08 Thread Wanpeng Li
Hi Jaegeuk, On Sun, Mar 08, 2015 at 09:18:47PM -0700, Jaegeuk Kim wrote: >Hi Wanpeng, > >On Mon, Mar 09, 2015 at 11:00:54AM +0800, Wanpeng Li wrote: >> The blocks of nat pages to be scanned will be readahead when build free >> nids. The start blkno will be adjusted to 0 wh

[f2fs-dev] [PATCH 2/3] f2fs: fix get stale meta pages when build free nids

2015-03-08 Thread Wanpeng Li
the meta pages w/ stale blkno, this patch fix it by adjusting the nid and the blkno which will be readahead in avdance in order to readahead and get the right meta pages. Signed-off-by: Wanpeng Li --- fs/f2fs/checkpoint.c | 3 --- fs/f2fs/node.c | 9 - 2 files changed, 8

[f2fs-dev] [PATCH 1/3] f2fs: guarantee node/meta inode number won't be reused

2015-03-08 Thread Wanpeng Li
Node/Meta inode numbers are also should not be reused, this patch guarantee it. Signed-off-by: Wanpeng Li --- fs/f2fs/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 4687eae..1a7e925 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs

[f2fs-dev] [PATCH 3/3] f2fs: fix unlocked nat set cache operation

2015-03-08 Thread Wanpeng Li
nat set cache. Signed-off-by: Wanpeng Li --- fs/f2fs/node.c | 5 + 1 file changed, 5 insertions(+) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 8751375..14e4387 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1837,6 +1837,7 @@ static void __flush_nat_entry_set(struct f2fs_sb_in

[f2fs-dev] [PATCH 1/2] f2fs: fix extent cache memory leak

2015-03-05 Thread Wanpeng Li
extent tree/node slab cache is created during f2fs insmod, how, it isn't destroyed during f2fs rmmod, this patch fix it by destroy extent tree/node slab cache once rmmod f2fs. Signed-off-by: Wanpeng Li --- fs/f2fs/super.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/f2fs/super.c

[f2fs-dev] [PATCH 2/2] f2fs: reduce searching region of segmap when set free section

2015-03-05 Thread Wanpeng Li
of target section. Signed-off-by: Wanpeng Li --- fs/f2fs/segment.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h index 7fd3511..85d7fa7 100644 --- a/fs/f2fs/segment.h +++ b/fs/f2fs/segment.h @@ -336,7 +336,8 @@ static inline void __set_f

Re: [f2fs-dev] [PATCH v2] f2fs: fix max orphan inodes calculation

2015-03-05 Thread Wanpeng Li
Cc: Jaegeuk Kim; Chao Yu; linux-fsde...@vger.kernel.org; >> linux-ker...@vger.kernel.org >> Subject: Re: [PATCH v2] f2fs: fix max orphan inodes calculation >> >> On Fri, Feb 27, 2015 at 05:38:13PM +0800, Wanpeng Li wrote: >> > cp_payload is introduced for sit b

[f2fs-dev] [PATCH v2] f2fs: fix max orphan inodes calculation

2015-02-27 Thread Wanpeng Li
yload, this patch fix it by reducing the number of cp_payload from total blocks of the first segment when calculate max orphan inodes. Signed-off-by: Wanpeng Li --- v1 -> v2: * adjust comments above the codes * fix coding style issue fs/f2fs/checkpoint.c | 12 +++- 1 file ch

Re: [f2fs-dev] [PATCH] f2fs: fix max orphan inodes calculation

2015-02-27 Thread Wanpeng Li
Hi Chao, On Fri, Feb 27, 2015 at 05:39:39PM +0800, Chao Yu wrote: >Hi Wanpeng, > >> -Original Message----- >> From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] >> Sent: Friday, February 27, 2015 3:05 PM >> To: Jaegeuk Kim >> Cc: Wanpeng Li; linux-ker...@v

Re: [f2fs-dev] [PATCH 2/2] f2fs: fix the number of orphan inode blocks

2015-02-27 Thread Wanpeng Li
Hi Chao, On Thu, Feb 26, 2015 at 09:33:55AM +0800, Chao Yu wrote: >Hi Wanpeng, > >> -Original Message----- >> From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] >> Sent: Thursday, February 26, 2015 7:57 AM >> To: Jaegeuk Kim >> Cc: Wanpeng Li; linux-ke

Re: [f2fs-dev] [PATCH] f2fs: don't need to collect dirty sit entries and flush journal when there's no dirty sit entries

2015-02-27 Thread Wanpeng Li
Please ignore this one which w/o patch description. On Fri, Feb 27, 2015 at 04:49:37PM +0800, Wanpeng Li wrote: >Signed-off-by: Wanpeng Li >--- > fs/f2fs/segment.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/fs/f2fs/segment.c b/fs/f2fs/segmen

[f2fs-dev] [PATCH] f2fs: don't need to collect dirty sit entries and flush journal when there's no dirty sit entries

2015-02-27 Thread Wanpeng Li
Don't need to collect dirty sit entries and flush sit journal to sit entries when there's no dirty sit entries. This patch check dirty_sentries earlier just like flush_nat_entries. Signed-off-by: Wanpeng Li --- fs/f2fs/segment.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[f2fs-dev] [PATCH] f2fs: don't need to collect dirty sit entries and flush journal when there's no dirty sit entries

2015-02-27 Thread Wanpeng Li
Signed-off-by: Wanpeng Li --- fs/f2fs/segment.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index daee4ab..e7b83b6 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -1730,6 +1730,9 @@ void flush_sit_entries(struct

[f2fs-dev] [PATCH] f2fs: fix block_ops trace point

2015-02-27 Thread Wanpeng Li
start premature even if block_ops doesn't have opportunity to execute. This patch fix it by move block_ops trace point just before block_ops. Signed-off-by: Wanpeng Li --- fs/f2fs/checkpoint.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/ch

[f2fs-dev] [PATCH] f2fs: fix max orphan inodes calculation

2015-02-26 Thread Wanpeng Li
sider cp_payload, this patch fix it by reducing the number of cp_payload from total blocks of the first segment when calculate max orphan inodes. Signed-off-by: Wanpeng Li --- fs/f2fs/checkpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpo

[f2fs-dev] [PATCH 2/2] f2fs: fix the number of orphan inode blocks

2015-02-25 Thread Wanpeng Li
cp payload blocks when calculate the number of orphan inode blocks. This patch fix it. Signed-off-by: Wanpeng Li --- fs/f2fs/checkpoint.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index 4dbcc81..db82e09 100644 --- a/fs

[f2fs-dev] [PATCH 1/2] f2fs: introduce macro __cp_payload

2015-02-25 Thread Wanpeng Li
This patch introduce macro __cp_payload. Signed-off-by: Wanpeng Li --- fs/f2fs/checkpoint.c | 7 +++ fs/f2fs/f2fs.h | 7 ++- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index 7f794b7..4dbcc81 100644 --- a/fs/f2fs

Re: [f2fs-dev] [PATCH] f2fs: fix recover orphan inodes

2015-02-25 Thread Wanpeng Li
Hi Jaegeuk, On Wed, Feb 25, 2015 at 10:35:23AM -0800, Jaegeuk Kim wrote: >Hi Wanpeng, > >On Wed, Feb 25, 2015 at 12:53:37PM +0800, Wanpeng Li wrote: >> recover_orphan_inodes is used to recover orphan inodes, the meta pages >> which readahead should be orphan_blkaddr -

[f2fs-dev] [PATCH] f2fs: fix recover orphan inodes

2015-02-25 Thread Wanpeng Li
recover_orphan_inodes is used to recover orphan inodes, the meta pages which readahead should be orphan_blkaddr - start_blk instead of orphan_blkaddr. This patch fix it. Signed-off-by: Wanpeng Li --- fs/f2fs/checkpoint.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a